Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/extensions/api/extension_action/extension_action_api.h

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bookmarks Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // browser notification requirements, and not all functions are defined for all 118 // browser notification requirements, and not all functions are defined for all
119 // APIs). 119 // APIs).
120 class ExtensionActionFunction : public ChromeSyncExtensionFunction { 120 class ExtensionActionFunction : public ChromeSyncExtensionFunction {
121 public: 121 public:
122 static bool ParseCSSColorString(const std::string& color_string, 122 static bool ParseCSSColorString(const std::string& color_string,
123 SkColor* result); 123 SkColor* result);
124 124
125 protected: 125 protected:
126 ExtensionActionFunction(); 126 ExtensionActionFunction();
127 virtual ~ExtensionActionFunction(); 127 virtual ~ExtensionActionFunction();
128 virtual bool RunImpl() OVERRIDE; 128 virtual bool RunSync() OVERRIDE;
129 virtual bool RunExtensionAction() = 0; 129 virtual bool RunExtensionAction() = 0;
130 130
131 bool ExtractDataFromArguments(); 131 bool ExtractDataFromArguments();
132 void NotifyChange(); 132 void NotifyChange();
133 void NotifyBrowserActionChange(); 133 void NotifyBrowserActionChange();
134 void NotifyLocationBarChange(); 134 void NotifyLocationBarChange();
135 void NotifySystemIndicatorChange(); 135 void NotifySystemIndicatorChange();
136 bool SetVisible(bool visible); 136 bool SetVisible(bool visible);
137 137
138 // Extension-related information for |tab_id_|. 138 // Extension-related information for |tab_id_|.
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 // Implement chrome.pageActions.enableForTab(). 442 // Implement chrome.pageActions.enableForTab().
443 class EnablePageActionsFunction : public PageActionsFunction { 443 class EnablePageActionsFunction : public PageActionsFunction {
444 public: 444 public:
445 DECLARE_EXTENSION_FUNCTION("pageActions.enableForTab", 445 DECLARE_EXTENSION_FUNCTION("pageActions.enableForTab",
446 PAGEACTIONS_ENABLEFORTAB) 446 PAGEACTIONS_ENABLEFORTAB)
447 447
448 protected: 448 protected:
449 virtual ~EnablePageActionsFunction() {} 449 virtual ~EnablePageActionsFunction() {}
450 450
451 // ExtensionFunction: 451 // ExtensionFunction:
452 virtual bool RunImpl() OVERRIDE; 452 virtual bool RunSync() OVERRIDE;
453 }; 453 };
454 454
455 // Implement chrome.pageActions.disableForTab(). 455 // Implement chrome.pageActions.disableForTab().
456 class DisablePageActionsFunction : public PageActionsFunction { 456 class DisablePageActionsFunction : public PageActionsFunction {
457 public: 457 public:
458 DECLARE_EXTENSION_FUNCTION("pageActions.disableForTab", 458 DECLARE_EXTENSION_FUNCTION("pageActions.disableForTab",
459 PAGEACTIONS_DISABLEFORTAB) 459 PAGEACTIONS_DISABLEFORTAB)
460 460
461 protected: 461 protected:
462 virtual ~DisablePageActionsFunction() {} 462 virtual ~DisablePageActionsFunction() {}
463 463
464 // ExtensionFunction: 464 // ExtensionFunction:
465 virtual bool RunImpl() OVERRIDE; 465 virtual bool RunSync() OVERRIDE;
466 }; 466 };
467 467
468 #endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H _ 468 #endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H _
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698