chrome/browser/extensions/api/module/module.cc - Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/module/module.cc

Issue 252653002: Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bookmarks Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/module/module.h ('k') | chrome/browser/extensions/api/networking_private/networking_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/module/module.cc

diff --git a/chrome/browser/extensions/api/module/module.cc b/chrome/browser/extensions/api/module/module.cc

index 87b2d33182116e9b419b0f572595f9c12f55c7a2..07e1f8a473a370204f45c437597fc19574dd1053 100644

--- a/chrome/browser/extensions/api/module/module.cc

+++ b/chrome/browser/extensions/api/module/module.cc

@@ -36,7 +36,7 @@ std::string GetUpdateURLData(const ExtensionPrefs* prefs,

} // namespace extension

-bool ExtensionSetUpdateUrlDataFunction::RunImpl() {

+bool ExtensionSetUpdateUrlDataFunction::RunSync() {

std::string data;

EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &data));

@@ -51,13 +51,13 @@ bool ExtensionSetUpdateUrlDataFunction::RunImpl() {

return true;

}

-bool ExtensionIsAllowedIncognitoAccessFunction::RunImpl() {

+bool ExtensionIsAllowedIncognitoAccessFunction::RunSync() {

SetResult(new base::FundamentalValue(

util::IsIncognitoEnabled(extension_id(), GetProfile())));

return true;

}

-bool ExtensionIsAllowedFileSchemeAccessFunction::RunImpl() {

+bool ExtensionIsAllowedFileSchemeAccessFunction::RunSync() {

SetResult(new base::FundamentalValue(

util::AllowFileAccess(extension_id(), GetProfile())));

return true;