Rename (Chrome)SyncExtensionFunction::RunImpl to RunSync so that the RunImpl

extensions/browser/extension_function.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
 #define EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_
 
 #include <list>
 #include <string>
 
@@ skipping 106 matching lines @@
   //
   // This will be run after the function has been set up but before Run().
   virtual bool HasPermission();
 
   // Execute the API. Clients should initialize the ExtensionFunction using
   // SetArgs(), set_request_id(), and the other setters before calling this
   // method. Derived classes should be ready to return GetResultList() and
   // GetError() before returning from this function.
   // Note that once Run() returns, dispatcher() can be NULL, so be sure to
   // NULL-check.
-  virtual void Run();
+  void Run();

[Ken Rockot(use gerrit already), 2014/04/25 04:01:36]

The "Derived classes..." part of this documentation doesn't really apply to
Run() any more

[not at google - send to devlin, 2014/04/28 22:38:15]

oops missed this comment. i have the comment fix in a staged patch.

 
   // Gets whether quota should be applied to this individual function
   // invocation. This is different to GetQuotaLimitHeuristics which is only
   // invoked once and then cached.
   //
   // Returns false by default.
   virtual bool ShouldSkipQuotaLimiting() const;
 
   // Optionally adds one or multiple QuotaLimitHeuristic instances suitable for
   // this function to |heuristics|. The ownership of the new QuotaLimitHeuristic
@@ skipping 357 matching lines @@
 // *relative to the browser's UI thread*. Note that this has nothing to do with
 // running synchronously relative to the extension process. From the extension
 // process's point of view, the function is still asynchronous.
 //
 // This kind of function is convenient for implementing simple APIs that just
 // need to interact with things on the browser UI thread.
 class SyncExtensionFunction : public UIThreadExtensionFunction {
  public:
   SyncExtensionFunction();
 
-  virtual void Run() OVERRIDE;
+  virtual bool RunImpl() OVERRIDE;
 
  protected:
+  virtual bool RunSync() = 0;
+
   virtual ~SyncExtensionFunction();
 };
 
 class SyncIOThreadExtensionFunction : public IOThreadExtensionFunction {
  public:
   SyncIOThreadExtensionFunction();
 
-  virtual void Run() OVERRIDE;
+  virtual bool RunImpl() OVERRIDE;
 
  protected:
+  virtual bool RunSync() = 0;
+
   virtual ~SyncIOThreadExtensionFunction();
 };
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_H_