Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)

Created:
4 years, 1 month ago by caseq
Modified:
4 years, 1 month ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: remove TimelineModel inferred properties from TracingModel.Event This removed a bunch of properties computed by WI.TimelineModel and WI.InvalidationTracker from WI.TracingModel.Event since this is a layering violation. The former go to WI.TimelineData that is assoiciated with WI.TracingModel.Event by a Symbol, and the latter are an array associated with the event in a similar fashion. This still leaves own time on the WI.TracingModel.Event, we'll take care of this later. Committed: https://crrev.com/a4987361ccec93fa698fc6443529c08a74522b01 Cr-Commit-Position: refs/heads/master@{#431470}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments and rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -255 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js View 1 3 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/decode-resize.html View 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/scroll-invalidations.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-reason.html View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html View 3 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations.html View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html View 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.html View 5 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations.html View 3 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html View 3 chunks +7 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 20 chunks +64 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js View 1 14 chunks +113 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
caseq
4 years, 1 month ago (2016-11-08 18:56:05 UTC) #2
alph
lgtm https://codereview.chromium.org/2486853002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/2486853002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode674 third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:674: } else if (WebInspector.TimelineData.forEvent(event).picture) need {} https://codereview.chromium.org/2486853002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js File ...
4 years, 1 month ago (2016-11-09 00:46:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486853002/20001
4 years, 1 month ago (2016-11-10 22:47:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 02:36:28 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:46:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4987361ccec93fa698fc6443529c08a74522b01
Cr-Commit-Position: refs/heads/master@{#431470}

Powered by Google App Engine
This is Rietveld 408576698