third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js - Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)

Patch Set: addressed comments and rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

index 88f01d9742cbf646eb9bf6f4e3bd6c667a0b407d..fed1da0d3f6b8767f8b92274b2a64a6a00f25df1 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

@@ -379,7 +379,7 @@ WebInspector.TimelineEventOverviewResponsiveness = class extends WebInspector.Ti

var events = this._model.mainThreadEvents();

for (var i = 0; i < events.length; ++i) {

- if (!events[i].warning)

+ if (!WebInspector.TimelineData.forEvent(events[i]).warning)

continue;

paintWarningDecoration(events[i].startTime, events[i].duration);

}