third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js - Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)

Patch Set: addressed comments and rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

index 95871301eec5e492fab10a6443b7709228fe1ad5..148752bc3cec7b4380f892d3944872512fb2fba5 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePaintProfilerView.js

@@ -63,7 +63,7 @@ WebInspector.TimelinePaintProfilerView = class extends WebInspector.SplitWidget

this._updateWhenVisible();

if (this._event.name === WebInspector.TimelineModel.RecordType.Paint)

- return !!event.picture;

+ return !!WebInspector.TimelineData.forEvent(event).picture;

if (this._event.name === WebInspector.TimelineModel.RecordType.RasterTask)

return this._frameModel.hasRasterTile(this._event);

return false;

@@ -84,7 +84,8 @@ WebInspector.TimelinePaintProfilerView = class extends WebInspector.SplitWidget

if (this._pendingSnapshot)

snapshotPromise = Promise.resolve({rect: null, snapshot: this._pendingSnapshot});

else if (this._event.name === WebInspector.TimelineModel.RecordType.Paint) {

- snapshotPromise = this._event.picture.objectPromise()

+ var picture = WebInspector.TimelineData.forEvent(this._event).picture;

+ snapshotPromise = picture.objectPromise()

.then(data => WebInspector.PaintProfilerSnapshot.load(this._target, data['skp64']))

.then(snapshot => snapshot && {rect: null, snapshot: snapshot});

} else if (this._event.name === WebInspector.TimelineModel.RecordType.RasterTask) {