Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)
Patch Set: addressed comments and rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/decode-resize.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
index 013eaf4d59a1e86f9842fcc3b5134173c23b868d..f4beaf5742c3f323e2abbca4bee32618e981ef85 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
@@ -223,7 +223,7 @@ InspectorTest.printTimelineRecordsWithDetails = function(typeName)
return;
var event = record.traceEvent();
InspectorTest.addResult("Text details for " + record.type() + ": " + InspectorTest.detailsTextForTraceEvent(event));
- if (event.warning)
+ if (WebInspector.TimelineData.forEvent(event).warning)
InspectorTest.addResult(record.type() + " has a warning");
}
@@ -339,7 +339,7 @@ InspectorTest.printTraceEventProperties = function(traceEvent)
data: traceEvent.args["data"] || traceEvent.args,
endTime: traceEvent.endTime || traceEvent.startTime,
frameId: frameId,
- stackTrace: traceEvent.stackTrace,
+ stackTrace: WebInspector.TimelineData.forEvent(traceEvent).stackTrace,
startTime: traceEvent.startTime,
type: traceEvent.name,
};
@@ -404,6 +404,12 @@ InspectorTest.dumpFrame = function(frame)
InspectorTest.addObject(formatFields(frame));
}
+InspectorTest.dumpInvalidations = function(recordType, index, comment)
+{
+ var record = InspectorTest.findTimelineRecord(recordType, index || 0);
+ InspectorTest.addArray(WebInspector.InvalidationTracker.invalidationEventsFor(record._event), InspectorTest.InvalidationFormatters, "", comment);
+}
+
InspectorTest.FakeFileReader.prototype = {
start: function(output)
{
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/decode-resize.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698