third_party/WebKit/Source/devtools/front_end/Tests.js - Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)

Patch Set: addressed comments and rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/Tests.js

diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js

index e821282a6a4b07b5fb8d9f26a85fcfa0837f0662..b97f02a18e88d4189ca5107d45556a047d8e1935 100644

--- a/third_party/WebKit/Source/devtools/front_end/Tests.js

+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js

@@ -976,7 +976,7 @@

continue;

if (e.steps.length < 2)

continue;

- if (e.name.startsWith(prefix + 'Mouse') && typeof e.steps[0].timeWaitingForMainThread !== 'number')

+ if (e.name.startsWith(prefix + 'Mouse') && typeof WebInspector.TimelineData.forEvent(e.steps[0]).timeWaitingForMainThread !== 'number')

throw `Missing timeWaitingForMainThread on ${e.name}`;

expectedEvents.delete(e.name.substr(prefix.length));

}