Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)
Patch Set: addressed comments and rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html
index d70ffe8329fb3e126b9c35f3301a771114c14b9e..463ffad0ee665d47fe454a97d58ac64f955bf3db 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html
@@ -31,8 +31,7 @@ function test()
function testLocalFrame(next)
{
InspectorTest.invokeAsyncWithTimeline("display", function() {
- var record = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Paint);
- InspectorTest.addArray(record._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "paint invalidations");
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Paint, 0, "paint invalidations");
next();
});
},
@@ -42,12 +41,11 @@ function test()
InspectorTest.invokeAsyncWithTimeline("updateSubframeAndDisplay", function() {
// The first paint corresponds to the local frame and should have no invalidations.
var firstPaintRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Paint);
- var firstInvalidations = firstPaintRecord._event.invalidationTrackingEvents;
- InspectorTest.assertEquals(firstInvalidations, undefined);
+ var firstInvalidations = WebInspector.InvalidationTracker.invalidationEventsFor(firstPaintRecord._event);
+ InspectorTest.assertEquals(firstInvalidations, null);
// The second paint corresponds to the subframe and should have our layout/style invalidations.
- var secondPaintRecord = InspectorTest.findTimelineRecord(WebInspector.TimelineModel.RecordType.Paint, 1);
- InspectorTest.addArray(secondPaintRecord._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "second paint invalidations");
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Paint, 1, "second paint invalidations");
next();
});
@@ -61,4 +59,4 @@ function test()
<div id="testElement">FAIL - this should not be present when the test finishes.</div>
<iframe src="../resources/timeline-iframe-paint.html" style="position: absolute; left: 40px; top: 40px; width: 100px; height: 100px; border: none"></iframe>
</body>
-</html>
+</html>

Powered by Google App Engine
This is Rietveld 408576698