third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js - Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)

Patch Set: addressed comments and rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/Tests.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

index ad02e5b7b08a4f972aff94039eda06b503b90cb4..3047ee6b2e10778a014a080b3061462894a51c46 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js

@@ -111,7 +111,7 @@ WebInspector.CPUProfileDataModel = class extends WebInspector.ProfileTreeModel {

function isNativeNode(node) {

if (node.callFrame)

return !!node.callFrame.url && node.callFrame.url.startsWith('native ');

- return !!node.url && node.url.startsWith('native ');

+ return !!node['url'] && node['url'].startsWith('native ');

}

/**

* @param {!Array<!Protocol.Profiler.ProfileNode>} nodes