Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)
Patch Set: addressed comments and rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html
index 1ba107511405fca52d28396f1c30124df3b9106f..5b37aad9b159f313c462db0b766cc9f28aa7f735 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html
@@ -25,9 +25,7 @@ function test()
function testLocalFrame(next)
{
InspectorTest.invokeAsyncWithTimeline("display", function() {
- var record = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Paint);
- InspectorTest.addArray(record._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "first paint invalidations");
-
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Paint, 0, "first paint invalidations");
next();
});
},
@@ -37,13 +35,11 @@ function test()
InspectorTest.invokeAsyncWithTimeline("updateSubframeAndDisplay", function() {
// The first paint corresponds to the local frame and should have no invalidations.
var firstPaintRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Paint);
- var firstInvalidations = firstPaintRecord._event.invalidationTrackingEvents;
- InspectorTest.assertEquals(firstInvalidations, undefined);
+ var firstInvalidations = WebInspector.InvalidationTracker.invalidationEventsFor(firstPaintRecord._event);
+ InspectorTest.assertEquals(firstInvalidations, null);
// The second paint corresponds to the subframe and should have our style invalidations.
- var secondPaintRecord = InspectorTest.findTimelineRecord(WebInspector.TimelineModel.RecordType.Paint, 1);
- InspectorTest.addArray(secondPaintRecord._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "second paint invalidations");
-
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Paint, 1, "second paint invalidations");
next();
});
}

Powered by Google App Engine
This is Rietveld 408576698