Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)
Patch Set: addressed comments and rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html
index 716e2236b16f42cb0ea9950f3408bb1c909ceae2..9d8bbfa05d2ed213a2b523d995444c2f752c64ae 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html
@@ -30,12 +30,8 @@ function test()
function testLocalFrame(next)
{
InspectorTest.invokeAsyncWithTimeline("display", function() {
- var firstLayoutRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Layout);
- InspectorTest.addArray(firstLayoutRecord._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "first layout invalidations");
-
- var secondLayoutRecord = InspectorTest.findTimelineRecord(WebInspector.TimelineModel.RecordType.Layout, 1);
- InspectorTest.addArray(secondLayoutRecord._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "second layout invalidations");
-
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Layout, 0, "first layout invalidations");
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Layout, 1, "second layout invalidations");
next();
});
},
@@ -43,12 +39,8 @@ function test()
function testSubframe(next)
{
InspectorTest.invokeAsyncWithTimeline("updateSubframeAndDisplay", function() {
- var firstLayoutRecord = InspectorTest.findFirstTimelineRecord(WebInspector.TimelineModel.RecordType.Layout);
- InspectorTest.addArray(firstLayoutRecord._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "first layout invalidations");
-
- var secondLayoutRecord = InspectorTest.findTimelineRecord(WebInspector.TimelineModel.RecordType.Layout, 1);
- InspectorTest.addArray(secondLayoutRecord._event.invalidationTrackingEvents, InspectorTest.InvalidationFormatters, "", "second layout invalidations");
-
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Layout, 0, "first layout invalidations");
+ InspectorTest.dumpInvalidations(WebInspector.TimelineModel.RecordType.Layout, 1, "second layout invalidations");
next();
});
}
@@ -61,4 +53,4 @@ function test()
<div id="outerTestElement" style="display: inline-block;"><div id="testElement">PASS</div></div>
<iframe src="../resources/timeline-iframe-paint.html" style="position: absolute; left: 40px; top: 40px; width: 100px; height: 100px; border: none"></iframe>
</body>
-</html>
+</html>

Powered by Google App Engine
This is Rietveld 408576698