third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html - Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)

Patch Set: addressed comments and rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html

index 7a0b2ece8805ef8c588694a48819d7f717562e4e..34142ec6e26ac3368c2b859a9f3a12d7425a7d3b 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html

@@ -39,7 +39,7 @@ function test()

for (var event of events) {

if (event.name === WebInspector.TimelineModel.RecordType.Paint) {

paintEvents.push(event);

- if (!event.picture)

+ if (!WebInspector.TimelineData.forEvent(event).picture)

InspectorTest.addResult("Event without picture at " + paintEvents.length);

}