DevTools: reformat front-end code to match chromium style.

DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
NOTRY=true

Committed: https://crrev.com/68c443e2d37446d172dd9960d6a7b512fc4b3050
Cr-Commit-Position: refs/heads/master@{#429102}

[pfeldman, 2016-10-31 23:33:08]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-11-01 00:04:07]

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
(left):

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js:228:
case "size": comparator = numberCompare.bind(null,
WebInspector.Cookie.prototype.size); break;
numberCompare!

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
(right):

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js:231:
compareTo.bind(null, this._dataGrid.sortColumnId());
comparator =

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js
(right):

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js:2002:
_calculateStatistics: function()
Remove underscore

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js
(right):

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js:239: *
@param {!Array<!Array>} gridNodeGroups
Array<!ProfileDataGridNode>

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
(right):

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:514:
return /** @type {string}*/
(WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath(/** @type
{string}*/(this.keyPath)));
Remove second.

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js:539:
return /** @type
{string}*/(WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath(/** @type
{string}*/(this.keyPath)));
ditto

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/StackView.js (right):

https://codereview.chromium.org/2466123002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/StackView.js:72:
super.detachChildWidgets(this);
remove this.

[dgozman, 2016-11-01 19:25:31]

lgtm!

[pfeldman, 2016-11-01 19:26:12]

Description was changed from

==========
DevTools: prepare front-end code to be reformatted.

BUG=659389
==========

to

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
==========

[pfeldman, 2016-11-01 19:28:27]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 19:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 19:44:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 19:44:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-11-01 19:52:05]

Description was changed from

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
==========

to

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
==========

[pfeldman, 2016-11-01 19:54:00]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-11-01 19:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-11-01 20:24:02]

Description was changed from

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
==========

to

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-11-01 20:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 20:36:15]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:90
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js'
with conflicts.
  U
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Patch:      
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
Index:
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git
a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index
5963d876d3c3703f279eda259510a69cc6be62c3..98e82e1c61fbd59996c24a791a554865c4713603
100644
---
a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++
b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -1,26 +1,28 @@
 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-
 /**
- * @constructor
- * @param {!WebInspector.NetworkLogView} networkLogView
- * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator
- * @param {!WebInspector.NetworkTransferDurationCalculator} durationCalculator
- * @param {!WebInspector.Setting} networkLogLargeRowsSetting
+ * @unrestricted
  */
-WebInspector.NetworkLogViewColumns = function(networkLogView, timeCalculator,
durationCalculator, networkLogLargeRowsSetting)
-{
-    if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) {
-        var timelineColumn =
WebInspector.NetworkLogViewColumns._defaultColumns.find(columnConfig =>
columnConfig.id === "timeline");
-        timelineColumn.visible = false;
-        timelineColumn.hideable = false;
+WebInspector.NetworkLogViewColumns = class {
+  /**
+   * @param {!WebInspector.NetworkLogView} networkLogView
+   * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator
+   * @param {!WebInspector.NetworkTransferDurationCalculator}
durationCalculator
+   * @param {!WebInspector.Setting} networkLogLargeRowsSetting
+   */
+  constructor(networkLogView, timeCalculator, durationCalculator,
networkLogLargeRowsSetting) {
+    if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) {
+      var timelineColumn =
+          WebInspector.NetworkLogViewColumns._defaultColumns.find(columnConfig
=> columnConfig.id === 'timeline');
+      timelineColumn.visible = false;
+      timelineColumn.hideable = false;
     }
 
     this._networkLogView = networkLogView;
 
     /** @type {!WebInspector.Setting} */
-    this._persistantSettings =
WebInspector.settings.createSetting("networkLogColumns", {});
+    this._persistantSettings =
WebInspector.settings.createSetting('networkLogColumns', {});
 
     /** @type {!Array<!Element>} */
     this._dropDownColumnSelectors = [];
@@ -55,11 +57,748 @@ WebInspector.NetworkLogViewColumns =
function(networkLogView, timeCalculator, du
    
this._calculatorsMap.set(WebInspector.NetworkLogViewColumns._calculatorTypes.Duration,
durationCalculator);
 
     this._setupDataGrid();
-    if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
-        this._setupTimeline();
+    if (Runtime.experiments.isEnabled('canvasNetworkTimeline'))
+      this._setupTimeline();
+  }
+
+  /**
+   * @param {!WebInspector.NetworkLogViewColumns.Descriptor} columnConfig
+   * @return {!WebInspector.DataGrid.ColumnDescriptor}
+   */
+  static _convertToDataGridDescriptor(columnConfig) {
+    return /** @type {!WebInspector.DataGrid.ColumnDescriptor} */ ({
+      id: columnConfig.id,
+      title: columnConfig.title,
+      sortable: columnConfig.sortable,
+      align: columnConfig.align,
+      nonSelectable: columnConfig.nonSelectable,
+      weight: columnConfig.weight
+    });
+  }
+
+  wasShown() {
+    this._updateRowsSize();
+  }
+
+  willHide() {
+    this._popoverHelper.hidePopover();
+  }
+
+  reset() {
+    if (this._popoverHelper)
+      this._popoverHelper.hidePopover();
+    this._timelineGrid.removeEventDividers();
+    this._shownEventDividers.clear();
+    this.updateDividersIfNeeded();
+  }
+
+  _setupDataGrid() {
+    var defaultColumns = WebInspector.NetworkLogViewColumns._defaultColumns;
+    var defaultColumnConfig =
WebInspector.NetworkLogViewColumns._defaultColumnConfig;
+
+    this._columns = /** @type
{!Array<!WebInspector.NetworkLogViewColumns.Descriptor>} */ ([]);
+    for (var currentConfigColumn of defaultColumns) {
+      var columnConfig = /** @type
{!WebInspector.NetworkLogViewColumns.Descriptor} */ (
+          Object.assign(/** @type {!Object} */ ({}), defaultColumnConfig,
currentConfigColumn));
+      columnConfig.id = columnConfig.id;
+      if (columnConfig.subtitle)
+        columnConfig.titleDOMFragment =
this._makeHeaderFragment(columnConfig.title, columnConfig.subtitle);
+      this._columns.push(columnConfig);
+    }
+    this._loadColumns();
+
+    this._popoverHelper = new
WebInspector.PopoverHelper(this._networkLogView.element);
+    this._popoverHelper.initializeCallbacks(
+        this._getPopoverAnchor.bind(this), this._showPopover.bind(this),
this._onHidePopover.bind(this));
+
+    this._dataGrid = new WebInspector.SortableDataGrid(
+       
this._columns.map(WebInspector.NetworkLogViewColumns._convertToDataGridDescriptor));
+    this._dataGrid.element.addEventListener('mousedown', event => {
+      if ((!this._dataGrid.selectedNode && event.button) ||
event.target.enclosingNodeOrSelfWithNodeName('a'))
+        event.consume();
+    }, true);
+
+    this._dataGridScroller = this._dataGrid.scrollContainer;
+
+    this._updateColumns();
+   
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged,
this._sortHandler, this);
+   
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.ColumnsResized,
this.updateDividersIfNeeded, this);
+   
this._dataGrid.setHeaderContextMenuCallback(this._innerHeaderContextMenu.bind(this));
+
+    this._timelineGrid = new WebInspector.TimelineGrid();
+    this._timelineGrid.element.classList.add('network-timeline-grid');
+    if (!Runtime.experiments.isEnabled('canvasNetworkTimeline'))
+      this._dataGrid.element.appendChild(this._timelineGrid.element);
+
+    this._setupDropdownColumns();
+
+    this._activeTimelineSortId =
WebInspector.NetworkLogViewColumns.TimelineSortIds.StartTime;
+    this._dataGrid.markColumnAsSortedBy(
+        WebInspector.NetworkLogViewColumns._initialSortColumn,
WebInspector.DataGrid.Order.Ascending);
+
+    if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) {
+      this._splitWidget = new WebInspector.SplitWidget(true, true,
'networkPanelSplitViewTimeline', 200);
+      this._splitWidget.setMainWidget(this._dataGrid.asWidget());
+    }
+  }
+
+  _setupTimeline() {
+    this._timelineColumn =
+        new
WebInspector.NetworkTimelineColumn(this._networkLogView.rowHeight(),
this._networkLogView.calculator());
+
+    this._timelineColumn.element.addEventListener('contextmenu',
handleContextMenu.bind(this));
+    this._timelineColumn.element.addEventListener('mousewheel',
this._onMouseWheel.bind(this, false), {passive: true});
+    this._dataGridScroller.addEventListener('mousewheel',
this._onMouseWheel.bind(this, true), true);
+
+    this._timelineColumn.element.addEventListener(
+        'mousemove',
+        event => this._networkLogView.setHoveredRequest(
+            this._timelineColumn.getRequestFromPoint(event.offsetX,
event.offsetY + event.target.offsetTop),
+            event.shiftKey),
+        true);
+    this._timelineColumn.element.addEventListener(
+        'mouseleave',
this._networkLogView.setHoveredRequest.bind(this._networkLogView, null, false),
true);
+
+    this._timelineScroller =
this._timelineColumn.contentElement.createChild('div',
'network-timeline-v-scroll');
+    this._timelineScroller.addEventListener('scroll',
this._syncScrollers.bind(this), {passive: true});
+    this._timelineScrollerContent = this._timelineScroller.createChild('div',
'network-timeline-v-scroll-content');
+
+   
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.PaddingChanged, ()
=> {
+      this._timelineScrollerWidthIsStale = true;
+      this._syncScrollers();
+    });
+    this._dataGrid.addEventListener(
+        WebInspector.ViewportDataGrid.Events.ViewportCalculated,
this._redrawTimelineColumn.bind(this));
+
+    this._createTimelineHeader();
+    this._timelineColumn.contentElement.classList.add('network-timeline-view');
+
+    this._splitWidget.setSidebarWidget(this._timelineColumn);
+
+    this.switchViewMode(false);
+
+    /**
+     * @param {!Event} event
+     * @this {WebInspector.NetworkLogViewColumns}
+     */
+    function handleContextMenu(event) {
+      var request = this._timelineColumn.getRequestFromPoint(event.offsetX,
event.offsetY);
+      if (!request)
+        return;
+      var contextMenu = new WebInspector.ContextMenu(event);
+      this._networkLogView.handleContextMenuForRequest(contextMenu, request);
+      contextMenu.show();
+    }
+  }
+
+  /**
+   * @param {boolean} shouldConsume
+   * @param {!Event} event
+   */
+  _onMouseWheel(shouldConsume, event) {
+    if (shouldConsume)
+      event.consume(true);
+    this._activeScroller.scrollTop -= event.wheelDeltaY;
+    this._syncScrollers();
+    this._networkLogView.setHoveredRequest(
+        this._timelineColumn.getRequestFromPoint(event.offsetX, event.offsetY),
event.shiftKey);
+  }
+
+  _syncScrollers() {
+    if (!this._timelineColumn.isShowing())
+      return;
+    this._timelineScrollerContent.style.height =
this._dataGridScroller.scrollHeight + 'px';
+    this._updateScrollerWidthIfNeeded();
+    this._dataGridScroller.scrollTop = this._timelineScrolle…
(message too large)

[pfeldman, 2016-11-01 20:44:39]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-11-01 20:45:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 20:55:39]

Description was changed from

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
NOTRY=true
==========

to

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-11-01 20:55:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 20:57:58]

Description was changed from

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
NOTRY=true
==========

to

==========
DevTools: reformat front-end code to match chromium style.

BUG=659389
NOPRESUBMIT=true
NOTRY=true

Committed: https://crrev.com/68c443e2d37446d172dd9960d6a7b512fc4b3050
Cr-Commit-Position: refs/heads/master@{#429102}
==========

[commit-bot: I haz the power, 2016-11-01 20:58:03]

Patchset 2 (id:??) landed as
https://crrev.com/68c443e2d37446d172dd9960d6a7b512fc4b3050
Cr-Commit-Position: refs/heads/master@{#429102}