Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
index 6da564efced6ed99d2c74a03160b72c2536a5777..1b89a85be6c77652b0646fb7ffce79d501d605ac 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
@@ -23,130 +23,129 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
/**
- * @constructor
- * @extends {WebInspector.VBox}
* @implements {WebInspector.ContextFlavorListener}
+ * @unrestricted
*/
-WebInspector.ScopeChainSidebarPane = function()
-{
- WebInspector.VBox.call(this);
+WebInspector.ScopeChainSidebarPane = class extends WebInspector.VBox {
+ constructor() {
+ super();
this._expandController = new WebInspector.ObjectPropertiesSectionExpandController();
this._linkifier = new WebInspector.Linkifier();
this._update();
-};
-
-WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path");
+ }
-WebInspector.ScopeChainSidebarPane.prototype = {
- /**
- * @override
- * @param {?Object} object
- */
- flavorChanged: function(object)
- {
- this._update();
- },
-
- _update: function()
- {
- var callFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.CallFrame);
- var details = WebInspector.context.flavor(WebInspector.DebuggerPausedDetails);
- this._linkifier.reset();
- WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame)
- .then(this._innerUpdate.bind(this, details, callFrame));
- },
+ /**
+ * @override
+ * @param {?Object} object
+ */
+ flavorChanged(object) {
+ this._update();
+ }
- /**
- * @param {?WebInspector.DebuggerPausedDetails} details
- * @param {?WebInspector.DebuggerModel.CallFrame} callFrame
- * @param {?WebInspector.RemoteObject} thisObject
- */
- _innerUpdate: function(details, callFrame, thisObject)
- {
- this.element.removeChildren();
+ _update() {
+ var callFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.CallFrame);
+ var details = WebInspector.context.flavor(WebInspector.DebuggerPausedDetails);
+ this._linkifier.reset();
+ WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame).then(
+ this._innerUpdate.bind(this, details, callFrame));
+ }
- if (!details || !callFrame) {
- var infoElement = createElement("div");
- infoElement.className = "gray-info-message";
- infoElement.textContent = WebInspector.UIString("Not Paused");
- this.element.appendChild(infoElement);
- return;
- }
+ /**
+ * @param {?WebInspector.DebuggerPausedDetails} details
+ * @param {?WebInspector.DebuggerModel.CallFrame} callFrame
+ * @param {?WebInspector.RemoteObject} thisObject
+ */
+ _innerUpdate(details, callFrame, thisObject) {
+ this.element.removeChildren();
- var foundLocalScope = false;
- var scopeChain = callFrame.scopeChain();
- for (var i = 0; i < scopeChain.length; ++i) {
- var scope = scopeChain[i];
- var title = null;
- var emptyPlaceholder = null;
- var extraProperties = [];
+ if (!details || !callFrame) {
+ var infoElement = createElement('div');
+ infoElement.className = 'gray-info-message';
+ infoElement.textContent = WebInspector.UIString('Not Paused');
+ this.element.appendChild(infoElement);
+ return;
+ }
- switch (scope.type()) {
- case DebuggerAgent.ScopeType.Local:
- foundLocalScope = true;
- title = WebInspector.UIString("Local");
- emptyPlaceholder = WebInspector.UIString("No Variables");
- if (thisObject)
- extraProperties.push(new WebInspector.RemoteObjectProperty("this", thisObject));
- if (i === 0) {
- var exception = details.exception();
- if (exception)
- extraProperties.push(new WebInspector.RemoteObjectProperty(WebInspector.UIString.capitalize("Exception"), exception, undefined, undefined, undefined, undefined, undefined, true));
- var returnValue = callFrame.returnValue();
- if (returnValue)
- extraProperties.push(new WebInspector.RemoteObjectProperty(WebInspector.UIString.capitalize("Return ^value"), returnValue, undefined, undefined, undefined, undefined, undefined, true));
- }
- break;
- case DebuggerAgent.ScopeType.Closure:
- var scopeName = scope.name();
- if (scopeName)
- title = WebInspector.UIString("Closure (%s)", WebInspector.beautifyFunctionName(scopeName));
- else
- title = WebInspector.UIString("Closure");
- emptyPlaceholder = WebInspector.UIString("No Variables");
- break;
- case DebuggerAgent.ScopeType.Catch:
- title = WebInspector.UIString("Catch");
- break;
- case DebuggerAgent.ScopeType.Block:
- title = WebInspector.UIString("Block");
- break;
- case DebuggerAgent.ScopeType.Script:
- title = WebInspector.UIString("Script");
- break;
- case DebuggerAgent.ScopeType.With:
- title = WebInspector.UIString("With Block");
- break;
- case DebuggerAgent.ScopeType.Global:
- title = WebInspector.UIString("Global");
- break;
- }
+ var foundLocalScope = false;
+ var scopeChain = callFrame.scopeChain();
+ for (var i = 0; i < scopeChain.length; ++i) {
+ var scope = scopeChain[i];
+ var title = null;
+ var emptyPlaceholder = null;
+ var extraProperties = [];
- var subtitle = scope.description();
- if (!title || title === subtitle)
- subtitle = undefined;
+ switch (scope.type()) {
+ case DebuggerAgent.ScopeType.Local:
+ foundLocalScope = true;
+ title = WebInspector.UIString('Local');
+ emptyPlaceholder = WebInspector.UIString('No Variables');
+ if (thisObject)
+ extraProperties.push(new WebInspector.RemoteObjectProperty('this', thisObject));
+ if (i === 0) {
+ var exception = details.exception();
+ if (exception)
+ extraProperties.push(new WebInspector.RemoteObjectProperty(
+ WebInspector.UIString.capitalize('Exception'), exception, undefined, undefined, undefined, undefined,
+ undefined, true));
+ var returnValue = callFrame.returnValue();
+ if (returnValue)
+ extraProperties.push(new WebInspector.RemoteObjectProperty(
+ WebInspector.UIString.capitalize('Return ^value'), returnValue, undefined, undefined, undefined,
+ undefined, undefined, true));
+ }
+ break;
+ case DebuggerAgent.ScopeType.Closure:
+ var scopeName = scope.name();
+ if (scopeName)
+ title = WebInspector.UIString('Closure (%s)', WebInspector.beautifyFunctionName(scopeName));
+ else
+ title = WebInspector.UIString('Closure');
+ emptyPlaceholder = WebInspector.UIString('No Variables');
+ break;
+ case DebuggerAgent.ScopeType.Catch:
+ title = WebInspector.UIString('Catch');
+ break;
+ case DebuggerAgent.ScopeType.Block:
+ title = WebInspector.UIString('Block');
+ break;
+ case DebuggerAgent.ScopeType.Script:
+ title = WebInspector.UIString('Script');
+ break;
+ case DebuggerAgent.ScopeType.With:
+ title = WebInspector.UIString('With Block');
+ break;
+ case DebuggerAgent.ScopeType.Global:
+ title = WebInspector.UIString('Global');
+ break;
+ }
- var titleElement = createElementWithClass("div", "scope-chain-sidebar-pane-section-header");
- titleElement.createChild("div", "scope-chain-sidebar-pane-section-subtitle").textContent = subtitle;
- titleElement.createChild("div", "scope-chain-sidebar-pane-section-title").textContent = title;
+ var subtitle = scope.description();
+ if (!title || title === subtitle)
+ subtitle = undefined;
- var section = new WebInspector.ObjectPropertiesSection(WebInspector.SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, this._linkifier, emptyPlaceholder, true, extraProperties);
- this._expandController.watchSection(title + (subtitle ? ":" + subtitle : ""), section);
+ var titleElement = createElementWithClass('div', 'scope-chain-sidebar-pane-section-header');
+ titleElement.createChild('div', 'scope-chain-sidebar-pane-section-subtitle').textContent = subtitle;
+ titleElement.createChild('div', 'scope-chain-sidebar-pane-section-title').textContent = title;
- if (scope.type() === DebuggerAgent.ScopeType.Global)
- section.objectTreeElement().collapse();
- else if (!foundLocalScope || scope.type() === DebuggerAgent.ScopeType.Local)
- section.objectTreeElement().expand();
+ var section = new WebInspector.ObjectPropertiesSection(
+ WebInspector.SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, this._linkifier,
+ emptyPlaceholder, true, extraProperties);
+ this._expandController.watchSection(title + (subtitle ? ':' + subtitle : ''), section);
- section.element.classList.add("scope-chain-sidebar-pane-section");
- this.element.appendChild(section.element);
- }
- this._sidebarPaneUpdatedForTest();
- },
+ if (scope.type() === DebuggerAgent.ScopeType.Global)
+ section.objectTreeElement().collapse();
+ else if (!foundLocalScope || scope.type() === DebuggerAgent.ScopeType.Local)
+ section.objectTreeElement().expand();
- _sidebarPaneUpdatedForTest: function() { },
+ section.element.classList.add('scope-chain-sidebar-pane-section');
+ this.element.appendChild(section.element);
+ }
+ this._sidebarPaneUpdatedForTest();
+ }
- __proto__: WebInspector.VBox.prototype
+ _sidebarPaneUpdatedForTest() {
+ }
};
+
+WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol('path');

Powered by Google App Engine
This is Rietveld 408576698