Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js
index cb83658f4da60867e27c032a68273d8a462f4dad..f9a41f54c5c32652799b4259e8a42df7d0d905cd 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js
@@ -27,83 +27,79 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
/**
- * @constructor
- * @extends {WebInspector.SimpleView}
- * @param {!WebInspector.AuditCategoryResult} categoryResult
+ * @unrestricted
*/
-WebInspector.AuditCategoryResultPane = function(categoryResult)
-{
- WebInspector.SimpleView.call(this, categoryResult.title);
+WebInspector.AuditCategoryResultPane = class extends WebInspector.SimpleView {
+ /**
+ * @param {!WebInspector.AuditCategoryResult} categoryResult
+ */
+ constructor(categoryResult) {
+ super(categoryResult.title);
this._treeOutline = new TreeOutlineInShadow();
- this._treeOutline.registerRequiredCSS("audits/auditResultTree.css");
- this._treeOutline.element.classList.add("audit-result-tree");
+ this._treeOutline.registerRequiredCSS('audits/auditResultTree.css');
+ this._treeOutline.element.classList.add('audit-result-tree');
this.element.appendChild(this._treeOutline.element);
this._treeOutline.expandTreeElementsWhenArrowing = true;
- function ruleSorter(a, b)
- {
- var result = WebInspector.AuditRule.SeverityOrder[a.severity || 0] - WebInspector.AuditRule.SeverityOrder[b.severity || 0];
- if (!result)
- result = (a.value || "").localeCompare(b.value || "");
- return result;
+ function ruleSorter(a, b) {
+ var result =
+ WebInspector.AuditRule.SeverityOrder[a.severity || 0] - WebInspector.AuditRule.SeverityOrder[b.severity || 0];
+ if (!result)
+ result = (a.value || '').localeCompare(b.value || '');
+ return result;
}
categoryResult.ruleResults.sort(ruleSorter);
for (var i = 0; i < categoryResult.ruleResults.length; ++i) {
- var ruleResult = categoryResult.ruleResults[i];
- var treeElement = this._appendResult(this._treeOutline.rootElement(), ruleResult, ruleResult.severity);
- treeElement.listItemElement.classList.add("audit-result");
+ var ruleResult = categoryResult.ruleResults[i];
+ var treeElement = this._appendResult(this._treeOutline.rootElement(), ruleResult, ruleResult.severity);
+ treeElement.listItemElement.classList.add('audit-result');
}
this.revealView();
-};
+ }
-WebInspector.AuditCategoryResultPane.prototype = {
- /**
- * @param {!TreeElement} parentTreeNode
- * @param {!WebInspector.AuditRuleResult} result
- * @param {?WebInspector.AuditRule.Severity=} severity
- */
- _appendResult: function(parentTreeNode, result, severity)
- {
- var title = "";
+ /**
+ * @param {!TreeElement} parentTreeNode
+ * @param {!WebInspector.AuditRuleResult} result
+ * @param {?WebInspector.AuditRule.Severity=} severity
+ */
+ _appendResult(parentTreeNode, result, severity) {
+ var title = '';
- if (typeof result.value === "string") {
- title = result.value;
- if (result.violationCount)
- title = String.sprintf("%s (%d)", title, result.violationCount);
- }
-
- var titleFragment = createDocumentFragment();
- if (severity) {
- var severityElement = createElement("div");
- severityElement.classList.add("severity", severity);
- titleFragment.appendChild(severityElement);
- }
- titleFragment.createTextChild(title);
+ if (typeof result.value === 'string') {
+ title = result.value;
+ if (result.violationCount)
+ title = String.sprintf('%s (%d)', title, result.violationCount);
+ }
- var treeElement = new TreeElement(titleFragment, !!result.children);
- treeElement.selectable = false;
- parentTreeNode.appendChild(treeElement);
+ var titleFragment = createDocumentFragment();
+ if (severity) {
+ var severityElement = createElement('div');
+ severityElement.classList.add('severity', severity);
+ titleFragment.appendChild(severityElement);
+ }
+ titleFragment.createTextChild(title);
- if (result.className)
- treeElement.listItemElement.classList.add(result.className);
- if (typeof result.value !== "string")
- treeElement.listItemElement.appendChild(WebInspector.auditFormatters.apply(result.value));
+ var treeElement = new TreeElement(titleFragment, !!result.children);
+ treeElement.selectable = false;
+ parentTreeNode.appendChild(treeElement);
- if (result.children) {
- for (var i = 0; i < result.children.length; ++i)
- this._appendResult(treeElement, result.children[i]);
- }
- if (result.expanded) {
- treeElement.listItemElement.classList.remove("parent");
- treeElement.listItemElement.classList.add("parent-expanded");
- treeElement.expand();
- }
- return treeElement;
- },
+ if (result.className)
+ treeElement.listItemElement.classList.add(result.className);
+ if (typeof result.value !== 'string')
+ treeElement.listItemElement.appendChild(WebInspector.auditFormatters.apply(result.value));
- __proto__: WebInspector.SimpleView.prototype
+ if (result.children) {
+ for (var i = 0; i < result.children.length; ++i)
+ this._appendResult(treeElement, result.children[i]);
+ }
+ if (result.expanded) {
+ treeElement.listItemElement.classList.remove('parent');
+ treeElement.listItemElement.classList.add('parent-expanded');
+ treeElement.expand();
+ }
+ return treeElement;
+ }
};

Powered by Google App Engine
This is Rietveld 408576698