Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ReportView.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/ReportView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js b/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js
index 167499b6a2c6801490db112fd097dc6644701b3a..033e033ad977e74997938cfbc2695d9d69352386 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js
@@ -1,192 +1,173 @@
// Copyright (c) 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
/**
- * @constructor
- * @extends {WebInspector.VBox}
- * @param {string} title
+ * @unrestricted
*/
-WebInspector.ReportView = function(title)
-{
- WebInspector.VBox.call(this, true);
- this.registerRequiredCSS("ui/reportView.css");
-
- var contentBox = this.contentElement.createChild("div", "report-content-box");
- this._headerElement = contentBox.createChild("div", "report-header vbox");
- this._headerElement.createChild("div", "report-title").textContent = title;
-
- this._sectionList = contentBox.createChild("div", "vbox");
-};
-
-WebInspector.ReportView.prototype = {
- /**
- * @param {string} subtitle
- */
- setSubtitle: function(subtitle)
- {
- if (this._subtitleElement && this._subtitleElement.textContent === subtitle)
- return;
- if (!this._subtitleElement)
- this._subtitleElement = this._headerElement.createChild("div", "report-subtitle");
- this._subtitleElement.textContent = subtitle;
- },
-
- /**
- * @param {?string} url
- */
- setURL: function(url)
- {
- if (this._url === url)
- return;
- if (!this._urlElement)
- this._urlElement = this._headerElement.createChild("div", "report-url link");
-
- this._url = url;
- this._urlElement.removeChildren();
- if (url)
- this._urlElement.appendChild(WebInspector.linkifyURLAsNode(url));
- },
-
- /**
- * @return {!WebInspector.Toolbar}
- */
- createToolbar: function()
- {
- var toolbar = new WebInspector.Toolbar("");
- this._headerElement.appendChild(toolbar.element);
- return toolbar;
- },
-
- /**
- * @param {string} title
- * @param {string=} className
- * @return {!WebInspector.ReportView.Section}
- */
- appendSection: function(title, className)
- {
- var section = new WebInspector.ReportView.Section(title, className);
- section.show(this._sectionList);
- return section;
- },
-
- removeAllSection: function()
- {
- this._sectionList.removeChildren();
- },
-
- __proto__: WebInspector.VBox.prototype
+WebInspector.ReportView = class extends WebInspector.VBox {
+ /**
+ * @param {string} title
+ */
+ constructor(title) {
+ super(true);
+ this.registerRequiredCSS('ui/reportView.css');
+
+ var contentBox = this.contentElement.createChild('div', 'report-content-box');
+ this._headerElement = contentBox.createChild('div', 'report-header vbox');
+ this._headerElement.createChild('div', 'report-title').textContent = title;
+
+ this._sectionList = contentBox.createChild('div', 'vbox');
+ }
+
+ /**
+ * @param {string} subtitle
+ */
+ setSubtitle(subtitle) {
+ if (this._subtitleElement && this._subtitleElement.textContent === subtitle)
+ return;
+ if (!this._subtitleElement)
+ this._subtitleElement = this._headerElement.createChild('div', 'report-subtitle');
+ this._subtitleElement.textContent = subtitle;
+ }
+
+ /**
+ * @param {?string} url
+ */
+ setURL(url) {
+ if (this._url === url)
+ return;
+ if (!this._urlElement)
+ this._urlElement = this._headerElement.createChild('div', 'report-url link');
+
+ this._url = url;
+ this._urlElement.removeChildren();
+ if (url)
+ this._urlElement.appendChild(WebInspector.linkifyURLAsNode(url));
+ }
+
+ /**
+ * @return {!WebInspector.Toolbar}
+ */
+ createToolbar() {
+ var toolbar = new WebInspector.Toolbar('');
+ this._headerElement.appendChild(toolbar.element);
+ return toolbar;
+ }
+
+ /**
+ * @param {string} title
+ * @param {string=} className
+ * @return {!WebInspector.ReportView.Section}
+ */
+ appendSection(title, className) {
+ var section = new WebInspector.ReportView.Section(title, className);
+ section.show(this._sectionList);
+ return section;
+ }
+
+ removeAllSection() {
+ this._sectionList.removeChildren();
+ }
};
/**
- * @constructor
- * @extends {WebInspector.VBox}
- * @param {string} title
- * @param {string=} className
+ * @unrestricted
*/
-WebInspector.ReportView.Section = function(title, className)
-{
- WebInspector.VBox.call(this);
- this.element.classList.add("report-section");
+WebInspector.ReportView.Section = class extends WebInspector.VBox {
+ /**
+ * @param {string} title
+ * @param {string=} className
+ */
+ constructor(title, className) {
+ super();
+ this.element.classList.add('report-section');
if (className)
- this.element.classList.add(className);
- this._headerElement = this.element.createChild("div", "report-section-header");
- this._titleElement = this._headerElement.createChild("div", "report-section-title");
+ this.element.classList.add(className);
+ this._headerElement = this.element.createChild('div', 'report-section-header');
+ this._titleElement = this._headerElement.createChild('div', 'report-section-title');
this._titleElement.textContent = title;
- this._fieldList = this.element.createChild("div", "vbox");
+ this._fieldList = this.element.createChild('div', 'vbox');
/** @type {!Map.<string, !Element>} */
this._fieldMap = new Map();
-};
-
-WebInspector.ReportView.Section.prototype = {
- /**
- * @param {string} title
- */
- setTitle: function(title)
- {
- if (this._titleElement.textContent !== title)
- this._titleElement.textContent = title;
- },
-
- /**
- * @return {!WebInspector.Toolbar}
- */
- createToolbar: function()
- {
- var toolbar = new WebInspector.Toolbar("");
- this._headerElement.appendChild(toolbar.element);
- return toolbar;
- },
-
- /**
- * @param {string} title
- * @param {string=} textValue
- * @return {!Element}
- */
- appendField: function(title, textValue)
- {
- var row = this._fieldMap.get(title);
- if (!row) {
- row = this._fieldList.createChild("div", "report-field");
- row.createChild("div", "report-field-name").textContent = title;
- this._fieldMap.set(title, row);
- row.createChild("div", "report-field-value");
- }
- if (textValue)
- row.lastElementChild.textContent = textValue;
- return /** @type {!Element} */ (row.lastElementChild);
- },
-
- remove: function()
- {
- this.element.remove();
- },
-
- /**
- * @param {string} title
- */
- removeField: function(title)
- {
- var row = this._fieldMap.get(title);
- if (row)
- row.remove();
- this._fieldMap.delete(title);
- },
-
- /**
- * @param {string} title
- * @param {boolean} visible
- */
- setFieldVisible: function(title, visible)
- {
- var row = this._fieldMap.get(title);
- if (row)
- row.classList.toggle("hidden", !visible);
- },
-
- /**
- * @param {string} title
- * @return {?Element}
- */
- fieldValue: function(title)
- {
- var row = this._fieldMap.get(title);
- return row ? row.lastElementChild : null;
- },
-
- /**
- * @return {!Element}
- */
- appendRow: function()
- {
- return this._fieldList.createChild("div", "report-row");
- },
-
- clearContent: function()
- {
- this._fieldList.removeChildren();
- this._fieldMap.clear();
- },
-
- __proto__: WebInspector.VBox.prototype
+ }
+
+ /**
+ * @param {string} title
+ */
+ setTitle(title) {
+ if (this._titleElement.textContent !== title)
+ this._titleElement.textContent = title;
+ }
+
+ /**
+ * @return {!WebInspector.Toolbar}
+ */
+ createToolbar() {
+ var toolbar = new WebInspector.Toolbar('');
+ this._headerElement.appendChild(toolbar.element);
+ return toolbar;
+ }
+
+ /**
+ * @param {string} title
+ * @param {string=} textValue
+ * @return {!Element}
+ */
+ appendField(title, textValue) {
+ var row = this._fieldMap.get(title);
+ if (!row) {
+ row = this._fieldList.createChild('div', 'report-field');
+ row.createChild('div', 'report-field-name').textContent = title;
+ this._fieldMap.set(title, row);
+ row.createChild('div', 'report-field-value');
+ }
+ if (textValue)
+ row.lastElementChild.textContent = textValue;
+ return /** @type {!Element} */ (row.lastElementChild);
+ }
+
+ remove() {
+ this.element.remove();
+ }
+
+ /**
+ * @param {string} title
+ */
+ removeField(title) {
+ var row = this._fieldMap.get(title);
+ if (row)
+ row.remove();
+ this._fieldMap.delete(title);
+ }
+
+ /**
+ * @param {string} title
+ * @param {boolean} visible
+ */
+ setFieldVisible(title, visible) {
+ var row = this._fieldMap.get(title);
+ if (row)
+ row.classList.toggle('hidden', !visible);
+ }
+
+ /**
+ * @param {string} title
+ * @return {?Element}
+ */
+ fieldValue(title) {
+ var row = this._fieldMap.get(title);
+ return row ? row.lastElementChild : null;
+ }
+
+ /**
+ * @return {!Element}
+ */
+ appendRow() {
+ return this._fieldList.createChild('div', 'report-row');
+ }
+
+ clearContent() {
+ this._fieldList.removeChildren();
+ this._fieldMap.clear();
+ }
};

Powered by Google App Engine
This is Rietveld 408576698