Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js b/third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js
index 25a92554af38edefc70f1a99f70dc69b95d3d4d3..127ece99b020ff34425115819c1cf3b62b038e53 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/PaintProfiler.js
@@ -27,125 +27,120 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
/**
* @typedef {!{x: number, y: number, picture: string}}
*/
WebInspector.PictureFragment;
/**
- * @constructor
- * @param {!WebInspector.Target} target
- * @param {string} snapshotId
+ * @unrestricted
*/
-WebInspector.PaintProfilerSnapshot = function(target, snapshotId)
-{
+WebInspector.PaintProfilerSnapshot = class {
+ /**
+ * @param {!WebInspector.Target} target
+ * @param {string} snapshotId
+ */
+ constructor(target, snapshotId) {
this._target = target;
this._id = snapshotId;
this._refCount = 1;
-};
+ }
-/**
- * @param {!WebInspector.Target} target
- * @param {!Array.<!WebInspector.PictureFragment>} fragments
- * @return {!Promise<?WebInspector.PaintProfilerSnapshot>}
- */
-WebInspector.PaintProfilerSnapshot.loadFromFragments = function(target, fragments)
-{
- return target.layerTreeAgent().loadSnapshot(fragments, (error, snapshotId) => error ? null : new WebInspector.PaintProfilerSnapshot(target, snapshotId));
-};
+ /**
+ * @param {!WebInspector.Target} target
+ * @param {!Array.<!WebInspector.PictureFragment>} fragments
+ * @return {!Promise<?WebInspector.PaintProfilerSnapshot>}
+ */
+ static loadFromFragments(target, fragments) {
+ return target.layerTreeAgent().loadSnapshot(
+ fragments, (error, snapshotId) => error ? null : new WebInspector.PaintProfilerSnapshot(target, snapshotId));
+ }
-/**
- * @param {!WebInspector.Target} target
- * @param {string} encodedPicture
- * @return {!Promise<?WebInspector.PaintProfilerSnapshot>}
- */
-WebInspector.PaintProfilerSnapshot.load = function(target, encodedPicture)
-{
- var fragment = {
- x: 0,
- y: 0,
- picture: encodedPicture
- };
+ /**
+ * @param {!WebInspector.Target} target
+ * @param {string} encodedPicture
+ * @return {!Promise<?WebInspector.PaintProfilerSnapshot>}
+ */
+ static load(target, encodedPicture) {
+ var fragment = {x: 0, y: 0, picture: encodedPicture};
return WebInspector.PaintProfilerSnapshot.loadFromFragments(target, [fragment]);
-};
+ }
-WebInspector.PaintProfilerSnapshot.prototype = {
- release: function()
- {
- console.assert(this._refCount > 0, "release is already called on the object");
- if (!--this._refCount)
- this._target.layerTreeAgent().releaseSnapshot(this._id);
- },
+ release() {
+ console.assert(this._refCount > 0, 'release is already called on the object');
+ if (!--this._refCount)
+ this._target.layerTreeAgent().releaseSnapshot(this._id);
+ }
- addReference: function()
- {
- ++this._refCount;
- console.assert(this._refCount > 0, "Referencing a dead object");
- },
+ addReference() {
+ ++this._refCount;
+ console.assert(this._refCount > 0, 'Referencing a dead object');
+ }
- /**
- * @return {!WebInspector.Target}
- */
- target: function()
- {
- return this._target;
- },
+ /**
+ * @return {!WebInspector.Target}
+ */
+ target() {
+ return this._target;
+ }
- /**
- * @param {?number} firstStep
- * @param {?number} lastStep
- * @param {?number} scale
- * @return {!Promise<?string>}
- */
- replay: function(firstStep, lastStep, scale)
- {
- return this._target.layerTreeAgent().replaySnapshot(this._id, firstStep || undefined, lastStep || undefined, scale || 1.0, (error, str) => error ? null : str);
- },
+ /**
+ * @param {?number} firstStep
+ * @param {?number} lastStep
+ * @param {?number} scale
+ * @return {!Promise<?string>}
+ */
+ replay(firstStep, lastStep, scale) {
+ return this._target.layerTreeAgent().replaySnapshot(
+ this._id, firstStep || undefined, lastStep || undefined, scale || 1.0, (error, str) => error ? null : str);
+ }
- /**
- * @param {?DOMAgent.Rect} clipRect
- * @param {function(!Array.<!LayerTreeAgent.PaintProfile>=)} callback
- */
- profile: function(clipRect, callback)
- {
- var wrappedCallback = InspectorBackend.wrapClientCallback(callback, "LayerTreeAgent.profileSnapshot(): ");
- this._target.layerTreeAgent().profileSnapshot(this._id, 5, 1, clipRect || undefined, wrappedCallback);
- },
+ /**
+ * @param {?DOMAgent.Rect} clipRect
+ * @param {function(!Array.<!LayerTreeAgent.PaintProfile>=)} callback
+ */
+ profile(clipRect, callback) {
+ var wrappedCallback = InspectorBackend.wrapClientCallback(callback, 'LayerTreeAgent.profileSnapshot(): ');
+ this._target.layerTreeAgent().profileSnapshot(this._id, 5, 1, clipRect || undefined, wrappedCallback);
+ }
+
+ /**
+ * @return {!Promise<?Array<!WebInspector.PaintProfilerLogItem>>}
+ */
+ commandLog() {
+ return this._target.layerTreeAgent().snapshotCommandLog(this._id, processLog);
/**
- * @return {!Promise<?Array<!WebInspector.PaintProfilerLogItem>>}
+ * @param {?string} error
+ * @param {?Array<!Object>} log
*/
- commandLog: function()
- {
- return this._target.layerTreeAgent().snapshotCommandLog(this._id, processLog);
-
- /**
- * @param {?string} error
- * @param {?Array<!Object>} log
- */
- function processLog(error, log)
- {
- if (error)
- return null;
- return log.map((entry, index) => new WebInspector.PaintProfilerLogItem(/** @type {!WebInspector.RawPaintProfilerLogItem} */ (entry), index));
- }
+ function processLog(error, log) {
+ if (error)
+ return null;
+ return log.map(
+ (entry, index) => new WebInspector.PaintProfilerLogItem(
+ /** @type {!WebInspector.RawPaintProfilerLogItem} */ (entry), index));
}
+ }
};
+
/**
* @typedef {!{method: string, params: ?Object<string, *>}}
*/
WebInspector.RawPaintProfilerLogItem;
/**
- * @constructor
- * @param {!WebInspector.RawPaintProfilerLogItem} rawEntry
- * @param {number} commandIndex
+ * @unrestricted
*/
-WebInspector.PaintProfilerLogItem = function(rawEntry, commandIndex)
-{
+WebInspector.PaintProfilerLogItem = class {
+ /**
+ * @param {!WebInspector.RawPaintProfilerLogItem} rawEntry
+ * @param {number} commandIndex
+ */
+ constructor(rawEntry, commandIndex) {
this.method = rawEntry.method;
this.params = rawEntry.params;
this.commandIndex = commandIndex;
+ }
};

Powered by Google App Engine
This is Rietveld 408576698