Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Target.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Target.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
index b531b134d9b30e1a839702ea61d900eb52a0a51e..c9a37043144127de281928dc4ecc3925bf8d22a7 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js
@@ -3,274 +3,245 @@
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
-
/**
- * @constructor
- * @extends {Protocol.Target}
- * @param {!WebInspector.TargetManager} targetManager
- * @param {string} name
- * @param {number} capabilitiesMask
- * @param {!InspectorBackendClass.Connection.Factory} connectionFactory
- * @param {?WebInspector.Target} parentTarget
+ * @unrestricted
*/
-WebInspector.Target = function(targetManager, name, capabilitiesMask, connectionFactory, parentTarget)
-{
- Protocol.Target.call(this, connectionFactory);
+WebInspector.Target = class extends Protocol.Target {
+ /**
+ * @param {!WebInspector.TargetManager} targetManager
+ * @param {string} name
+ * @param {number} capabilitiesMask
+ * @param {!InspectorBackendClass.Connection.Factory} connectionFactory
+ * @param {?WebInspector.Target} parentTarget
+ */
+ constructor(targetManager, name, capabilitiesMask, connectionFactory, parentTarget) {
+ super(connectionFactory);
this._targetManager = targetManager;
this._name = name;
- this._inspectedURL = "";
+ this._inspectedURL = '';
this._capabilitiesMask = capabilitiesMask;
this._parentTarget = parentTarget;
this._id = WebInspector.Target._nextId++;
/** @type {!Map.<!Function, !WebInspector.SDKModel>} */
this._modelByConstructor = new Map();
+ }
+
+ /**
+ * @return {boolean}
+ */
+ isNodeJS() {
+ // TODO(lushnikov): this is an unreliable way to detect Node.js targets.
+ return this._capabilitiesMask === WebInspector.Target.Capability.JS || this._isNodeJSForTest;
+ }
+
+ setIsNodeJSForTest() {
+ this._isNodeJSForTest = true;
+ }
+
+ /**
+ * @return {number}
+ */
+ id() {
+ return this._id;
+ }
+
+ /**
+ * @return {string}
+ */
+ name() {
+ return this._name || this._inspectedURLName;
+ }
+
+ /**
+ * @return {!WebInspector.TargetManager}
+ */
+ targetManager() {
+ return this._targetManager;
+ }
+
+ /**
+ * @param {number} capabilitiesMask
+ * @return {boolean}
+ */
+ hasAllCapabilities(capabilitiesMask) {
+ return (this._capabilitiesMask & capabilitiesMask) === capabilitiesMask;
+ }
+
+ /**
+ * @param {string} label
+ * @return {string}
+ */
+ decorateLabel(label) {
+ return !this.hasBrowserCapability() ? '\u2699 ' + label : label;
+ }
+
+ /**
+ * @return {boolean}
+ */
+ hasBrowserCapability() {
+ return this.hasAllCapabilities(WebInspector.Target.Capability.Browser);
+ }
+
+ /**
+ * @return {boolean}
+ */
+ hasJSCapability() {
+ return this.hasAllCapabilities(WebInspector.Target.Capability.JS);
+ }
+
+ /**
+ * @return {boolean}
+ */
+ hasLogCapability() {
+ return this.hasAllCapabilities(WebInspector.Target.Capability.Log);
+ }
+
+ /**
+ * @return {boolean}
+ */
+ hasNetworkCapability() {
+ return this.hasAllCapabilities(WebInspector.Target.Capability.Network);
+ }
+
+ /**
+ * @return {boolean}
+ */
+ hasTargetCapability() {
+ return this.hasAllCapabilities(WebInspector.Target.Capability.Target);
+ }
+
+ /**
+ * @return {boolean}
+ */
+ hasDOMCapability() {
+ return this.hasAllCapabilities(WebInspector.Target.Capability.DOM);
+ }
+
+ /**
+ * @return {?WebInspector.Target}
+ */
+ parentTarget() {
+ return this._parentTarget;
+ }
+
+ /**
+ * @override
+ */
+ dispose() {
+ this._targetManager.removeTarget(this);
+ for (var model of this._modelByConstructor.valuesArray())
+ model.dispose();
+ }
+
+ /**
+ * @param {!Function} modelClass
+ * @return {?WebInspector.SDKModel}
+ */
+ model(modelClass) {
+ return this._modelByConstructor.get(modelClass) || null;
+ }
+
+ /**
+ * @return {!Array<!WebInspector.SDKModel>}
+ */
+ models() {
+ return this._modelByConstructor.valuesArray();
+ }
+
+ /**
+ * @return {string}
+ */
+ inspectedURL() {
+ return this._inspectedURL;
+ }
+
+ /**
+ * @param {string} inspectedURL
+ */
+ setInspectedURL(inspectedURL) {
+ this._inspectedURL = inspectedURL;
+ var parsedURL = inspectedURL.asParsedURL();
+ this._inspectedURLName = parsedURL ? parsedURL.lastPathComponentWithFragment() : '#' + this._id;
+ if (!this.parentTarget())
+ InspectorFrontendHost.inspectedURLChanged(inspectedURL || '');
+ this._targetManager.dispatchEventToListeners(WebInspector.TargetManager.Events.InspectedURLChanged, this);
+ if (!this._name)
+ this._targetManager.dispatchEventToListeners(WebInspector.TargetManager.Events.NameChanged, this);
+ }
};
/**
* @enum {number}
*/
WebInspector.Target.Capability = {
- Browser: 1,
- DOM: 2,
- JS: 4,
- Log: 8,
- Network: 16,
- Target: 32
+ Browser: 1,
+ DOM: 2,
+ JS: 4,
+ Log: 8,
+ Network: 16,
+ Target: 32
};
WebInspector.Target._nextId = 1;
-WebInspector.Target.prototype = {
- /**
- * @return {boolean}
- */
- isNodeJS: function()
- {
- // TODO(lushnikov): this is an unreliable way to detect Node.js targets.
- return this._capabilitiesMask === WebInspector.Target.Capability.JS || this._isNodeJSForTest;
- },
-
- setIsNodeJSForTest: function()
- {
- this._isNodeJSForTest = true;
- },
-
- /**
- * @return {number}
- */
- id: function()
- {
- return this._id;
- },
-
- /**
- * @return {string}
- */
- name: function()
- {
- return this._name || this._inspectedURLName;
- },
-
- /**
- * @return {!WebInspector.TargetManager}
- */
- targetManager: function()
- {
- return this._targetManager;
- },
-
- /**
- * @param {number} capabilitiesMask
- * @return {boolean}
- */
- hasAllCapabilities: function(capabilitiesMask)
- {
- return (this._capabilitiesMask & capabilitiesMask) === capabilitiesMask;
- },
-
- /**
- * @param {string} label
- * @return {string}
- */
- decorateLabel: function(label)
- {
- return !this.hasBrowserCapability() ? "\u2699 " + label : label;
- },
-
- /**
- * @return {boolean}
- */
- hasBrowserCapability: function()
- {
- return this.hasAllCapabilities(WebInspector.Target.Capability.Browser);
- },
-
- /**
- * @return {boolean}
- */
- hasJSCapability: function()
- {
- return this.hasAllCapabilities(WebInspector.Target.Capability.JS);
- },
-
- /**
- * @return {boolean}
- */
- hasLogCapability: function()
- {
- return this.hasAllCapabilities(WebInspector.Target.Capability.Log);
- },
-
- /**
- * @return {boolean}
- */
- hasNetworkCapability: function()
- {
- return this.hasAllCapabilities(WebInspector.Target.Capability.Network);
- },
-
- /**
- * @return {boolean}
- */
- hasTargetCapability: function()
- {
- return this.hasAllCapabilities(WebInspector.Target.Capability.Target);
- },
-
- /**
- * @return {boolean}
- */
- hasDOMCapability: function()
- {
- return this.hasAllCapabilities(WebInspector.Target.Capability.DOM);
- },
-
- /**
- * @return {?WebInspector.Target}
- */
- parentTarget: function()
- {
- return this._parentTarget;
- },
-
- /**
- * @override
- */
- dispose: function()
- {
- this._targetManager.removeTarget(this);
- for (var model of this._modelByConstructor.valuesArray())
- model.dispose();
- },
-
- /**
- * @param {!Function} modelClass
- * @return {?WebInspector.SDKModel}
- */
- model: function(modelClass)
- {
- return this._modelByConstructor.get(modelClass) || null;
- },
-
- /**
- * @return {!Array<!WebInspector.SDKModel>}
- */
- models: function()
- {
- return this._modelByConstructor.valuesArray();
- },
-
- /**
- * @return {string}
- */
- inspectedURL: function()
- {
- return this._inspectedURL;
- },
-
- /**
- * @param {string} inspectedURL
- */
- setInspectedURL: function(inspectedURL)
- {
- this._inspectedURL = inspectedURL;
- var parsedURL = inspectedURL.asParsedURL();
- this._inspectedURLName = parsedURL ? parsedURL.lastPathComponentWithFragment() : "#" + this._id;
- if (!this.parentTarget())
- InspectorFrontendHost.inspectedURLChanged(inspectedURL || "");
- this._targetManager.dispatchEventToListeners(WebInspector.TargetManager.Events.InspectedURLChanged, this);
- if (!this._name)
- this._targetManager.dispatchEventToListeners(WebInspector.TargetManager.Events.NameChanged, this);
- },
-
- __proto__: Protocol.Target.prototype
-};
-
/**
- * @constructor
- * @extends {WebInspector.Object}
- * @param {!WebInspector.Target} target
+ * @unrestricted
*/
-WebInspector.SDKObject = function(target)
-{
- WebInspector.Object.call(this);
+WebInspector.SDKObject = class extends WebInspector.Object {
+ /**
+ * @param {!WebInspector.Target} target
+ */
+ constructor(target) {
+ super();
this._target = target;
-};
-
-WebInspector.SDKObject.prototype = {
- /**
- * @return {!WebInspector.Target}
- */
- target: function()
- {
- return this._target;
- },
-
- __proto__: WebInspector.Object.prototype
+ }
+
+ /**
+ * @return {!WebInspector.Target}
+ */
+ target() {
+ return this._target;
+ }
};
/**
- * @constructor
- * @extends {WebInspector.SDKObject}
- * @param {!Function} modelClass
- * @param {!WebInspector.Target} target
+ * @unrestricted
*/
-WebInspector.SDKModel = function(modelClass, target)
-{
- WebInspector.SDKObject.call(this, target);
+WebInspector.SDKModel = class extends WebInspector.SDKObject {
+ /**
+ * @param {!Function} modelClass
+ * @param {!WebInspector.Target} target
+ */
+ constructor(modelClass, target) {
+ super(target);
target._modelByConstructor.set(modelClass, this);
-};
-
-WebInspector.SDKModel.prototype = {
- /**
- * @return {!Promise}
- */
- suspendModel: function()
- {
- return Promise.resolve();
- },
-
- /**
- * @return {!Promise}
- */
- resumeModel: function()
- {
- return Promise.resolve();
- },
-
- dispose: function() { },
-
- /**
- * @param {!WebInspector.Event} event
- */
- _targetDisposed: function(event)
- {
- var target = /** @type {!WebInspector.Target} */ (event.data);
- if (target !== this._target)
- return;
- this.dispose();
- },
-
- __proto__: WebInspector.SDKObject.prototype
+ }
+
+ /**
+ * @return {!Promise}
+ */
+ suspendModel() {
+ return Promise.resolve();
+ }
+
+ /**
+ * @return {!Promise}
+ */
+ resumeModel() {
+ return Promise.resolve();
+ }
+
+ dispose() {
+ }
+
+ /**
+ * @param {!WebInspector.Event} event
+ */
+ _targetDisposed(event) {
+ var target = /** @type {!WebInspector.Target} */ (event.data);
+ if (target !== this._target)
+ return;
+ this.dispose();
+ }
};

Powered by Google App Engine
This is Rietveld 408576698