Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/Reload.js ('k') | third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js b/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
index 26d2e57a56d166540065a982bb6c5706cddbef49..bf04fa8cbaa45c78f43ab8631d38dd63ff71bf88 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
@@ -1,174 +1,159 @@
// Copyright (c) 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
/**
- * @constructor
+ * @unrestricted
*/
-WebInspector.RemoteObjectPreviewFormatter = function()
-{
-};
+WebInspector.RemoteObjectPreviewFormatter = class {
+ /**
+ * @param {!Element} parentElement
+ * @param {!RuntimeAgent.ObjectPreview} preview
+ */
+ appendObjectPreview(parentElement, preview) {
+ var description = preview.description;
+ if (preview.type !== 'object' || preview.subtype === 'null') {
+ parentElement.appendChild(this.renderPropertyPreview(preview.type, preview.subtype, description));
+ return;
+ }
+ if (description && preview.subtype !== 'array' && preview.subtype !== 'typedarray') {
+ var text = preview.subtype ? description : this._abbreviateFullQualifiedClassName(description);
+ parentElement.createTextChildren(text, ' ');
+ }
+ if (preview.entries)
+ this._appendEntriesPreview(parentElement, preview);
+ else
+ this._appendPropertiesPreview(parentElement, preview);
+ }
+
+ /**
+ * @param {string} description
+ * @return {string}
+ */
+ _abbreviateFullQualifiedClassName(description) {
+ var abbreviatedDescription = description.split('.');
+ for (var i = 0; i < abbreviatedDescription.length - 1; ++i)
+ abbreviatedDescription[i] = abbreviatedDescription[i].trimMiddle(3);
+ return abbreviatedDescription.join('.');
+ }
+
+ /**
+ * @param {!Element} parentElement
+ * @param {!RuntimeAgent.ObjectPreview} preview
+ */
+ _appendPropertiesPreview(parentElement, preview) {
+ var isArray = preview.subtype === 'array' || preview.subtype === 'typedarray';
+ var arrayLength = WebInspector.RemoteObject.arrayLength(preview);
+ var properties = preview.properties;
+ if (isArray)
+ properties = properties.slice().stableSort(compareIndexesFirst);
-WebInspector.RemoteObjectPreviewFormatter.prototype = {
/**
- * @param {!Element} parentElement
- * @param {!RuntimeAgent.ObjectPreview} preview
+ * @param {!RuntimeAgent.PropertyPreview} a
+ * @param {!RuntimeAgent.PropertyPreview} b
*/
- appendObjectPreview: function(parentElement, preview)
- {
- var description = preview.description;
- if (preview.type !== "object" || preview.subtype === "null") {
- parentElement.appendChild(this.renderPropertyPreview(preview.type, preview.subtype, description));
- return;
- }
- if (description && preview.subtype !== "array" && preview.subtype !== "typedarray") {
- var text = preview.subtype ? description : this._abbreviateFullQualifiedClassName(description);
- parentElement.createTextChildren(text, " ");
- }
- if (preview.entries)
- this._appendEntriesPreview(parentElement, preview);
- else
- this._appendPropertiesPreview(parentElement, preview);
- },
+ function compareIndexesFirst(a, b) {
+ var index1 = toArrayIndex(a.name);
+ var index2 = toArrayIndex(b.name);
+ if (index1 < 0)
+ return index2 < 0 ? 0 : 1;
+ return index2 < 0 ? -1 : index1 - index2;
+ }
/**
- * @param {string} description
- * @return {string}
+ * @param {string} name
+ * @return {number}
*/
- _abbreviateFullQualifiedClassName: function(description)
- {
- var abbreviatedDescription = description.split(".");
- for (var i = 0; i < abbreviatedDescription.length - 1; ++i)
- abbreviatedDescription[i] = abbreviatedDescription[i].trimMiddle(3);
- return abbreviatedDescription.join(".");
- },
+ function toArrayIndex(name) {
+ var index = name >>> 0;
+ if (String(index) === name && index < arrayLength)
+ return index;
+ return -1;
+ }
- /**
- * @param {!Element} parentElement
- * @param {!RuntimeAgent.ObjectPreview} preview
- */
- _appendPropertiesPreview: function(parentElement, preview)
- {
- var isArray = preview.subtype === "array" || preview.subtype === "typedarray";
- var arrayLength = WebInspector.RemoteObject.arrayLength(preview);
- var properties = preview.properties;
- if (isArray)
- properties = properties.slice().stableSort(compareIndexesFirst);
-
- /**
- * @param {!RuntimeAgent.PropertyPreview} a
- * @param {!RuntimeAgent.PropertyPreview} b
- */
- function compareIndexesFirst(a, b)
- {
- var index1 = toArrayIndex(a.name);
- var index2 = toArrayIndex(b.name);
- if (index1 < 0)
- return index2 < 0 ? 0 : 1;
- return index2 < 0 ? -1 : index1 - index2;
- }
-
- /**
- * @param {string} name
- * @return {number}
- */
- function toArrayIndex(name)
- {
- var index = name >>> 0;
- if (String(index) === name && index < arrayLength)
- return index;
- return -1;
- }
-
- parentElement.createTextChild(isArray ? "[" : "{");
- for (var i = 0; i < properties.length; ++i) {
- if (i > 0)
- parentElement.createTextChild(", ");
-
- var property = properties[i];
- var name = property.name;
- if (!isArray || name !== String(i) || i >= arrayLength) {
- if (/^\s|\s$|^$|\n/.test(name))
- parentElement.createChild("span", "name").createTextChildren("\"", name.replace(/\n/g, "\u21B5"), "\"");
- else
- parentElement.createChild("span", "name").textContent = name;
- parentElement.createTextChild(": ");
- }
-
- parentElement.appendChild(this._renderPropertyPreviewOrAccessor([property]));
- }
- if (preview.overflow)
- parentElement.createChild("span").textContent = "\u2026";
- parentElement.createTextChild(isArray ? "]" : "}");
- },
+ parentElement.createTextChild(isArray ? '[' : '{');
+ for (var i = 0; i < properties.length; ++i) {
+ if (i > 0)
+ parentElement.createTextChild(', ');
+ var property = properties[i];
+ var name = property.name;
+ if (!isArray || name !== String(i) || i >= arrayLength) {
+ if (/^\s|\s$|^$|\n/.test(name))
+ parentElement.createChild('span', 'name').createTextChildren('"', name.replace(/\n/g, '\u21B5'), '"');
+ else
+ parentElement.createChild('span', 'name').textContent = name;
+ parentElement.createTextChild(': ');
+ }
- /**
- * @param {!Element} parentElement
- * @param {!RuntimeAgent.ObjectPreview} preview
- */
- _appendEntriesPreview: function(parentElement, preview)
- {
- parentElement.createTextChild("{");
- for (var i = 0; i < preview.entries.length; ++i) {
- if (i > 0)
- parentElement.createTextChild(", ");
-
- var entry = preview.entries[i];
- if (entry.key) {
- this.appendObjectPreview(parentElement, entry.key);
- parentElement.createTextChild(" => ");
- }
- this.appendObjectPreview(parentElement, entry.value);
- }
- if (preview.overflow)
- parentElement.createChild("span").textContent = "\u2026";
- parentElement.createTextChild("}");
- },
+ parentElement.appendChild(this._renderPropertyPreviewOrAccessor([property]));
+ }
+ if (preview.overflow)
+ parentElement.createChild('span').textContent = '\u2026';
+ parentElement.createTextChild(isArray ? ']' : '}');
+ }
+
+ /**
+ * @param {!Element} parentElement
+ * @param {!RuntimeAgent.ObjectPreview} preview
+ */
+ _appendEntriesPreview(parentElement, preview) {
+ parentElement.createTextChild('{');
+ for (var i = 0; i < preview.entries.length; ++i) {
+ if (i > 0)
+ parentElement.createTextChild(', ');
+
+ var entry = preview.entries[i];
+ if (entry.key) {
+ this.appendObjectPreview(parentElement, entry.key);
+ parentElement.createTextChild(' => ');
+ }
+ this.appendObjectPreview(parentElement, entry.value);
+ }
+ if (preview.overflow)
+ parentElement.createChild('span').textContent = '\u2026';
+ parentElement.createTextChild('}');
+ }
+
+ /**
+ * @param {!Array.<!RuntimeAgent.PropertyPreview>} propertyPath
+ * @return {!Element}
+ */
+ _renderPropertyPreviewOrAccessor(propertyPath) {
+ var property = propertyPath.peekLast();
+ return this.renderPropertyPreview(property.type, /** @type {string} */ (property.subtype), property.value);
+ }
+
+ /**
+ * @param {string} type
+ * @param {string=} subtype
+ * @param {string=} description
+ * @return {!Element}
+ */
+ renderPropertyPreview(type, subtype, description) {
+ var span = createElementWithClass('span', 'object-value-' + (subtype || type));
+ description = description || '';
+
+ if (type === 'function') {
+ span.textContent = 'function';
+ return span;
+ }
+ if (type === 'object' && subtype === 'node' && description) {
+ WebInspector.DOMPresentationUtils.createSpansForNodeTitle(span, description);
+ return span;
+ }
- /**
- * @param {!Array.<!RuntimeAgent.PropertyPreview>} propertyPath
- * @return {!Element}
- */
- _renderPropertyPreviewOrAccessor: function(propertyPath)
- {
- var property = propertyPath.peekLast();
- return this.renderPropertyPreview(property.type, /** @type {string} */ (property.subtype), property.value);
- },
+ if (type === 'string') {
+ span.createTextChildren('"', description.replace(/\n/g, '\u21B5'), '"');
+ return span;
+ }
- /**
- * @param {string} type
- * @param {string=} subtype
- * @param {string=} description
- * @return {!Element}
- */
- renderPropertyPreview: function(type, subtype, description)
- {
- var span = createElementWithClass("span", "object-value-" + (subtype || type));
- description = description || "";
-
- if (type === "function") {
- span.textContent = "function";
- return span;
- }
-
- if (type === "object" && subtype === "node" && description) {
- WebInspector.DOMPresentationUtils.createSpansForNodeTitle(span, description);
- return span;
- }
-
- if (type === "string") {
- span.createTextChildren("\"", description.replace(/\n/g, "\u21B5"), "\"");
- return span;
- }
-
- if (type === "object" && !subtype) {
- span.textContent = this._abbreviateFullQualifiedClassName(description);
- return span;
- }
-
- span.textContent = description;
- return span;
+ if (type === 'object' && !subtype) {
+ span.textContent = this._abbreviateFullQualifiedClassName(description);
+ return span;
}
+
+ span.textContent = description;
+ return span;
+ }
};
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/Reload.js ('k') | third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698