Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js b/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
index 1389f8f0f6befcec16f925e202e1b5c0c9267f07..b03a56382cf274bc51911505c2570860897de0f4 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
@@ -1,119 +1,106 @@
-
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
/**
- * @constructor
* @implements {WebInspector.SourcesView.EditorAction}
+ * @unrestricted
*/
-WebInspector.InplaceFormatterEditorAction = function()
-{
-};
+WebInspector.InplaceFormatterEditorAction = class {
+ /**
+ * @param {!WebInspector.Event} event
+ */
+ _editorSelected(event) {
+ var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.data);
+ this._updateButton(uiSourceCode);
+ }
-WebInspector.InplaceFormatterEditorAction.prototype = {
- /**
- * @param {!WebInspector.Event} event
- */
- _editorSelected: function(event)
- {
- var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.data);
- this._updateButton(uiSourceCode);
- },
+ /**
+ * @param {!WebInspector.Event} event
+ */
+ _editorClosed(event) {
+ var wasSelected = /** @type {boolean} */ (event.data.wasSelected);
+ if (wasSelected)
+ this._updateButton(null);
+ }
- /**
- * @param {!WebInspector.Event} event
- */
- _editorClosed: function(event)
- {
- var wasSelected = /** @type {boolean} */ (event.data.wasSelected);
- if (wasSelected)
- this._updateButton(null);
- },
-
- /**
- * @param {?WebInspector.UISourceCode} uiSourceCode
- */
- _updateButton: function(uiSourceCode)
- {
- this._button.element.classList.toggle("hidden", !this._isFormattable(uiSourceCode));
- },
+ /**
+ * @param {?WebInspector.UISourceCode} uiSourceCode
+ */
+ _updateButton(uiSourceCode) {
+ this._button.element.classList.toggle('hidden', !this._isFormattable(uiSourceCode));
+ }
- /**
- * @override
- * @param {!WebInspector.SourcesView} sourcesView
- * @return {!WebInspector.ToolbarButton}
- */
- button: function(sourcesView)
- {
- if (this._button)
- return this._button;
+ /**
+ * @override
+ * @param {!WebInspector.SourcesView} sourcesView
+ * @return {!WebInspector.ToolbarButton}
+ */
+ button(sourcesView) {
+ if (this._button)
+ return this._button;
- this._sourcesView = sourcesView;
- this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorSelected, this._editorSelected.bind(this));
- this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorClosed, this._editorClosed.bind(this));
+ this._sourcesView = sourcesView;
+ this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorSelected, this._editorSelected.bind(this));
+ this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorClosed, this._editorClosed.bind(this));
- this._button = new WebInspector.ToolbarButton(WebInspector.UIString("Format"), "format-toolbar-item");
- this._button.addEventListener("click", this._formatSourceInPlace, this);
- this._updateButton(sourcesView.currentUISourceCode());
+ this._button = new WebInspector.ToolbarButton(WebInspector.UIString('Format'), 'format-toolbar-item');
+ this._button.addEventListener('click', this._formatSourceInPlace, this);
+ this._updateButton(sourcesView.currentUISourceCode());
- return this._button;
- },
+ return this._button;
+ }
- /**
- * @param {?WebInspector.UISourceCode} uiSourceCode
- * @return {boolean}
- */
- _isFormattable: function(uiSourceCode)
- {
- if (!uiSourceCode)
- return false;
- if (uiSourceCode.project().type() === WebInspector.projectTypes.FileSystem)
- return true;
- if (WebInspector.persistence.binding(uiSourceCode))
- return true;
- return uiSourceCode.contentType().isStyleSheet()
- || uiSourceCode.project().type() === WebInspector.projectTypes.Snippets;
- },
+ /**
+ * @param {?WebInspector.UISourceCode} uiSourceCode
+ * @return {boolean}
+ */
+ _isFormattable(uiSourceCode) {
+ if (!uiSourceCode)
+ return false;
+ if (uiSourceCode.project().type() === WebInspector.projectTypes.FileSystem)
+ return true;
+ if (WebInspector.persistence.binding(uiSourceCode))
+ return true;
+ return uiSourceCode.contentType().isStyleSheet() ||
+ uiSourceCode.project().type() === WebInspector.projectTypes.Snippets;
+ }
- _formatSourceInPlace: function()
- {
- var uiSourceCode = this._sourcesView.currentUISourceCode();
- if (!this._isFormattable(uiSourceCode))
- return;
+ _formatSourceInPlace() {
+ var uiSourceCode = this._sourcesView.currentUISourceCode();
+ if (!this._isFormattable(uiSourceCode))
+ return;
- if (uiSourceCode.isDirty())
- contentLoaded.call(this, uiSourceCode.workingCopy());
- else
- uiSourceCode.requestContent().then(contentLoaded.bind(this));
+ if (uiSourceCode.isDirty())
+ contentLoaded.call(this, uiSourceCode.workingCopy());
+ else
+ uiSourceCode.requestContent().then(contentLoaded.bind(this));
- /**
- * @this {WebInspector.InplaceFormatterEditorAction}
- * @param {?string} content
- */
- function contentLoaded(content)
- {
- var highlighterType = WebInspector.NetworkProject.uiSourceCodeMimeType(uiSourceCode);
- WebInspector.Formatter.format(uiSourceCode.contentType(), highlighterType, content || "", innerCallback.bind(this));
- }
+ /**
+ * @this {WebInspector.InplaceFormatterEditorAction}
+ * @param {?string} content
+ */
+ function contentLoaded(content) {
+ var highlighterType = WebInspector.NetworkProject.uiSourceCodeMimeType(uiSourceCode);
+ WebInspector.Formatter.format(
+ uiSourceCode.contentType(), highlighterType, content || '', innerCallback.bind(this));
+ }
- /**
- * @this {WebInspector.InplaceFormatterEditorAction}
- * @param {string} formattedContent
- * @param {!WebInspector.FormatterSourceMapping} formatterMapping
- */
- function innerCallback(formattedContent, formatterMapping)
- {
- if (uiSourceCode.workingCopy() === formattedContent)
- return;
- var sourceFrame = this._sourcesView.viewForFile(uiSourceCode);
- var start = [0, 0];
- if (sourceFrame) {
- var selection = sourceFrame.selection();
- start = formatterMapping.originalToFormatted(selection.startLine, selection.startColumn);
- }
- uiSourceCode.setWorkingCopy(formattedContent);
- this._sourcesView.showSourceLocation(uiSourceCode, start[0], start[1]);
- }
- },
+ /**
+ * @this {WebInspector.InplaceFormatterEditorAction}
+ * @param {string} formattedContent
+ * @param {!WebInspector.FormatterSourceMapping} formatterMapping
+ */
+ function innerCallback(formattedContent, formatterMapping) {
+ if (uiSourceCode.workingCopy() === formattedContent)
+ return;
+ var sourceFrame = this._sourcesView.viewForFile(uiSourceCode);
+ var start = [0, 0];
+ if (sourceFrame) {
+ var selection = sourceFrame.selection();
+ start = formatterMapping.originalToFormatted(selection.startLine, selection.startColumn);
+ }
+ uiSourceCode.setWorkingCopy(formattedContent);
+ this._sourcesView.showSourceLocation(uiSourceCode, start[0], start[1]);
+ }
+ }
};

Powered by Google App Engine
This is Rietveld 408576698