Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineIRModel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
index 97ab4fd46cca4e5100664562b3cd9791479dfc8c..b0bf7c629d3e62de5200b9411b602cabc5037a19 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
@@ -1,216 +1,206 @@
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
-
-WebInspector.TimelineJSProfileProcessor = { };
+WebInspector.TimelineJSProfileProcessor = {};
/**
* @param {!WebInspector.CPUProfileDataModel} jsProfileModel
* @param {!WebInspector.TracingModel.Thread} thread
* @return {!Array<!WebInspector.TracingModel.Event>}
*/
-WebInspector.TimelineJSProfileProcessor.generateTracingEventsFromCpuProfile = function(jsProfileModel, thread)
-{
- var idleNode = jsProfileModel.idleNode;
- var programNode = jsProfileModel.programNode;
- var gcNode = jsProfileModel.gcNode;
- var samples = jsProfileModel.samples;
- var timestamps = jsProfileModel.timestamps;
- var jsEvents = [];
- /** @type {!Map<!Object, !Array<!RuntimeAgent.CallFrame>>} */
- var nodeToStackMap = new Map();
- nodeToStackMap.set(programNode, []);
- for (var i = 0; i < samples.length; ++i) {
- var node = jsProfileModel.nodeByIndex(i);
- if (!node) {
- console.error(`Node with unknown id ${samples[i]} at index ${i}`);
- continue;
- }
- if (node === gcNode || node === idleNode)
- continue;
- var callFrames = nodeToStackMap.get(node);
- if (!callFrames) {
- callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (new Array(node.depth + 1));
- nodeToStackMap.set(node, callFrames);
- for (var j = 0; node.parent; node = node.parent)
- callFrames[j++] = /** @type {!RuntimeAgent.CallFrame} */ (node);
- }
- var jsSampleEvent = new WebInspector.TracingModel.Event(WebInspector.TracingModel.DevToolsTimelineEventCategory,
- WebInspector.TimelineModel.RecordType.JSSample,
- WebInspector.TracingModel.Phase.Instant, timestamps[i], thread);
- jsSampleEvent.args["data"] = { stackTrace: callFrames };
- jsEvents.push(jsSampleEvent);
+WebInspector.TimelineJSProfileProcessor.generateTracingEventsFromCpuProfile = function(jsProfileModel, thread) {
+ var idleNode = jsProfileModel.idleNode;
+ var programNode = jsProfileModel.programNode;
+ var gcNode = jsProfileModel.gcNode;
+ var samples = jsProfileModel.samples;
+ var timestamps = jsProfileModel.timestamps;
+ var jsEvents = [];
+ /** @type {!Map<!Object, !Array<!RuntimeAgent.CallFrame>>} */
+ var nodeToStackMap = new Map();
+ nodeToStackMap.set(programNode, []);
+ for (var i = 0; i < samples.length; ++i) {
+ var node = jsProfileModel.nodeByIndex(i);
+ if (!node) {
+ console.error(`Node with unknown id ${samples[i]} at index ${i}`);
+ continue;
+ }
+ if (node === gcNode || node === idleNode)
+ continue;
+ var callFrames = nodeToStackMap.get(node);
+ if (!callFrames) {
+ callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (new Array(node.depth + 1));
+ nodeToStackMap.set(node, callFrames);
+ for (var j = 0; node.parent; node = node.parent)
+ callFrames[j++] = /** @type {!RuntimeAgent.CallFrame} */ (node);
}
- return jsEvents;
+ var jsSampleEvent = new WebInspector.TracingModel.Event(
+ WebInspector.TracingModel.DevToolsTimelineEventCategory, WebInspector.TimelineModel.RecordType.JSSample,
+ WebInspector.TracingModel.Phase.Instant, timestamps[i], thread);
+ jsSampleEvent.args['data'] = {stackTrace: callFrames};
+ jsEvents.push(jsSampleEvent);
+ }
+ return jsEvents;
};
/**
* @param {!Array<!WebInspector.TracingModel.Event>} events
* @return {!Array<!WebInspector.TracingModel.Event>}
*/
-WebInspector.TimelineJSProfileProcessor.generateJSFrameEvents = function(events)
-{
- /**
- * @param {!RuntimeAgent.CallFrame} frame1
- * @param {!RuntimeAgent.CallFrame} frame2
- * @return {boolean}
- */
- function equalFrames(frame1, frame2)
- {
- return frame1.scriptId === frame2.scriptId && frame1.functionName === frame2.functionName;
- }
+WebInspector.TimelineJSProfileProcessor.generateJSFrameEvents = function(events) {
+ /**
+ * @param {!RuntimeAgent.CallFrame} frame1
+ * @param {!RuntimeAgent.CallFrame} frame2
+ * @return {boolean}
+ */
+ function equalFrames(frame1, frame2) {
+ return frame1.scriptId === frame2.scriptId && frame1.functionName === frame2.functionName;
+ }
- /**
- * @param {!WebInspector.TracingModel.Event} e
- * @return {number}
- */
- function eventEndTime(e)
- {
- return e.endTime || e.startTime;
- }
+ /**
+ * @param {!WebInspector.TracingModel.Event} e
+ * @return {number}
+ */
+ function eventEndTime(e) {
+ return e.endTime || e.startTime;
+ }
- /**
- * @param {!WebInspector.TracingModel.Event} e
- * @return {boolean}
- */
- function isJSInvocationEvent(e)
- {
- switch (e.name) {
- case WebInspector.TimelineModel.RecordType.RunMicrotasks:
- case WebInspector.TimelineModel.RecordType.FunctionCall:
- case WebInspector.TimelineModel.RecordType.EvaluateScript:
- return true;
- }
- return false;
+ /**
+ * @param {!WebInspector.TracingModel.Event} e
+ * @return {boolean}
+ */
+ function isJSInvocationEvent(e) {
+ switch (e.name) {
+ case WebInspector.TimelineModel.RecordType.RunMicrotasks:
+ case WebInspector.TimelineModel.RecordType.FunctionCall:
+ case WebInspector.TimelineModel.RecordType.EvaluateScript:
+ return true;
}
+ return false;
+ }
- var jsFrameEvents = [];
- var jsFramesStack = [];
- var lockedJsStackDepth = [];
- var ordinal = 0;
- var filterNativeFunctions = !WebInspector.moduleSetting("showNativeFunctionsInJSProfile").get();
+ var jsFrameEvents = [];
+ var jsFramesStack = [];
+ var lockedJsStackDepth = [];
+ var ordinal = 0;
+ var filterNativeFunctions = !WebInspector.moduleSetting('showNativeFunctionsInJSProfile').get();
- /**
- * @param {!WebInspector.TracingModel.Event} e
- */
- function onStartEvent(e)
- {
- e.ordinal = ++ordinal;
- extractStackTrace(e);
- // For the duration of the event we cannot go beyond the stack associated with it.
- lockedJsStackDepth.push(jsFramesStack.length);
- }
+ /**
+ * @param {!WebInspector.TracingModel.Event} e
+ */
+ function onStartEvent(e) {
+ e.ordinal = ++ordinal;
+ extractStackTrace(e);
+ // For the duration of the event we cannot go beyond the stack associated with it.
+ lockedJsStackDepth.push(jsFramesStack.length);
+ }
- /**
- * @param {!WebInspector.TracingModel.Event} e
- * @param {?WebInspector.TracingModel.Event} parent
- */
- function onInstantEvent(e, parent)
- {
- e.ordinal = ++ordinal;
- if (parent && isJSInvocationEvent(parent))
- extractStackTrace(e);
- }
+ /**
+ * @param {!WebInspector.TracingModel.Event} e
+ * @param {?WebInspector.TracingModel.Event} parent
+ */
+ function onInstantEvent(e, parent) {
+ e.ordinal = ++ordinal;
+ if (parent && isJSInvocationEvent(parent))
+ extractStackTrace(e);
+ }
- /**
- * @param {!WebInspector.TracingModel.Event} e
- */
- function onEndEvent(e)
- {
- truncateJSStack(lockedJsStackDepth.pop(), e.endTime);
- }
+ /**
+ * @param {!WebInspector.TracingModel.Event} e
+ */
+ function onEndEvent(e) {
+ truncateJSStack(lockedJsStackDepth.pop(), e.endTime);
+ }
- /**
- * @param {number} depth
- * @param {number} time
- */
- function truncateJSStack(depth, time)
- {
- if (lockedJsStackDepth.length) {
- var lockedDepth = lockedJsStackDepth.peekLast();
- if (depth < lockedDepth) {
- console.error("Child stack is shallower (" + depth + ") than the parent stack (" + lockedDepth + ") at " + time);
- depth = lockedDepth;
- }
- }
- if (jsFramesStack.length < depth) {
- console.error("Trying to truncate higher than the current stack size at " + time);
- depth = jsFramesStack.length;
- }
- for (var k = 0; k < jsFramesStack.length; ++k)
- jsFramesStack[k].setEndTime(time);
- jsFramesStack.length = depth;
+ /**
+ * @param {number} depth
+ * @param {number} time
+ */
+ function truncateJSStack(depth, time) {
+ if (lockedJsStackDepth.length) {
+ var lockedDepth = lockedJsStackDepth.peekLast();
+ if (depth < lockedDepth) {
+ console.error(
+ 'Child stack is shallower (' + depth + ') than the parent stack (' + lockedDepth + ') at ' + time);
+ depth = lockedDepth;
+ }
+ }
+ if (jsFramesStack.length < depth) {
+ console.error('Trying to truncate higher than the current stack size at ' + time);
+ depth = jsFramesStack.length;
}
+ for (var k = 0; k < jsFramesStack.length; ++k)
+ jsFramesStack[k].setEndTime(time);
+ jsFramesStack.length = depth;
+ }
- /**
- * @param {!Array<!RuntimeAgent.CallFrame>} stack
- */
- function filterStackFrames(stack)
- {
- for (var i = 0, j = 0; i < stack.length; ++i) {
- var url = stack[i].url;
- if (url && url.startsWith("native "))
- continue;
- stack[j++] = stack[i];
- }
- stack.length = j;
+ /**
+ * @param {!Array<!RuntimeAgent.CallFrame>} stack
+ */
+ function filterStackFrames(stack) {
+ for (var i = 0, j = 0; i < stack.length; ++i) {
+ var url = stack[i].url;
+ if (url && url.startsWith('native '))
+ continue;
+ stack[j++] = stack[i];
}
+ stack.length = j;
+ }
- /**
- * @param {!WebInspector.TracingModel.Event} e
- */
- function extractStackTrace(e)
- {
- var recordTypes = WebInspector.TimelineModel.RecordType;
- var callFrames;
- if (e.name === recordTypes.JSSample) {
- var eventData = e.args["data"] || e.args["beginData"];
- callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (eventData && eventData["stackTrace"]);
- } else {
- callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (jsFramesStack.map(frameEvent => frameEvent.args["data"]).reverse());
- }
- if (filterNativeFunctions)
- filterStackFrames(callFrames);
- var endTime = eventEndTime(e);
- var numFrames = callFrames.length;
- var minFrames = Math.min(numFrames, jsFramesStack.length);
- var i;
- for (i = lockedJsStackDepth.peekLast() || 0; i < minFrames; ++i) {
- var newFrame = callFrames[numFrames - 1 - i];
- var oldFrame = jsFramesStack[i].args["data"];
- if (!equalFrames(newFrame, oldFrame))
- break;
- jsFramesStack[i].setEndTime(Math.max(jsFramesStack[i].endTime, endTime));
- }
- truncateJSStack(i, e.startTime);
- for (; i < numFrames; ++i) {
- var frame = callFrames[numFrames - 1 - i];
- var jsFrameEvent = new WebInspector.TracingModel.Event(WebInspector.TracingModel.DevToolsTimelineEventCategory, recordTypes.JSFrame,
- WebInspector.TracingModel.Phase.Complete, e.startTime, e.thread);
- jsFrameEvent.ordinal = e.ordinal;
- jsFrameEvent.addArgs({ data: frame });
- jsFrameEvent.setEndTime(endTime);
- jsFramesStack.push(jsFrameEvent);
- jsFrameEvents.push(jsFrameEvent);
- }
+ /**
+ * @param {!WebInspector.TracingModel.Event} e
+ */
+ function extractStackTrace(e) {
+ var recordTypes = WebInspector.TimelineModel.RecordType;
+ var callFrames;
+ if (e.name === recordTypes.JSSample) {
+ var eventData = e.args['data'] || e.args['beginData'];
+ callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (eventData && eventData['stackTrace']);
+ } else {
+ callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (
+ jsFramesStack.map(frameEvent => frameEvent.args['data']).reverse());
+ }
+ if (filterNativeFunctions)
+ filterStackFrames(callFrames);
+ var endTime = eventEndTime(e);
+ var numFrames = callFrames.length;
+ var minFrames = Math.min(numFrames, jsFramesStack.length);
+ var i;
+ for (i = lockedJsStackDepth.peekLast() || 0; i < minFrames; ++i) {
+ var newFrame = callFrames[numFrames - 1 - i];
+ var oldFrame = jsFramesStack[i].args['data'];
+ if (!equalFrames(newFrame, oldFrame))
+ break;
+ jsFramesStack[i].setEndTime(Math.max(jsFramesStack[i].endTime, endTime));
+ }
+ truncateJSStack(i, e.startTime);
+ for (; i < numFrames; ++i) {
+ var frame = callFrames[numFrames - 1 - i];
+ var jsFrameEvent = new WebInspector.TracingModel.Event(
+ WebInspector.TracingModel.DevToolsTimelineEventCategory, recordTypes.JSFrame,
+ WebInspector.TracingModel.Phase.Complete, e.startTime, e.thread);
+ jsFrameEvent.ordinal = e.ordinal;
+ jsFrameEvent.addArgs({data: frame});
+ jsFrameEvent.setEndTime(endTime);
+ jsFramesStack.push(jsFrameEvent);
+ jsFrameEvents.push(jsFrameEvent);
}
+ }
- /**
- * @param {!Array<!WebInspector.TracingModel.Event>} events
- * @return {?WebInspector.TracingModel.Event}
- */
- function findFirstTopLevelEvent(events)
- {
- for (var i = 0; i < events.length; ++i) {
- if (WebInspector.TracingModel.isTopLevelEvent(events[i]))
- return events[i];
- }
- return null;
+ /**
+ * @param {!Array<!WebInspector.TracingModel.Event>} events
+ * @return {?WebInspector.TracingModel.Event}
+ */
+ function findFirstTopLevelEvent(events) {
+ for (var i = 0; i < events.length; ++i) {
+ if (WebInspector.TracingModel.isTopLevelEvent(events[i]))
+ return events[i];
}
+ return null;
+ }
- var firstTopLevelEvent = findFirstTopLevelEvent(events);
- if (firstTopLevelEvent)
- WebInspector.TimelineModel.forEachEvent(events, onStartEvent, onEndEvent, onInstantEvent, firstTopLevelEvent.startTime);
- return jsFrameEvents;
+ var firstTopLevelEvent = findFirstTopLevelEvent(events);
+ if (firstTopLevelEvent)
+ WebInspector.TimelineModel.forEachEvent(
+ events, onStartEvent, onEndEvent, onInstantEvent, firstTopLevelEvent.startTime);
+ return jsFrameEvents;
};
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineIRModel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698