Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js

Issue 2466123002: DevTools: reformat front-end code to match chromium style. (Closed)
Patch Set: all done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
index 02a15310e29b1ab7b42ff84087944f1fa1a5297d..49b8a422b0e26b39a344a0935e47817d2c1622d4 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
@@ -27,27 +27,27 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-
/**
- * @constructor
- * @param {!WebInspector.AuditController} auditController
- * @extends {WebInspector.VBox}
+ * @unrestricted
*/
-WebInspector.AuditLauncherView = function(auditController)
-{
- WebInspector.VBox.call(this);
+WebInspector.AuditLauncherView = class extends WebInspector.VBox {
+ /**
+ * @param {!WebInspector.AuditController} auditController
+ */
+ constructor(auditController) {
+ super();
this.setMinimumSize(100, 25);
this._auditController = auditController;
- this._categoryIdPrefix = "audit-category-item-";
+ this._categoryIdPrefix = 'audit-category-item-';
this._auditRunning = false;
- this.element.classList.add("audit-launcher-view");
- this.element.classList.add("panel-enabler-view");
+ this.element.classList.add('audit-launcher-view');
+ this.element.classList.add('panel-enabler-view');
- this._contentElement = createElement("div");
- this._contentElement.className = "audit-launcher-view-content";
+ this._contentElement = createElement('div');
+ this._contentElement.className = 'audit-launcher-view-content';
this.element.appendChild(this._contentElement);
this._boundCategoryClickListener = this._categoryClicked.bind(this);
@@ -55,256 +55,241 @@ WebInspector.AuditLauncherView = function(auditController)
this._sortedCategories = [];
- this._headerElement = createElement("h1");
- this._headerElement.className = "no-audits";
- this._headerElement.textContent = WebInspector.UIString("No audits to run");
+ this._headerElement = createElement('h1');
+ this._headerElement.className = 'no-audits';
+ this._headerElement.textContent = WebInspector.UIString('No audits to run');
this._contentElement.appendChild(this._headerElement);
- WebInspector.targetManager.addModelListener(WebInspector.NetworkManager, WebInspector.NetworkManager.Events.RequestStarted, this._onRequestStarted, this);
- WebInspector.targetManager.addModelListener(WebInspector.NetworkManager, WebInspector.NetworkManager.Events.RequestFinished, this._onRequestFinished, this);
+ WebInspector.targetManager.addModelListener(
+ WebInspector.NetworkManager, WebInspector.NetworkManager.Events.RequestStarted, this._onRequestStarted, this);
+ WebInspector.targetManager.addModelListener(
+ WebInspector.NetworkManager, WebInspector.NetworkManager.Events.RequestFinished, this._onRequestFinished, this);
var defaultSelectedAuditCategory = {};
defaultSelectedAuditCategory[WebInspector.AuditLauncherView.AllCategoriesKey] = true;
- this._selectedCategoriesSetting = WebInspector.settings.createSetting("selectedAuditCategories", defaultSelectedAuditCategory);
-};
-
-WebInspector.AuditLauncherView.AllCategoriesKey = "__AllCategories";
-
-WebInspector.AuditLauncherView.prototype = {
- _resetResourceCount: function()
- {
- this._loadedResources = 0;
- this._totalResources = 0;
- },
-
- _onRequestStarted: function(event)
- {
- var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);
- // Ignore long-living WebSockets for the sake of progress indicator, as we won't be waiting them anyway.
- if (request.resourceType() === WebInspector.resourceTypes.WebSocket)
- return;
- ++this._totalResources;
- this._updateResourceProgress();
- },
-
- _onRequestFinished: function(event)
- {
- var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);
- // See resorceStarted for details.
- if (request.resourceType() === WebInspector.resourceTypes.WebSocket)
- return;
- ++this._loadedResources;
- this._updateResourceProgress();
- },
-
- /**
- * @param {!WebInspector.AuditCategory} category
- */
- addCategory: function(category)
- {
- if (!this._sortedCategories.length)
- this._createLauncherUI();
-
- var selectedCategories = this._selectedCategoriesSetting.get();
- var categoryElement = this._createCategoryElement(category.displayName, category.id);
- category._checkboxElement = categoryElement.checkboxElement;
- if (this._selectAllCheckboxElement.checked || selectedCategories[category.displayName]) {
- category._checkboxElement.checked = true;
- ++this._currentCategoriesCount;
- }
-
- /**
- * @param {!WebInspector.AuditCategory} a
- * @param {!WebInspector.AuditCategory} b
- * @return {number}
- */
- function compareCategories(a, b)
- {
- var aTitle = a.displayName || "";
- var bTitle = b.displayName || "";
- return aTitle.localeCompare(bTitle);
- }
- var insertBefore = this._sortedCategories.lowerBound(category, compareCategories);
- this._categoriesElement.insertBefore(categoryElement, this._categoriesElement.children[insertBefore]);
- this._sortedCategories.splice(insertBefore, 0, category);
- this._selectedCategoriesUpdated();
- },
-
- _startAudit: function()
- {
- this._auditRunning = true;
- this._updateButton();
- this._toggleUIComponents(this._auditRunning);
-
- var catIds = [];
- for (var category = 0; category < this._sortedCategories.length; ++category) {
- if (this._sortedCategories[category]._checkboxElement.checked)
- catIds.push(this._sortedCategories[category].id);
- }
-
- this._resetResourceCount();
- this._progressIndicator = new WebInspector.ProgressIndicator();
- this._buttonContainerElement.appendChild(this._progressIndicator.element);
- this._displayResourceLoadingProgress = true;
-
- /**
- * @this {WebInspector.AuditLauncherView}
- */
- function onAuditStarted()
- {
- this._displayResourceLoadingProgress = false;
- }
- this._auditController.initiateAudit(catIds, new WebInspector.ProgressProxy(this._progressIndicator, this._auditsDone.bind(this)), this._auditPresentStateElement.checked, onAuditStarted.bind(this));
- },
-
- _auditsDone: function()
- {
- this._displayResourceLoadingProgress = false;
- delete this._progressIndicator;
- this._launchButton.disabled = false;
- this._auditRunning = false;
- this._updateButton();
- this._toggleUIComponents(this._auditRunning);
- },
+ this._selectedCategoriesSetting =
+ WebInspector.settings.createSetting('selectedAuditCategories', defaultSelectedAuditCategory);
+ }
+
+ _resetResourceCount() {
+ this._loadedResources = 0;
+ this._totalResources = 0;
+ }
+
+ _onRequestStarted(event) {
+ var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);
+ // Ignore long-living WebSockets for the sake of progress indicator, as we won't be waiting them anyway.
+ if (request.resourceType() === WebInspector.resourceTypes.WebSocket)
+ return;
+ ++this._totalResources;
+ this._updateResourceProgress();
+ }
+
+ _onRequestFinished(event) {
+ var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);
+ // See resorceStarted for details.
+ if (request.resourceType() === WebInspector.resourceTypes.WebSocket)
+ return;
+ ++this._loadedResources;
+ this._updateResourceProgress();
+ }
+
+ /**
+ * @param {!WebInspector.AuditCategory} category
+ */
+ addCategory(category) {
+ if (!this._sortedCategories.length)
+ this._createLauncherUI();
+
+ var selectedCategories = this._selectedCategoriesSetting.get();
+ var categoryElement = this._createCategoryElement(category.displayName, category.id);
+ category._checkboxElement = categoryElement.checkboxElement;
+ if (this._selectAllCheckboxElement.checked || selectedCategories[category.displayName]) {
+ category._checkboxElement.checked = true;
+ ++this._currentCategoriesCount;
+ }
/**
- * @param {boolean} disable
+ * @param {!WebInspector.AuditCategory} a
+ * @param {!WebInspector.AuditCategory} b
+ * @return {number}
*/
- _toggleUIComponents: function(disable)
- {
- this._selectAllCheckboxElement.disabled = disable;
- for (var child = this._categoriesElement.firstChild; child; child = child.nextSibling)
- child.checkboxElement.disabled = disable;
- this._auditPresentStateElement.disabled = disable;
- this._auditReloadedStateElement.disabled = disable;
- },
-
- _launchButtonClicked: function(event)
- {
- if (this._auditRunning) {
- this._launchButton.disabled = true;
- this._progressIndicator.cancel();
- return;
- }
- this._startAudit();
- },
-
- _clearButtonClicked: function()
- {
- this._auditController.clearResults();
- },
+ function compareCategories(a, b) {
+ var aTitle = a.displayName || '';
+ var bTitle = b.displayName || '';
+ return aTitle.localeCompare(bTitle);
+ }
+ var insertBefore = this._sortedCategories.lowerBound(category, compareCategories);
+ this._categoriesElement.insertBefore(categoryElement, this._categoriesElement.children[insertBefore]);
+ this._sortedCategories.splice(insertBefore, 0, category);
+ this._selectedCategoriesUpdated();
+ }
+
+ _startAudit() {
+ this._auditRunning = true;
+ this._updateButton();
+ this._toggleUIComponents(this._auditRunning);
+
+ var catIds = [];
+ for (var category = 0; category < this._sortedCategories.length; ++category) {
+ if (this._sortedCategories[category]._checkboxElement.checked)
+ catIds.push(this._sortedCategories[category].id);
+ }
- /**
- * @param {boolean} checkCategories
- * @param {boolean=} userGesture
- */
- _selectAllClicked: function(checkCategories, userGesture)
- {
- var childNodes = this._categoriesElement.childNodes;
- for (var i = 0, length = childNodes.length; i < length; ++i)
- childNodes[i].checkboxElement.checked = checkCategories;
- this._currentCategoriesCount = checkCategories ? this._sortedCategories.length : 0;
- this._selectedCategoriesUpdated(userGesture);
- },
-
- _categoryClicked: function(event)
- {
- this._currentCategoriesCount += event.target.checked ? 1 : -1;
- this._selectAllCheckboxElement.checked = this._currentCategoriesCount === this._sortedCategories.length;
- this._selectedCategoriesUpdated(true);
- },
+ this._resetResourceCount();
+ this._progressIndicator = new WebInspector.ProgressIndicator();
+ this._buttonContainerElement.appendChild(this._progressIndicator.element);
+ this._displayResourceLoadingProgress = true;
/**
- * @param {string} title
- * @param {string=} id
+ * @this {WebInspector.AuditLauncherView}
*/
- _createCategoryElement: function(title, id)
- {
- var labelElement = createCheckboxLabel(title);
- if (id) {
- labelElement.id = this._categoryIdPrefix + id;
- labelElement.checkboxElement.addEventListener("click", this._boundCategoryClickListener, false);
- }
- labelElement.__displayName = title;
-
- return labelElement;
- },
-
- _createLauncherUI: function()
- {
- this._headerElement = createElement("h1");
- this._headerElement.textContent = WebInspector.UIString("Select audits to run");
-
- this._contentElement.removeChildren();
- this._contentElement.appendChild(this._headerElement);
-
- /**
- * @param {!Event} event
- * @this {WebInspector.AuditLauncherView}
- */
- function handleSelectAllClick(event)
- {
- this._selectAllClicked(event.target.checked, true);
- }
- var categoryElement = this._createCategoryElement(WebInspector.UIString("Select All"), "");
- categoryElement.id = "audit-launcher-selectall";
- this._selectAllCheckboxElement = categoryElement.checkboxElement;
- this._selectAllCheckboxElement.checked = this._selectedCategoriesSetting.get()[WebInspector.AuditLauncherView.AllCategoriesKey];
- this._selectAllCheckboxElement.addEventListener("click", handleSelectAllClick.bind(this), false);
- this._contentElement.appendChild(categoryElement);
-
- this._categoriesElement = this._contentElement.createChild("fieldset", "audit-categories-container");
- this._currentCategoriesCount = 0;
-
- this._contentElement.createChild("div", "flexible-space");
-
- this._buttonContainerElement = this._contentElement.createChild("div", "button-container");
-
- var radio = createRadioLabel("audit-mode", WebInspector.UIString("Audit Present State"), true);
- this._buttonContainerElement.appendChild(radio);
- this._auditPresentStateElement = radio.radioElement;
-
- radio = createRadioLabel("audit-mode", WebInspector.UIString("Reload Page and Audit on Load"));
- this._buttonContainerElement.appendChild(radio);
- this._auditReloadedStateElement = radio.radioElement;
-
- this._launchButton = createTextButton(WebInspector.UIString("Run"), this._launchButtonClicked.bind(this));
- this._buttonContainerElement.appendChild(this._launchButton);
-
- this._clearButton = createTextButton(WebInspector.UIString("Clear"), this._clearButtonClicked.bind(this));
- this._buttonContainerElement.appendChild(this._clearButton);
-
- this._selectAllClicked(this._selectAllCheckboxElement.checked);
- },
-
- _updateResourceProgress: function()
- {
- if (this._displayResourceLoadingProgress)
- this._progressIndicator.setTitle(WebInspector.UIString("Loading (%d of %d)", this._loadedResources, this._totalResources));
- },
+ function onAuditStarted() {
+ this._displayResourceLoadingProgress = false;
+ }
+ this._auditController.initiateAudit(
+ catIds, new WebInspector.ProgressProxy(this._progressIndicator, this._auditsDone.bind(this)),
+ this._auditPresentStateElement.checked, onAuditStarted.bind(this));
+ }
+
+ _auditsDone() {
+ this._displayResourceLoadingProgress = false;
+ delete this._progressIndicator;
+ this._launchButton.disabled = false;
+ this._auditRunning = false;
+ this._updateButton();
+ this._toggleUIComponents(this._auditRunning);
+ }
+
+ /**
+ * @param {boolean} disable
+ */
+ _toggleUIComponents(disable) {
+ this._selectAllCheckboxElement.disabled = disable;
+ for (var child = this._categoriesElement.firstChild; child; child = child.nextSibling)
+ child.checkboxElement.disabled = disable;
+ this._auditPresentStateElement.disabled = disable;
+ this._auditReloadedStateElement.disabled = disable;
+ }
+
+ _launchButtonClicked(event) {
+ if (this._auditRunning) {
+ this._launchButton.disabled = true;
+ this._progressIndicator.cancel();
+ return;
+ }
+ this._startAudit();
+ }
+
+ _clearButtonClicked() {
+ this._auditController.clearResults();
+ }
+
+ /**
+ * @param {boolean} checkCategories
+ * @param {boolean=} userGesture
+ */
+ _selectAllClicked(checkCategories, userGesture) {
+ var childNodes = this._categoriesElement.childNodes;
+ for (var i = 0, length = childNodes.length; i < length; ++i)
+ childNodes[i].checkboxElement.checked = checkCategories;
+ this._currentCategoriesCount = checkCategories ? this._sortedCategories.length : 0;
+ this._selectedCategoriesUpdated(userGesture);
+ }
+
+ _categoryClicked(event) {
+ this._currentCategoriesCount += event.target.checked ? 1 : -1;
+ this._selectAllCheckboxElement.checked = this._currentCategoriesCount === this._sortedCategories.length;
+ this._selectedCategoriesUpdated(true);
+ }
+
+ /**
+ * @param {string} title
+ * @param {string=} id
+ */
+ _createCategoryElement(title, id) {
+ var labelElement = createCheckboxLabel(title);
+ if (id) {
+ labelElement.id = this._categoryIdPrefix + id;
+ labelElement.checkboxElement.addEventListener('click', this._boundCategoryClickListener, false);
+ }
+ labelElement.__displayName = title;
+
+ return labelElement;
+ }
+
+ _createLauncherUI() {
+ this._headerElement = createElement('h1');
+ this._headerElement.textContent = WebInspector.UIString('Select audits to run');
+
+ this._contentElement.removeChildren();
+ this._contentElement.appendChild(this._headerElement);
/**
- * @param {boolean=} userGesture
+ * @param {!Event} event
+ * @this {WebInspector.AuditLauncherView}
*/
- _selectedCategoriesUpdated: function(userGesture)
- {
- // Save present categories only upon user gesture to clean up junk from past versions and removed extensions.
- // Do not remove old categories if not handling a user gesture, as there's chance categories will be added
- // later during start-up.
- var selectedCategories = userGesture ? {} : this._selectedCategoriesSetting.get();
- var childNodes = this._categoriesElement.childNodes;
- for (var i = 0, length = childNodes.length; i < length; ++i)
- selectedCategories[childNodes[i].__displayName] = childNodes[i].checkboxElement.checked;
- selectedCategories[WebInspector.AuditLauncherView.AllCategoriesKey] = this._selectAllCheckboxElement.checked;
- this._selectedCategoriesSetting.set(selectedCategories);
- this._updateButton();
- },
-
- _updateButton: function()
- {
- this._launchButton.textContent = this._auditRunning ? WebInspector.UIString("Stop") : WebInspector.UIString("Run");
- this._launchButton.disabled = !this._currentCategoriesCount;
- },
-
- __proto__: WebInspector.VBox.prototype
+ function handleSelectAllClick(event) {
+ this._selectAllClicked(event.target.checked, true);
+ }
+ var categoryElement = this._createCategoryElement(WebInspector.UIString('Select All'), '');
+ categoryElement.id = 'audit-launcher-selectall';
+ this._selectAllCheckboxElement = categoryElement.checkboxElement;
+ this._selectAllCheckboxElement.checked =
+ this._selectedCategoriesSetting.get()[WebInspector.AuditLauncherView.AllCategoriesKey];
+ this._selectAllCheckboxElement.addEventListener('click', handleSelectAllClick.bind(this), false);
+ this._contentElement.appendChild(categoryElement);
+
+ this._categoriesElement = this._contentElement.createChild('fieldset', 'audit-categories-container');
+ this._currentCategoriesCount = 0;
+
+ this._contentElement.createChild('div', 'flexible-space');
+
+ this._buttonContainerElement = this._contentElement.createChild('div', 'button-container');
+
+ var radio = createRadioLabel('audit-mode', WebInspector.UIString('Audit Present State'), true);
+ this._buttonContainerElement.appendChild(radio);
+ this._auditPresentStateElement = radio.radioElement;
+
+ radio = createRadioLabel('audit-mode', WebInspector.UIString('Reload Page and Audit on Load'));
+ this._buttonContainerElement.appendChild(radio);
+ this._auditReloadedStateElement = radio.radioElement;
+
+ this._launchButton = createTextButton(WebInspector.UIString('Run'), this._launchButtonClicked.bind(this));
+ this._buttonContainerElement.appendChild(this._launchButton);
+
+ this._clearButton = createTextButton(WebInspector.UIString('Clear'), this._clearButtonClicked.bind(this));
+ this._buttonContainerElement.appendChild(this._clearButton);
+
+ this._selectAllClicked(this._selectAllCheckboxElement.checked);
+ }
+
+ _updateResourceProgress() {
+ if (this._displayResourceLoadingProgress)
+ this._progressIndicator.setTitle(
+ WebInspector.UIString('Loading (%d of %d)', this._loadedResources, this._totalResources));
+ }
+
+ /**
+ * @param {boolean=} userGesture
+ */
+ _selectedCategoriesUpdated(userGesture) {
+ // Save present categories only upon user gesture to clean up junk from past versions and removed extensions.
+ // Do not remove old categories if not handling a user gesture, as there's chance categories will be added
+ // later during start-up.
+ var selectedCategories = userGesture ? {} : this._selectedCategoriesSetting.get();
+ var childNodes = this._categoriesElement.childNodes;
+ for (var i = 0, length = childNodes.length; i < length; ++i)
+ selectedCategories[childNodes[i].__displayName] = childNodes[i].checkboxElement.checked;
+ selectedCategories[WebInspector.AuditLauncherView.AllCategoriesKey] = this._selectAllCheckboxElement.checked;
+ this._selectedCategoriesSetting.set(selectedCategories);
+ this._updateButton();
+ }
+
+ _updateButton() {
+ this._launchButton.textContent = this._auditRunning ? WebInspector.UIString('Stop') : WebInspector.UIString('Run');
+ this._launchButton.disabled = !this._currentCategoriesCount;
+ }
};
+
+WebInspector.AuditLauncherView.AllCategoriesKey = '__AllCategories';
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698