Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, shans, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not allow using 'this' before call into super. BUG=659389 Committed: https://crrev.com/68c82be4cc282fac442e9785411e7b075fa7e59a Cr-Commit-Position: refs/heads/master@{#427813}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -284 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt-hint.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js View 5 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 4 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js View 1 5 chunks +28 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/EventSourceMessagesView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/BottomUpProfileDataGrid.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js View 4 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 1 5 chunks +33 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseQueryView.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 9 chunks +114 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js View 1 1 chunk +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/ResourceSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 3 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 4 chunks +37 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ContextMenu.js View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 2 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
pfeldman
4 years, 1 month ago (2016-10-26 00:13:19 UTC) #3
dgozman
lgtm! https://codereview.chromium.org/2450663004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2450663004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode102 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:102: if (value.endsWith("\\9")) Unrelated. https://codereview.chromium.org/2450663004/diff/1/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js File third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js (right): https://codereview.chromium.org/2450663004/diff/1/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js#newcode948 ...
4 years, 1 month ago (2016-10-26 00:31:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450663004/1
4 years, 1 month ago (2016-10-26 02:28:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/93830) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-10-26 02:44:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450663004/20001
4 years, 1 month ago (2016-10-26 18:24:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 21:36:48 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:39:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68c82be4cc282fac442e9785411e7b075fa7e59a
Cr-Commit-Position: refs/heads/master@{#427813}

Powered by Google App Engine
This is Rietveld 408576698