third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js - Issue 2450663004: DevTools: do not allow using 'this' before call into super.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)

Patch Set: rebaselined Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js ('k') | third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js

index d519b1a48154f028ed0a777ee04dc33bba5addc8..e827132b4ad9754666fd3e310557735f2cdb7ecd 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js

@@ -192,17 +192,18 @@ WebInspector.FileSystemWorkspaceBinding.fileSystemPath = function(projectId)

WebInspector.FileSystemWorkspaceBinding.FileSystem = function(fileSystemWorkspaceBinding, isolatedFileSystem, workspace)

{

- this._fileSystemWorkspaceBinding = fileSystemWorkspaceBinding;

- this._fileSystem = isolatedFileSystem;

- this._fileSystemBaseURL = this._fileSystem.path() + "/";

- this._fileSystemPath = this._fileSystem.path();

- var id = WebInspector.FileSystemWorkspaceBinding.projectId(this._fileSystemPath);

+ var fileSystemPath = isolatedFileSystem.path();

+ var id = WebInspector.FileSystemWorkspaceBinding.projectId(fileSystemPath);

console.assert(!workspace.project(id));

+ var displayName = fileSystemPath.substr(fileSystemPath.lastIndexOf("/") + 1);

- var displayName = this._fileSystemPath.substr(this._fileSystemPath.lastIndexOf("/") + 1);

WebInspector.ProjectStore.call(this, workspace, id, WebInspector.projectTypes.FileSystem, displayName);

+ this._fileSystem = isolatedFileSystem;

+ this._fileSystemBaseURL = this._fileSystem.path() + "/";

+ this._fileSystemWorkspaceBinding = fileSystemWorkspaceBinding;

+ this._fileSystemPath = fileSystemPath;

workspace.addProject(this);

this.populate();

};