Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
index 12d78806a7477bb2571b1a10e039a19c21e89dd0..966763b21d5411543d1361550533fcedaef49bfb 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
@@ -124,10 +124,9 @@ WebInspector.AXNodeSubPane.prototype = {
*/
WebInspector.AXNodePropertyTreeElement = function(axNode)
{
- this._axNode = axNode;
-
// Pass an empty title, the title gets made later in onattach.
TreeElement.call(this, "");
+ this._axNode = axNode;
};
/**
@@ -295,11 +294,12 @@ WebInspector.AXNodePropertyTreeElement.prototype = {
*/
WebInspector.AXNodePropertyTreePropertyElement = function(property, axNode)
{
+ WebInspector.AXNodePropertyTreeElement.call(this, axNode);
+
this._property = property;
this.toggleOnClick = true;
this.selectable = false;
- WebInspector.AXNodePropertyTreeElement.call(this, axNode);
this.listItemElement.classList.add("property");
};
@@ -336,8 +336,8 @@ WebInspector.AXNodePropertyTreePropertyElement.prototype = {
*/
WebInspector.AXValueSourceTreeElement = function(source, axNode)
{
- this._source = source;
WebInspector.AXNodePropertyTreeElement.call(this, axNode);
+ this._source = source;
this.selectable = false;
};
@@ -515,11 +515,10 @@ WebInspector.AXValueSourceTreeElement.prototype = {
*/
WebInspector.AXRelatedNodeSourceTreeElement = function(node, value)
{
- this._value = value;
- this._axRelatedNodeElement = new WebInspector.AXRelatedNodeElement(node, value);
-
TreeElement.call(this, "");
+ this._value = value;
+ this._axRelatedNodeElement = new WebInspector.AXRelatedNodeElement(node, value);
this.selectable = false;
};
@@ -594,10 +593,9 @@ WebInspector.AXRelatedNodeElement.prototype = {
*/
WebInspector.AXNodeIgnoredReasonTreeElement = function(property, axNode)
{
+ WebInspector.AXNodePropertyTreeElement.call(this, axNode);
this._property = property;
this._axNode = axNode;
-
- WebInspector.AXNodePropertyTreeElement.call(this, axNode);
this.toggleOnClick = true;
this.selectable = false;
};

Powered by Google App Engine
This is Rietveld 408576698