Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
index 0610535e819af42c26346d6b063d4194e11911b5..afba79ef41a31bc38b2aa0289084a2bab05e1eaf 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
@@ -198,9 +198,7 @@ WebInspector.ResourceWebSocketFrameView.prototype = {
*/
WebInspector.ResourceWebSocketFrameNode = function(url, frame)
{
- this._frame = frame;
- this._dataText = frame.text;
- this._url = url;
+ var dataText = frame.text;
var length = frame.text.length;
var time = new Date(frame.time * 1000);
var timeText = ("0" + time.getHours()).substr(-2) + ":" + ("0" + time.getMinutes()).substr(-2) + ":" + ("0" + time.getSeconds()).substr(-2) + "." + ("00" + time.getMilliseconds()).substr(-3);
@@ -208,11 +206,16 @@ WebInspector.ResourceWebSocketFrameNode = function(url, frame)
timeNode.createTextChild(timeText);
timeNode.title = time.toLocaleString();
- this._isTextFrame = frame.opCode === WebInspector.ResourceWebSocketFrameView.OpCodes.TextFrame;
- if (!this._isTextFrame)
- this._dataText = WebInspector.ResourceWebSocketFrameView.opCodeDescription(frame.opCode, frame.mask);
+ var isTextFrame = frame.opCode === WebInspector.ResourceWebSocketFrameView.OpCodes.TextFrame;
+ if (!isTextFrame)
+ dataText = WebInspector.ResourceWebSocketFrameView.opCodeDescription(frame.opCode, frame.mask);
+
+ WebInspector.SortableDataGridNode.call(this, {data: dataText, length: length, time: timeNode});
- WebInspector.SortableDataGridNode.call(this, {data: this._dataText, length: length, time: timeNode});
+ this._url = url;
+ this._frame = frame;
+ this._isTextFrame = isTextFrame;
+ this._dataText = dataText;
};
WebInspector.ResourceWebSocketFrameNode.prototype = {

Powered by Google App Engine
This is Rietveld 408576698