Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 2b35212743407f65fa854c85db7c7fefbccc754d..15b987827bd2dddb780552c5883e9bf3440c074f 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -37,15 +37,14 @@
*/
WebInspector.ElementsTreeOutline = function(domModel, omitRootDOMNode, selectEnabled)
{
+ TreeOutline.call(this);
+
this._domModel = domModel;
this._treeElementSymbol = Symbol("treeElement");
-
- var element = createElement("div");
-
- this._shadowRoot = WebInspector.createShadowRootWithCoreStyles(element, "elements/elementsTreeOutline.css");
+ var shadowContainer = createElement("div");
+ this._shadowRoot = WebInspector.createShadowRootWithCoreStyles(shadowContainer, "elements/elementsTreeOutline.css");
var outlineDisclosureElement = this._shadowRoot.createChild("div", "elements-disclosure");
- TreeOutline.call(this);
this._element = this.element;
this._element.classList.add("elements-tree-outline", "source-code");
this._element.addEventListener("mousedown", this._onmousedown.bind(this), false);
@@ -63,7 +62,7 @@ WebInspector.ElementsTreeOutline = function(domModel, omitRootDOMNode, selectEna
this._element.addEventListener("clipboard-paste", this._onPaste.bind(this), false);
outlineDisclosureElement.appendChild(this._element);
- this.element = element;
+ this.element = shadowContainer;
this._includeRootDOMNode = !omitRootDOMNode;
this._selectEnabled = selectEnabled;
@@ -74,7 +73,8 @@ WebInspector.ElementsTreeOutline = function(domModel, omitRootDOMNode, selectEna
this._visible = false;
- this._popoverHelper = new WebInspector.PopoverHelper(this._element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
+ this._popoverHelper = new WebInspector.PopoverHelper(this._element);
+ this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
this._popoverHelper.setTimeout(0, 100);
/** @type {!Map<!WebInspector.DOMNode, !WebInspector.ElementsTreeOutline.UpdateRecord>} */

Powered by Google App Engine
This is Rietveld 408576698