third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js - Issue 2450663004: DevTools: do not allow using 'this' before call into super.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)

Patch Set: rebaselined Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js ('k') | third_party/WebKit/Source/devtools/front_end/network/EventSourceMessagesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js

diff --git a/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js b/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js

index 7147302cf9e92cfd925e05ee6fbc2606a7f0070d..a39ca70e3197893ff6a40d66221f89a661c62984 100644

--- a/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js

+++ b/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js

@@ -36,13 +36,14 @@

WebInspector.JSHeapSnapshot = function(profile, progress)

{

+ WebInspector.HeapSnapshot.call(this, profile, progress);

this._nodeFlags = { // bit flags

canBeQueried: 1,

detachedDOMTreeNode: 2,

pageObject: 4 // The idea is to track separately the objects owned by the page and the objects owned by debugger.

};

+ this.initialize();

this._lazyStringCache = {};

- WebInspector.HeapSnapshot.call(this, profile, progress);

};

WebInspector.JSHeapSnapshot.prototype = {