third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js - Issue 2450663004: DevTools: do not allow using 'this' before call into super.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)

Patch Set: rebaselined Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

index 94f37d29963960beba28e4894528f1a0772ed8f2..8b2cf88a7bca826cce5332067935f6415fd02c98 100644

--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

@@ -145,7 +145,8 @@ WebInspector.AnimationTimeline.prototype = {

this._updatePlaybackControls();

this._previewContainer = this.contentElement.createChild("div", "animation-timeline-buffer");

- this._popoverHelper = new WebInspector.PopoverHelper(this._previewContainer, this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this), true);

+ this._popoverHelper = new WebInspector.PopoverHelper(this._previewContainer, true);

+ this._popoverHelper.initializeCallbacks(this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));

this._popoverHelper.setTimeout(0);

var emptyBufferHint = this.contentElement.createChild("div", "animation-timeline-buffer-hint");

emptyBufferHint.textContent = WebInspector.UIString("Listening for animations...");