Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/View.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/View.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/View.js b/third_party/WebKit/Source/devtools/front_end/ui/View.js
index 0df956bae0dbb56cb21286f2a0077c570a8721cc..16e365e01996285af00f6b789086cfc0e17d5b23 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/View.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/View.js
@@ -603,11 +603,13 @@ WebInspector.ViewManager._Location.prototype = {
*/
WebInspector.ViewManager._TabbedLocation = function(manager, revealCallback, location, restoreSelection, allowReorder)
{
- this._tabbedPane = new WebInspector.TabbedPane();
+ var tabbedPane = new WebInspector.TabbedPane();
if (allowReorder)
- this._tabbedPane.setAllowTabReorder(true);
+ tabbedPane.setAllowTabReorder(true);
+
+ WebInspector.ViewManager._Location.call(this, manager, tabbedPane, revealCallback);
+ this._tabbedPane = tabbedPane;
this._allowReorder = allowReorder;
- WebInspector.ViewManager._Location.call(this, manager, this._tabbedPane, revealCallback);
this._tabbedPane.addEventListener(WebInspector.TabbedPane.Events.TabSelected, this._tabSelected, this);
this._tabbedPane.addEventListener(WebInspector.TabbedPane.Events.TabClosed, this._tabClosed, this);
@@ -841,8 +843,9 @@ WebInspector.ViewManager._TabbedLocation.prototype = {
*/
WebInspector.ViewManager._StackLocation = function(manager, revealCallback, location)
{
- this._vbox = new WebInspector.VBox();
- WebInspector.ViewManager._Location.call(this, manager, this._vbox, revealCallback);
+ var vbox = new WebInspector.VBox();
+ WebInspector.ViewManager._Location.call(this, manager, vbox, revealCallback);
+ this._vbox = vbox;
/** @type {!Map<string, !WebInspector.ViewManager._ExpandableContainerWidget>} */
this._expandableContainers = new Map();

Powered by Google App Engine
This is Rietveld 408576698