third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2450663004: DevTools: do not allow using 'this' before call into super.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)

Patch Set: rebaselined Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index 339661c82c9d8fdf58df7caee091a1291ad8d61f..d90216ce4fa1d699efb5ec30d8ff634229ec4712 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -99,7 +99,7 @@ WebInspector.StylesSidebarPane.ignoreErrorsForProperty = function(property) {

var value = property.value.toLowerCase();

// IE hack.

- if (value.endsWith("\9"))

+ if (value.endsWith("\\9"))

return true;

if (hasUnknownVendorPrefix(value))

return true;

@@ -2878,7 +2878,8 @@ WebInspector.StylePropertyTreeElement.prototype = {

WebInspector.StylesSidebarPane.CSSPropertyPrompt = function(cssCompletions, treeElement, isEditingName)

{

// Use the same callback both for applyItemCallback and acceptItemCallback.

- WebInspector.TextPrompt.call(this, this._buildPropertyCompletions.bind(this), WebInspector.StyleValueDelimiters);

+ WebInspector.TextPrompt.call(this);

+ this.initialize(this._buildPropertyCompletions.bind(this), WebInspector.StyleValueDelimiters);

this.setSuggestBoxEnabled(true);

this._cssCompletions = cssCompletions;

this._treeElement = treeElement;