Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2450663004: DevTools: do not allow using 'this' before call into super. (Closed)
Patch Set: rebaselined Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index 8a5091ceb7eeca7d96edc0aea8caaeffc9e67e1a..f2112b7affb487b9903172021c880440a7462431 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -403,16 +403,14 @@ WebInspector.SecurityPanel.createCertificateViewerButton2 = function(text, origi
*/
WebInspector.SecurityPanelSidebarTree = function(mainViewElement, showOriginInPanel)
{
- this._showOriginInPanel = showOriginInPanel;
-
- this._mainOrigin = null;
-
TreeOutlineInShadow.call(this);
this.registerRequiredCSS("security/sidebar.css");
this.registerRequiredCSS("security/lockIcon.css");
-
this.appendChild(mainViewElement);
+ this._showOriginInPanel = showOriginInPanel;
+ this._mainOrigin = null;
+
/** @type {!Map<!WebInspector.SecurityPanelSidebarTree.OriginGroupName, !TreeElement>} */
this._originGroups = new Map();
@@ -858,8 +856,8 @@ WebInspector.SecurityMainView.prototype = {
*/
WebInspector.SecurityOriginView = function(panel, origin, originState)
{
- this._panel = panel;
WebInspector.VBox.call(this);
+ this._panel = panel;
this.setMinimumSize(200, 100);
this.element.classList.add("security-origin-view");

Powered by Google App Engine
This is Rietveld 408576698