Rename classes related to top controls

Rename classes related to top controls

This change renames TopControls* to BrowserControls*. This is done
to represent the fact that the toolbar/controls for the browser are
not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/2ee41afd2d4f2b631a0792e10b8b2c9fcc682c83
Cr-Commit-Position: refs/heads/master@{#428054}

[mdjones, 2016-10-21 16:31:48]

Description was changed from

==========
Rename classes related to top controls in CC

This change renames TopControls* in CC to BrowserControls*. This is
done to represent the fact that the toolbar/controls for the browser
are not necessarily at the top of the screen.

BUG=652892
==========

to

==========
Rename classes related to top controls in CC

This change renames TopControls* in CC to BrowserControls*. This is
done to represent the fact that the toolbar/controls for the browser
are not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[mdjones, 2016-10-21 16:37:43]

mdjones@chromium.org changed reviewers:
+ aelias@chromium.org, tedchoc@chromium.org

[mdjones, 2016-10-21 16:37:44]

Was going to do all references to top controls in one cl, but it became grossly
huge. ptal

[vmpstr, 2016-10-21 17:54:57]

vmpstr@chromium.org changed reviewers:
+ vmpstr@chromium.org

[vmpstr, 2016-10-21 17:54:59]

I just noticed your comment that you want to split this up into more patches, so
cc lgtm

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
File cc/input/browser_controls_offset_manager.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
cc/input/browser_controls_offset_manager.h:55: void
UpdateTopControlsState(BrowserControlsState constraints,
nit: UpdateBrowserControlsState

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
File cc/input/browser_controls_offset_manager_client.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
cc/input/browser_controls_offset_manager_client.h:12: class CC_EXPORT
BrowserControlsOffsetManagerClient {
The functions in here should all remain the same, right?

https://codereview.chromium.org/2443613002/diff/1/cc/test/fake_proxy.h
File cc/test/fake_proxy.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/test/fake_proxy.h#newcode41
cc/test/fake_proxy.h:41: void UpdateTopControlsState(BrowserControlsState
constraints,
UpdateBrowserControlsState?

https://codereview.chromium.org/2443613002/diff/1/cc/trees/layer_tree_host_in...
File cc/trees/layer_tree_host_in_process.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/layer_tree_host_in...
cc/trees/layer_tree_host_in_process.h:156: void
UpdateTopControlsState(BrowserControlsState constraints,
UpdateBrowserControlsState?

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy.h
File cc/trees/proxy.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy.h#newcode76
cc/trees/proxy.h:76: virtual void UpdateTopControlsState(BrowserControlsState
constraints,
ditto

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_impl.h
File cc/trees/proxy_impl.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_impl.h#newco...
cc/trees/proxy_impl.h:33: void UpdateTopControlsStateOnImpl(BrowserControlsState
constraints,
dittoOnImpl

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_main.h
File cc/trees/proxy_main.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_main.h#newco...
cc/trees/proxy_main.h:102: void UpdateTopControlsState(BrowserControlsState
constraints,
ditto

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_impl.h
File cc/trees/remote_channel_impl.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_imp...
cc/trees/remote_channel_impl.h:153: void
UpdateTopControlsState(BrowserControlsState constraints,
ditto

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_main.h
File cc/trees/remote_channel_main.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_mai...
cc/trees/remote_channel_main.h:33: void
UpdateTopControlsStateOnImpl(BrowserControlsState constraints,
dittoOnImpl

https://codereview.chromium.org/2443613002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/2443613002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.h:804: BrowserControlsState
top_controls_constraints_;
browser_controls_constraints_?

[aelias_OOO_until_Jul13, 2016-10-21 18:44:21]

Both me and vmpstr@ have spotted a few loose ends and there's probably more
lurking.  Could you run "git grep -i TopControls" and "git grep -i top_controls"
and "git grep -i 'top controls'" post-patch to make sure you've covered every
line in the targeted directories?

https://codereview.chromium.org/2443613002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl_android.cc (right):

https://codereview.chromium.org/2443613002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl_android.cc:40: LOG_IF(WARNING, !compositor_)
<< "OnUpdateTopControlsState was unhandled.";
OnUpdateBrowserControlsState

[aelias_OOO_until_Jul13, 2016-10-21 18:46:40]

Well, OK, anyway, I guess lgtm to stage it in however many patches you want.

[Ted C, 2016-10-21 18:52:49]

lgtm ... one of many :-)

https://codereview.chromium.org/2443613002/diff/1/content/public/common/brows...
File content/public/common/browser_controls_state.h (right):

https://codereview.chromium.org/2443613002/diff/1/content/public/common/brows...
content/public/common/browser_controls_state.h:1: // Copyright (c) 2016 The
Chromium Authors. All rights reserved.
no (c)

[mdjones, 2016-10-21 19:58:56]

On 2016/10/21 18:46:40, aelias wrote:
> Well, OK, anyway, I guess lgtm to stage it in however many patches you want.

Would it be preferred to do this in a single patch? I can certainly do that; top
controls are referenced in ~150 files though.

[aelias_OOO_until_Jul13, 2016-10-21 20:14:02]

On 2016/10/21 at 19:58:56, mdjones wrote:
> On 2016/10/21 18:46:40, aelias wrote:
> > Well, OK, anyway, I guess lgtm to stage it in however many patches you want.
> 
> Would it be preferred to do this in a single patch? I can certainly do that;
top controls are referenced in ~150 files though.

Personally I would prefer a single megapatch -- that would prevent multiple
rounds of conflicts and multiple rounds of getting lgt'm from the same OWNERS.

[mdjones, 2016-10-21 20:26:34]

On 2016/10/21 20:14:02, aelias wrote:
> On 2016/10/21 at 19:58:56, mdjones wrote:
> > On 2016/10/21 18:46:40, aelias wrote:
> > > Well, OK, anyway, I guess lgtm to stage it in however many patches you
want.
> > 
> > Would it be preferred to do this in a single patch? I can certainly do that;
> top controls are referenced in ~150 files though.
> 
> Personally I would prefer a single megapatch -- that would prevent multiple
> rounds of conflicts and multiple rounds of getting lgt'm from the same OWNERS.

Sounds good, I'll do that then.

[mdjones, 2016-10-24 20:16:29]

Description was changed from

==========
Rename classes related to top controls in CC

This change renames TopControls* in CC to BrowserControls*. This is
done to represent the fact that the toolbar/controls for the browser
are not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Rename classes related to top controls

This change renames TopControls* to BrowserControls*. This is done
to represent the fact that the toolbar/controls for the browser are
not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[mdjones, 2016-10-24 21:20:24]

Renamed everything, ptal. Kept "top controls" where it makes sense.

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
File cc/input/browser_controls_offset_manager.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
cc/input/browser_controls_offset_manager.h:55: void
UpdateTopControlsState(BrowserControlsState constraints,
On 2016/10/21 17:54:58, vmpstr wrote:
> nit: UpdateBrowserControlsState

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
File cc/input/browser_controls_offset_manager_client.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/input/browser_controls_o...
cc/input/browser_controls_offset_manager_client.h:12: class CC_EXPORT
BrowserControlsOffsetManagerClient {
On 2016/10/21 17:54:58, vmpstr wrote:
> The functions in here should all remain the same, right?

Right, top and bottom controls can still be explicit in this interface.

https://codereview.chromium.org/2443613002/diff/1/cc/test/fake_proxy.h
File cc/test/fake_proxy.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/test/fake_proxy.h#newcode41
cc/test/fake_proxy.h:41: void UpdateTopControlsState(BrowserControlsState
constraints,
On 2016/10/21 17:54:58, vmpstr wrote:
> UpdateBrowserControlsState?

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/trees/layer_tree_host_in...
File cc/trees/layer_tree_host_in_process.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/layer_tree_host_in...
cc/trees/layer_tree_host_in_process.h:156: void
UpdateTopControlsState(BrowserControlsState constraints,
On 2016/10/21 17:54:58, vmpstr wrote:
> UpdateBrowserControlsState?

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy.h
File cc/trees/proxy.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy.h#newcode76
cc/trees/proxy.h:76: virtual void UpdateTopControlsState(BrowserControlsState
constraints,
On 2016/10/21 17:54:58, vmpstr wrote:
> ditto

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_impl.h
File cc/trees/proxy_impl.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_impl.h#newco...
cc/trees/proxy_impl.h:33: void UpdateTopControlsStateOnImpl(BrowserControlsState
constraints,
On 2016/10/21 17:54:58, vmpstr wrote:
> dittoOnImpl

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_main.h
File cc/trees/proxy_main.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/proxy_main.h#newco...
cc/trees/proxy_main.h:102: void UpdateTopControlsState(BrowserControlsState
constraints,
On 2016/10/21 17:54:59, vmpstr wrote:
> ditto

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_impl.h
File cc/trees/remote_channel_impl.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_imp...
cc/trees/remote_channel_impl.h:153: void
UpdateTopControlsState(BrowserControlsState constraints,
On 2016/10/21 17:54:59, vmpstr wrote:
> ditto

Done.

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_main.h
File cc/trees/remote_channel_main.h (right):

https://codereview.chromium.org/2443613002/diff/1/cc/trees/remote_channel_mai...
cc/trees/remote_channel_main.h:33: void
UpdateTopControlsStateOnImpl(BrowserControlsState constraints,
On 2016/10/21 17:54:59, vmpstr wrote:
> dittoOnImpl

Done.

[mdjones, 2016-10-24 21:21:21]

mdjones@chromium.org changed reviewers:
+ esprehn@chromium.org

[mdjones, 2016-10-24 21:21:23]

+esprehn for third_party/WebKit

[esprehn, 2016-10-24 21:22:31]

lgtm

[mdjones, 2016-10-24 21:41:13]

mdjones@chromium.org changed reviewers:
+ jam@chromium.org

[mdjones, 2016-10-24 21:41:14]

+jam for owners on:
chrome/browser/ui
chrome/common
chrome/renderer
content/common
content/public/renderer
content/public/test

[jam, 2016-10-25 00:25:00]

lgtm

[aelias_OOO_until_Jul13, 2016-10-26 21:46:56]

Still lgtm

[mdjones, 2016-10-26 23:46:40]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-10-26 23:46:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, vmpstr@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2443613002/#ps80001
(title: "nit")

[commit-bot: I haz the power, 2016-10-26 23:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 23:47:27]

This CL has an open dependency (Issue 2442473002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[mdjones, 2016-10-26 23:53:39]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-10-26 23:53:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, aelias@chromium.org, esprehn@chromium.org,
jam@chromium.org, vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2443613002/#ps100001
(title: "rebase off manager change")

[commit-bot: I haz the power, 2016-10-26 23:54:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 23:59:35]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mdjones, 2016-10-27 00:31:34]

The CQ bit was checked by mdjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 00:32:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:59:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mdjones, 2016-10-27 01:28:17]

The CQ bit was checked by mdjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 01:28:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 03:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 03:12:06]

Dry run: This issue passed the CQ dry run.

[mdjones, 2016-10-27 15:27:28]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-10-27 15:27:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, aelias@chromium.org, esprehn@chromium.org,
jam@chromium.org, vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2443613002/#ps140001
(title: "fix test")

[commit-bot: I haz the power, 2016-10-27 15:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:37:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mdjones, 2016-10-27 15:41:00]

mdjones@chromium.org changed reviewers:
+ tsepez@chromium.org

[mdjones, 2016-10-27 15:41:02]

+tsepez for *_messages.h

[Tom Sepez, 2016-10-27 16:31:00]

RS LGTM on renaming in messages.h

[mdjones, 2016-10-27 16:41:41]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-10-27 16:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:50:47]

Description was changed from

==========
Rename classes related to top controls

This change renames TopControls* to BrowserControls*. This is done
to represent the fact that the toolbar/controls for the browser are
not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Rename classes related to top controls

This change renames TopControls* to BrowserControls*. This is done
to represent the fact that the toolbar/controls for the browser are
not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-27 16:50:49]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-27 16:59:23]

Description was changed from

==========
Rename classes related to top controls

This change renames TopControls* to BrowserControls*. This is done
to represent the fact that the toolbar/controls for the browser are
not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Rename classes related to top controls

This change renames TopControls* to BrowserControls*. This is done
to represent the fact that the toolbar/controls for the browser are
not necessarily at the top of the screen.

BUG=652892
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/2ee41afd2d4f2b631a0792e10b8b2c9fcc682c83
Cr-Commit-Position: refs/heads/master@{#428054}
==========

[commit-bot: I haz the power, 2016-10-27 16:59:25]

Patchset 8 (id:??) landed as
https://crrev.com/2ee41afd2d4f2b631a0792e10b8b2c9fcc682c83
Cr-Commit-Position: refs/heads/master@{#428054}

[mdjones, 2016-11-01 22:29:13]

TopControlsManager changes that accidentally made it into this patch reverted
here: https://codereview.chromium.org/2473583002/