Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.h

Issue 2443613002: Rename classes related to top controls (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/VisualViewport.h
diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.h b/third_party/WebKit/Source/core/frame/VisualViewport.h
index be039c3e231ae59eba6c073ea4dbf9a2ecf938fb..ecea469375d593480342db5d6563df560f7d1321 100644
--- a/third_party/WebKit/Source/core/frame/VisualViewport.h
+++ b/third_party/WebKit/Source/core/frame/VisualViewport.h
@@ -140,13 +140,13 @@ class CORE_EXPORT VisualViewport final
IntPoint clampDocumentOffsetAtScale(const IntPoint& offset, float scale);
// FIXME: This is kind of a hack. Ideally, we would just resize the
- // viewports to account for top controls. However, FrameView includes much
+ // viewports to account for browser controls. However, FrameView includes much
// more than just scrolling so we can't simply resize it without incurring
// all sorts of side-effects. Until we can seperate out the scrollability
// aspect from FrameView, we use this method to let VisualViewport make the
// necessary adjustments so that we don't incorrectly clamp scroll offsets
// coming from the compositor. crbug.com/422328
- void setTopControlsAdjustment(float);
+ void setBrowserControlsAdjustment(float);
// Adjust the viewport's offset so that it remains bounded by the outer
// viepwort.
@@ -264,7 +264,7 @@ class CORE_EXPORT VisualViewport final
ScrollOffset m_offset;
float m_scale;
IntSize m_size;
- float m_topControlsAdjustment;
+ float m_browserControlsAdjustment;
float m_maxPageScale;
bool m_trackPinchZoomStatsForPage;
};
« no previous file with comments | « third_party/WebKit/Source/core/frame/TopControls.cpp ('k') | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698