Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java

Issue 2443613002: Rename classes related to top controls (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
index 1bff649e643e054c849f3798a4f88e6c4ffdb46f..d83ec64e09761e556f06bfa10fa12f6787b89b67 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java
@@ -143,8 +143,8 @@ public class ReaderModePanel extends OverlayPanel {
@Override
public boolean updateOverlay(long time, long dt) {
// This will cause the ContentViewCore to size itself appropriately for the panel (includes
- // top controls height).
- updateTopControlsState();
+ // browser controls height).
+ updateBrowserControlsState();
return super.updateOverlay(time, dt);
}
@@ -307,9 +307,9 @@ public class ReaderModePanel extends OverlayPanel {
// Do not attempt to auto-hide the reader mode bar if the toolbar is less than a certain
// height.
boolean shouldAutoHide = getToolbarHeight() >= getBarHeightPeeking();
- // This will cause the reader mode bar to behave like the top controls; sliding out of
+ // This will cause the reader mode bar to behave like the browser controls; sliding out of
// view as the page scrolls.
- return super.getOffsetY() + (shouldAutoHide ? getTopControlsOffsetDp() : 0.0f);
+ return super.getOffsetY() + (shouldAutoHide ? getBrowserControlsOffsetDp() : 0.0f);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698