Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java

Issue 2443613002: Rename classes related to top controls (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java
index feec82bf1380b3ba19051230b2c56b6137079f78..47d7bbc041b5195cc888de4b98284a7004546996 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java
@@ -45,12 +45,12 @@ public abstract class FullscreenManager {
}
/**
- * Trigger a temporary showing of the top controls.
+ * Trigger a temporary showing of the browser controls.
*/
public abstract void showControlsTransient();
/**
- * Trigger a permanent showing of the top controls until requested otherwise.
+ * Trigger a permanent showing of the browser controls until requested otherwise.
*
* @return The token that determines whether the requester still needs persistent controls to
* be present on the screen.
@@ -68,16 +68,16 @@ public abstract class FullscreenManager {
public abstract int showControlsPersistentAndClearOldToken(int oldToken);
/**
- * Notify the manager that the top controls are no longer required for the given token.
+ * Notify the manager that the browser controls are no longer required for the given token.
*
* @param token The fullscreen token returned from {@link #showControlsPersistent()}.
*/
public abstract void hideControlsPersistent(int token);
/**
- * @return The height of the top controls in pixels.
+ * @return The height of the browser controls in pixels.
*/
- public abstract int getTopControlsHeight();
+ public abstract int getBrowserControlsHeight();
/**
* @return The offset of the content from the top of the screen.
@@ -100,16 +100,16 @@ public abstract class FullscreenManager {
}
/**
- * Updates the positions of the top controls and content to the default non fullscreen
+ * Updates the positions of the browser controls and content to the default non fullscreen
* values.
*/
public abstract void setPositionsForTabToNonFullscreen();
/**
- * Updates the positions of the top controls and content based on the desired position of
+ * Updates the positions of the browser controls and content based on the desired position of
* the current tab.
*
- * @param controlsOffset The Y offset of the top controls.
+ * @param controlsOffset The Y offset of the browser controls.
* @param contentOffset The Y offset for the content.
*/
public abstract void setPositionsForTab(float controlsOffset, float contentOffset);
@@ -143,7 +143,7 @@ public abstract class FullscreenManager {
}
/**
- * Enters or exits persistent fullscreen mode. In this mode, the top controls will be
+ * Enters or exits persistent fullscreen mode. In this mode, the browser controls will be
* permanently hidden until this mode is exited.
*
* @param enabled Whether to enable persistent fullscreen mode.

Powered by Google App Engine
This is Rietveld 408576698