third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp - Issue 2443613002: Rename classes related to top controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

Issue 2443613002: Rename classes related to top controls (Closed)

Patch Set: fix test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h ('k') | third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

index a30490f1c65d86fe91f248096ea91f975cd33ec7..5d6d6d3fb280d241804e343a125a07cfdbfc5af3 100644

--- a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

@@ -81,7 +81,7 @@ void TopDocumentRootScrollerController::recomputeGlobalRootScroller() {

m_globalRootScroller->removeApplyScroll();

// Use disable-native-scroll since the ViewportScrollCallback needs to

- // apply scroll actions both before (TopControls) and after (overscroll)

+ // apply scroll actions both before (BrowserControls) and after (overscroll)

// scrolling the element so it will apply scroll to the element itself.

target->setApplyScroll(m_viewportApplyScroll, "disable-native-scroll");

@@ -146,7 +146,7 @@ void TopDocumentRootScrollerController::initializeViewportScrollCallback(

RootFrameViewport& rootFrameViewport) {

DCHECK(m_frameHost);

m_viewportApplyScroll = ViewportScrollCallback::create(

- &m_frameHost->topControls(), &m_frameHost->overscrollController(),

+ &m_frameHost->browserControls(), &m_frameHost->overscrollController(),

rootFrameViewport);

recomputeGlobalRootScroller();