Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5195)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java

Issue 2443613002: Rename classes related to top controls (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
index 49e70b71268a9ce537eff03ef2a80303069fab37..6979658884d838fb32eff88c5541938f46a7bd54 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/SceneOverlay.java
@@ -22,7 +22,7 @@ public interface SceneOverlay {
*
* @param layerTitleCache A layer title cache.
* @param resourceManager A resource manager.
- * @param yOffset Current top controls offset in dp.
+ * @param yOffset Current browser controls offset in dp.
* @return A {@link SceneOverlayLayer} that represents an scene overlay.
* Or {@code null} if this {@link SceneOverlay} doesn't have a tree.
*/
@@ -56,9 +56,9 @@ public interface SceneOverlay {
void getVirtualViews(List<VirtualView> views);
/**
- * @return True if the overlay requires the Android top controls view to be hidden.
+ * @return True if the overlay requires the Android browser controls view to be hidden.
*/
- boolean shouldHideAndroidTopControls();
+ boolean shouldHideAndroidBrowserControls();
/**
* Helper-specific updates. Cascades the values updated by the animations and flings.

Powered by Google App Engine
This is Rietveld 408576698