Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4795)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

Issue 2443613002: Rename classes related to top controls (Closed)
Patch Set: fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
index f00badd6bb06a43cb73f6dcd76923bd41bbaf678..95cd066613d967cd51fd906223f9eef5cb352404 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
@@ -15,12 +15,12 @@ import org.chromium.chrome.browser.contextmenu.ChromeContextMenuPopulator;
import org.chromium.chrome.browser.contextmenu.ContextMenuPopulator;
import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;
import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler;
+import org.chromium.chrome.browser.tab.BrowserControlsVisibilityDelegate;
import org.chromium.chrome.browser.tab.InterceptNavigationDelegateImpl;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabContextMenuItemDelegate;
import org.chromium.chrome.browser.tab.TabDelegateFactory;
import org.chromium.chrome.browser.tab.TabWebContentsDelegateAndroid;
-import org.chromium.chrome.browser.tab.TopControlsVisibilityDelegate;
import org.chromium.chrome.browser.util.IntentUtils;
import org.chromium.chrome.browser.util.UrlUtilities;
@@ -136,26 +136,26 @@ public class CustomTabDelegateFactory extends TabDelegateFactory {
}
}
- private final boolean mShouldHideTopControls;
+ private final boolean mShouldHideBrowserControls;
private final boolean mIsOpenedByChrome;
private ExternalNavigationDelegateImpl mNavigationDelegate;
private ExternalNavigationHandler mNavigationHandler;
/**
- * @param shouldHideTopControls Whether or not the top controls may auto-hide.
+ * @param shouldHideBrowserControls Whether or not the browser controls may auto-hide.
*/
- public CustomTabDelegateFactory(boolean shouldHideTopControls, boolean isOpenedByChrome) {
- mShouldHideTopControls = shouldHideTopControls;
+ public CustomTabDelegateFactory(boolean shouldHideBrowserControls, boolean isOpenedByChrome) {
+ mShouldHideBrowserControls = shouldHideBrowserControls;
mIsOpenedByChrome = isOpenedByChrome;
}
@Override
- public TopControlsVisibilityDelegate createTopControlsVisibilityDelegate(Tab tab) {
- return new TopControlsVisibilityDelegate(tab) {
+ public BrowserControlsVisibilityDelegate createBrowserControlsVisibilityDelegate(Tab tab) {
+ return new BrowserControlsVisibilityDelegate(tab) {
@Override
- public boolean isHidingTopControlsEnabled() {
- return mShouldHideTopControls && super.isHidingTopControlsEnabled();
+ public boolean isHidingBrowserControlsEnabled() {
+ return mShouldHideBrowserControls && super.isHidingBrowserControlsEnabled();
}
};
}

Powered by Google App Engine
This is Rietveld 408576698