Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2392543003: reflow comments in platform/geometry (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
pdr., dcheng
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in platform/geometry BUG=563793 Committed: https://crrev.com/bdb1f4d6e4c48f96807ca2e20ae1edf1edffa071 Cr-Commit-Position: refs/heads/master@{#422498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -113 lines) Patch
M third_party/WebKit/Source/platform/geometry/FloatBoxTest.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatBoxTestHelpers.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatBoxTestHelpers.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPoint.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPoint3D.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPoint3D.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPolygon.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPolygon.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPolygonTest.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatQuad.h View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatQuad.cpp View 5 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRect.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h View 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRoundedRectTest.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntRect.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntSize.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRect.h View 4 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/Region.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/RegionTest.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/TransformState.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/TransformState.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/cg/IntSizeCG.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/mac/FloatPointMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/mac/FloatSizeMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/mac/IntPointMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/mac/IntRectMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/mac/IntSizeMac.mm View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
4 years, 2 months ago (2016-10-03 17:45:47 UTC) #2
pdr.
On 2016/10/03 at 17:45:47, thakis wrote: > LGTM, TYVM!
4 years, 2 months ago (2016-10-03 19:34:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392543003/1
4 years, 2 months ago (2016-10-03 19:38:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:52:51 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:57:37 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bdb1f4d6e4c48f96807ca2e20ae1edf1edffa071
Cr-Commit-Position: refs/heads/master@{#422498}

Powered by Google App Engine
This is Rietveld 408576698