Moved zones and zone related stuff in its own directory.

Moved zones and zone related stuff in its own directory.

This is some initial cleanup to keep /src clean. The
AccountingAllocator is actually exclusively used by zones and this
common subfolder makes that more clear.

BUG=v8:5409
Committed: https://crrev.com/7a4f8e4d83d4faa36ec8f09683eee3ed9459221b
Cr-Commit-Position: refs/heads/master@{#39558}

[heimbuef, 2016-09-16 12:52:36]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 12:52:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[heimbuef, 2016-09-16 12:52:44]

Patchset #1 (id:1) has been deleted

[heimbuef, 2016-09-16 13:07:53]

heimbuef@google.com changed reviewers:
+ jochen@chromium.org

[heimbuef, 2016-09-16 13:07:54]

PTAL

[jochen (gone - plz use gerrit), 2016-09-16 13:14:52]

should zonepool also go into that directory? I don't own all of the files btw..

https://codereview.chromium.org/2344143003/diff/10001/src/zone/accounting-all...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/10001/src/zone/accounting-all...
src/zone/accounting-allocator.h:5: #ifndef V8_BASE_ACCOUNTING_ALLOCATOR_H_
please update this to V8_SRC_ZONE_ACCOUNTING...

https://codereview.chromium.org/2344143003/diff/10001/src/zone/zone-allocator.h
File src/zone/zone-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/10001/src/zone/zone-allocator...
src/zone/zone-allocator.h:6: #define V8_ZONE_ALLOCATOR_H_
same here (and all files you've moved)

[commit-bot: I haz the power, 2016-09-16 13:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 13:27:58]

Dry run: This issue passed the CQ dry run.

[heimbuef, 2016-09-16 13:38:36]

Patchset #2 (id:30001) has been deleted

[heimbuef, 2016-09-16 13:43:02]

heimbuef@google.com changed reviewers:
+ bmeurer@chromium.org, marja@chromium.org, rossberg@chromium.org,
titzer@chromium.org

[heimbuef, 2016-09-16 13:43:03]

PTAL

[heimbuef, 2016-09-16 13:49:53]

https://codereview.chromium.org/2344143003/diff/10001/src/zone/accounting-all...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/10001/src/zone/accounting-all...
src/zone/accounting-allocator.h:5: #ifndef V8_BASE_ACCOUNTING_ALLOCATOR_H_
On 2016/09/16 13:14:52, jochen wrote:
> please update this to V8_SRC_ZONE_ACCOUNTING...

Done.

https://codereview.chromium.org/2344143003/diff/10001/src/zone/zone-allocator.h
File src/zone/zone-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/10001/src/zone/zone-allocator...
src/zone/zone-allocator.h:6: #define V8_ZONE_ALLOCATOR_H_
On 2016/09/16 13:14:52, jochen wrote:
> same here (and all files you've moved)

Done.

[adamk, 2016-09-16 21:14:37]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-09-16 21:14:38]

Please mention why in the CL description (or better yet link to a tracking bug
if this is related to some larger project).

[marja, 2016-09-19 08:05:12]

https://codereview.chromium.org/2344143003/diff/50001/src/compiler/live-range...
File src/compiler/live-range-separator.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/compiler/live-range...
src/compiler/live-range-separator.h:8: #include <src/zone/zone.h>
It's weird that this uses the < > style! You could fix that in this CL since
you're anyway modifying this line.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/accounting-all...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/accounting-all...
src/zone/accounting-allocator.h:5: #ifndef V8_SRC_ZONE_ACCOUNTING_ALLOCATOR_H_
Style: no SRC here

https://codereview.chromium.org/2344143003/diff/50001/src/zone/accounting-all...
src/zone/accounting-allocator.h:41: #endif  // V8_BASE_ACCOUNTING_ALLOCATOR_H_
You need to update these comments too

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-allocator.h
File src/zone/zone-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-allocator...
src/zone/zone-allocator.h:5: #ifndef V8_SRC_ZONE_ZONE_ALLOCATOR_H_
Ditto

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-allocator...
src/zone/zone-allocator.h:75: #endif  // V8_ZONE_ALLOCATOR_H_
Ditto

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-segment.h
File src/zone/zone-segment.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-segment.h...
src/zone/zone-segment.h:4: 
You need include guards here too

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone.h
File src/zone/zone.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone.h#newcode5
src/zone/zone.h:5: #ifndef V8_SRC_ZONE_ZONE_H_
Ditto

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone.h#newcode66
src/zone/zone.h:66: friend class SegmentPool;
Hmm, what? Is this CL based on some other CL and cannot be landed as is?

https://codereview.chromium.org/2344143003/diff/50001/test/unittests/test-uti...
File test/unittests/test-utils.h (right):

https://codereview.chromium.org/2344143003/diff/50001/test/unittests/test-uti...
test/unittests/test-utils.h:11: #include "src/zone/zone.h"
Here you should include the accounting allocator too

[heimbuef, 2016-09-19 08:06:12]

Description was changed from

==========
Moved zones and zone related stuff in its own directory.

BUG=
==========

to

==========
Moved zones and zone related stuff in its own directory. This is a preparation
for the zone segment pooling in https://codereview.chromium.org/2335343007 and
the zone segment alignment in https://codereview.chromium.org/2299753002/.
==========

[marja, 2016-09-19 08:07:58]

Ha, I noticed jochen@ instructed you to use V8_SRC_ZONE_... in the include
guard. However, he's wrong ;) (see git grep "#ifndef V8_" )

[heimbuef, 2016-09-19 10:47:52]

PTAL

https://codereview.chromium.org/2344143003/diff/50001/src/compiler/live-range...
File src/compiler/live-range-separator.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/compiler/live-range...
src/compiler/live-range-separator.h:8: #include <src/zone/zone.h>
On 2016/09/19 08:05:11, marja wrote:
> It's weird that this uses the < > style! You could fix that in this CL since
> you're anyway modifying this line.

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/accounting-all...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/accounting-all...
src/zone/accounting-allocator.h:5: #ifndef V8_SRC_ZONE_ACCOUNTING_ALLOCATOR_H_
On 2016/09/19 08:05:11, marja wrote:
> Style: no SRC here

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/accounting-all...
src/zone/accounting-allocator.h:5: #ifndef V8_SRC_ZONE_ACCOUNTING_ALLOCATOR_H_
On 2016/09/19 08:05:11, marja wrote:
> Style: no SRC here

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-allocator.h
File src/zone/zone-allocator.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-allocator...
src/zone/zone-allocator.h:5: #ifndef V8_SRC_ZONE_ZONE_ALLOCATOR_H_
On 2016/09/19 08:05:11, marja wrote:
> Ditto

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-allocator...
src/zone/zone-allocator.h:75: #endif  // V8_ZONE_ALLOCATOR_H_
On 2016/09/19 08:05:11, marja wrote:
> Ditto

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-segment.h
File src/zone/zone-segment.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone-segment.h...
src/zone/zone-segment.h:4: 
On 2016/09/19 08:05:11, marja wrote:
> You need include guards here too

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone.h
File src/zone/zone.h (right):

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone.h#newcode5
src/zone/zone.h:5: #ifndef V8_SRC_ZONE_ZONE_H_
On 2016/09/19 08:05:11, marja wrote:
> Ditto

Done.

https://codereview.chromium.org/2344143003/diff/50001/src/zone/zone.h#newcode66
src/zone/zone.h:66: friend class SegmentPool;
On 2016/09/19 08:05:11, marja wrote:
> Hmm, what? Is this CL based on some other CL and cannot be landed as is?

Removed.

https://codereview.chromium.org/2344143003/diff/50001/test/unittests/test-uti...
File test/unittests/test-utils.h (right):

https://codereview.chromium.org/2344143003/diff/50001/test/unittests/test-uti...
test/unittests/test-utils.h:11: #include "src/zone/zone.h"
On 2016/09/19 08:05:11, marja wrote:
> Here you should include the accounting allocator too

Done.

[marja, 2016-09-19 10:49:46]

adamk@ suggested a tracking bug; I think it makes sense, pls file one at
https://bugs.chromium.org/p/v8/issues/list (assign to yourself) and add
BUG=v8:number to the description.

[marja, 2016-09-19 10:56:50]

lgtm with comment (which means I trust you to fix it before landing).

You'll also need to wait for OWNERS reviews.

https://codereview.chromium.org/2344143003/diff/70001/src/zone/zone.h
File src/zone/zone.h (right):

https://codereview.chromium.org/2344143003/diff/70001/src/zone/zone.h#newcode240
src/zone/zone.h:240: #endif  // V8_ZONE_H_
You need to update this too

[titzer, 2016-09-19 14:19:26]

lgtm

[heimbuef, 2016-09-19 14:36:41]

Description was changed from

==========
Moved zones and zone related stuff in its own directory. This is a preparation
for the zone segment pooling in https://codereview.chromium.org/2335343007 and
the zone segment alignment in https://codereview.chromium.org/2299753002/.
==========

to

==========
Moved zones and zone related stuff in its own directory. 

This is a preparation for the zone segment pooling in
https://codereview.chromium.org/2335343007 and the zone segment alignment in
https://codereview.chromium.org/2299753002/.
==========

[jochen (gone - plz use gerrit), 2016-09-19 14:37:28]

yeah, sorry about the wrong header guard...

anyways, why not also move ZonePool?

please also format the CL description according to
chromium.org/developers/contributing-code#Writing_change_list_descriptions

[Benedikt Meurer, 2016-09-20 03:27:31]

From the CL description it's not clear why it's beneficial or necessary
to move those files. Please update the description to include a few
sentences outlining the plan behind this (not just pointing to other CLs).

[heimbuef, 2016-09-20 08:34:32]

On 2016/09/19 at 14:37:28, jochen wrote:
> yeah, sorry about the wrong header guard...
> 
> anyways, why not also move ZonePool?
> 
> please also format the CL description according to
chromium.org/developers/contributing-code#Writing_change_list_descriptions

The ZonePool is collecting stats about the compiler and is not meant for public
use. I change it in another CL to not actually pool any more and renamed it
accordingly.

[heimbuef, 2016-09-20 08:38:28]

Description was changed from

==========
Moved zones and zone related stuff in its own directory. 

This is a preparation for the zone segment pooling in
https://codereview.chromium.org/2335343007 and the zone segment alignment in
https://codereview.chromium.org/2299753002/.
==========

to

==========
Moved zones and zone related stuff in its own directory.

This is some initial cleanup to keep /src clean. The
AccountingAllocator is actually exclusively used by zones and this
common subfolder makes that more clear.
==========

[Benedikt Meurer, 2016-09-20 09:03:30]

LGTM.

[jochen (gone - plz use gerrit), 2016-09-20 09:42:42]

lgtm

please reference the tracking bug from the CL description

[heimbuef, 2016-09-20 12:08:14]

Description was changed from

==========
Moved zones and zone related stuff in its own directory.

This is some initial cleanup to keep /src clean. The
AccountingAllocator is actually exclusively used by zones and this
common subfolder makes that more clear.
==========

to

==========
Moved zones and zone related stuff in its own directory.

This is some initial cleanup to keep /src clean. The
AccountingAllocator is actually exclusively used by zones and this
common subfolder makes that more clear.

BUG=v8:5409
==========

[heimbuef, 2016-09-20 13:04:39]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-09-20 13:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org,
titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2344143003/#ps90001
(title: "Fixing conflicts with master")

[commit-bot: I haz the power, 2016-09-20 13:04:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:10:57]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24487)

[heimbuef, 2016-09-20 13:27:01]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 13:27:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:06:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:06:04]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-20 14:16:47]

https://codereview.chromium.org/2344143003/diff/110001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2344143003/diff/110001/src/v8.gyp#newcode1271
src/v8.gyp:1271: 'src/zone/zone-segment.h',
omit src/

[heimbuef, 2016-09-20 14:23:52]

Patchset #5 (id:110001) has been deleted

[heimbuef, 2016-09-20 14:24:25]

On 2016/09/20 at 14:16:47, jochen wrote:
> https://codereview.chromium.org/2344143003/diff/110001/src/v8.gyp
> File src/v8.gyp (right):
> 
> https://codereview.chromium.org/2344143003/diff/110001/src/v8.gyp#newcode1271
> src/v8.gyp:1271: 'src/zone/zone-segment.h',
> omit src/

Done.

[heimbuef, 2016-09-20 14:24:35]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-09-20 14:24:36]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
bmeurer@chromium.org, marja@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2344143003/#ps130001
(title: "Fixed build files")

[commit-bot: I haz the power, 2016-09-20 14:24:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:26:56]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/13090)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[heimbuef, 2016-09-20 15:37:03]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-09-20 15:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
bmeurer@chromium.org, marja@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2344143003/#ps150001
(title: "Merge branch 'master' into zonefolder")

[commit-bot: I haz the power, 2016-09-20 15:37:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:07:35]

Committed patchset #6 (id:150001)

[commit-bot: I haz the power, 2016-09-20 16:08:16]

Description was changed from

==========
Moved zones and zone related stuff in its own directory.

This is some initial cleanup to keep /src clean. The
AccountingAllocator is actually exclusively used by zones and this
common subfolder makes that more clear.

BUG=v8:5409
==========

to

==========
Moved zones and zone related stuff in its own directory.

This is some initial cleanup to keep /src clean. The
AccountingAllocator is actually exclusively used by zones and this
common subfolder makes that more clear.

BUG=v8:5409

Committed: https://crrev.com/7a4f8e4d83d4faa36ec8f09683eee3ed9459221b
Cr-Commit-Position: refs/heads/master@{#39558}
==========

[commit-bot: I haz the power, 2016-09-20 16:08:18]

Patchset 6 (id:??) landed as
https://crrev.com/7a4f8e4d83d4faa36ec8f09683eee3ed9459221b
Cr-Commit-Position: refs/heads/master@{#39558}