Pool implementation for zone segments

Pool implementation for zone segments

BUG=v8:5409
Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6
Committed: https://crrev.com/f29f3e320831f7eec8703b083dbbb91d88c65dca
Cr-Original-Original-Commit-Position: refs/heads/master@{#39631}
Cr-Original-Commit-Position: refs/heads/master@{#40044}
Cr-Commit-Position: refs/heads/master@{#40137}

[heimbuef, 2016-09-15 11:02:28]

Patchset #1 (id:1) has been deleted

[heimbuef, 2016-09-15 11:02:51]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 11:03:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:04:54]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8934)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24143)

[heimbuef, 2016-09-15 11:11:43]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 11:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:14:47]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12816)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[heimbuef, 2016-09-15 11:17:20]

Patchset #1 (id:20001) has been deleted

[heimbuef, 2016-09-15 11:17:32]

Patchset #1 (id:40001) has been deleted

[heimbuef, 2016-09-15 11:17:42]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 11:17:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:20:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:20:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8937)

[heimbuef, 2016-09-15 11:33:07]

Patchset #1 (id:60001) has been deleted

[heimbuef, 2016-09-15 11:33:20]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 11:33:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:43:43]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[heimbuef, 2016-09-15 12:06:50]

Patchset #1 (id:80001) has been deleted

[heimbuef, 2016-09-15 12:12:26]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 12:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 12:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 12:17:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/14369)

[heimbuef, 2016-09-15 12:28:27]

Patchset #1 (id:100001) has been deleted

[heimbuef, 2016-09-15 12:28:39]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 12:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 12:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 12:31:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12828)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12818)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8949)

[heimbuef, 2016-09-15 12:38:17]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[heimbuef, 2016-09-15 12:38:22]

Patchset #1 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-09-15 12:38:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 12:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 12:44:17]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)

[heimbuef, 2016-09-15 15:15:24]

heimbuef@google.com changed reviewers:
+ jochen@chromium.org

[heimbuef, 2016-09-15 15:15:26]

PTAL

[jochen (gone - plz use gerrit), 2016-09-15 19:23:22]

hum, so it looks like you post task from a background thread. that's currently
not supported, you can only post tasks to the background threads from the
foreground thread :-/

[jochen (gone - plz use gerrit), 2016-09-15 19:25:14]

jochen@chromium.org changed reviewers:
+ jkummerow@chromium.org, verwaest@chromium.org

[heimbuef, 2016-09-19 14:27:33]

Patchset #2 (id:160001) has been deleted

[heimbuef, 2016-09-19 14:27:41]

Patchset #1 (id:140001) has been deleted

[heimbuef, 2016-09-20 10:56:49]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 10:56:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 11:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 11:03:29]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9212)

[heimbuef, 2016-09-20 11:56:39]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[heimbuef, 2016-09-20 11:56:58]

Patchset #2 (id:200001) has been deleted

[commit-bot: I haz the power, 2016-09-20 11:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 11:59:38]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9220)

[heimbuef, 2016-09-20 12:07:20]

Description was changed from

==========
Pool implementation for zone segments


BUG=
==========

to

==========
Pool implementation for zone segments


BUG=5409
==========

[heimbuef, 2016-09-20 12:07:29]

Description was changed from

==========
Pool implementation for zone segments


BUG=5409
==========

to

==========
Pool implementation for zone segments


BUG=v8:5409
==========

[heimbuef, 2016-09-20 13:02:49]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 13:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:05:28]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/13076)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9224)

[heimbuef, 2016-09-20 13:22:22]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 13:22:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[heimbuef, 2016-09-20 13:22:39]

Patchset #4 (id:260001) has been deleted

[heimbuef, 2016-09-20 13:22:47]

Patchset #3 (id:240001) has been deleted

[commit-bot: I haz the power, 2016-09-20 14:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:06:26]

Dry run: This issue passed the CQ dry run.

[heimbuef, 2016-09-20 16:33:46]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:33:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 17:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:04:10]

Dry run: This issue passed the CQ dry run.

[heimbuef, 2016-09-21 07:43:43]

Seems to work with blink now.

PTAL

[heimbuef, 2016-09-21 07:44:10]

PTAL

[Toon Verwaest, 2016-09-21 11:14:32]

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
File src/zone/accounting-allocator.cc (right):

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:91: if (requested_size > 1 <<
kMaxSegmentSizePower) {
(1<<kMaxSeg...) to make it obvious

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:100: DCHECK_GE(power, 0);
LE(0, power)

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:106: if (segment) {
segment != nullptr

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:118: // PrintF("%f; 0;-%lu\n",
static_cast<double>(clock() - begin) /
drop debug code

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:127: if (size >= (1 << (kMaxSegmentSizePower +
1))) {
I generally prefer the style if (size >= ..) return false; to keep these
conditions more compact. Same in many other places in the code...

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:139: power -= kMinSegmentSizePower;
Add helper method to share with code above

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:144: base::LockGuard<base::Mutex>
lock_guard(unused_segments_mutex_);
why is this locked differently?

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:156: // PrintF("%f; 0;+%lu\n",
static_cast<double>(clock() - begin) /
drop debug code

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:170: 
drop these newlines

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.h:25: // Gets an empty segment from pool or
creates a new one.
the pool

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.h:27: // Return non needed segments here to insert
them into the pool
Return unneeded segments to either insert them into the pool or release them if
the pool is already full.

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.h:28: // or release them in case the pool is full.
Operation may or may
drop "or may not"

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.h:48: // Frees a non needed segment. Blocks the
current thread.
unneeded

[Toon Verwaest, 2016-09-21 11:18:08]

https://codereview.chromium.org/2335343007/diff/340001/src/zone/accounting-al...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2335343007/diff/340001/src/zone/accounting-al...
src/zone/accounting-allocator.h:59: Segment** unused_segments_heads_ =
Segment* unused_segments_heads_[1+kMax-kMin], same for sizes.

[heimbuef, 2016-09-21 11:36:10]

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
File src/zone/accounting-allocator.cc (right):

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:91: if (requested_size > 1 <<
kMaxSegmentSizePower) {
On 2016/09/21 at 11:14:31, Toon Verwaest wrote:
> (1<<kMaxSeg...) to make it obvious

Format check wont let that pass.

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:139: power -= kMinSegmentSizePower;
On 2016/09/21 at 11:14:31, Toon Verwaest wrote:
> Add helper method to share with code above

It's not exactly the same. There can be segments of intermediate size (so no
potencies of 2) in the buckets.

https://codereview.chromium.org/2335343007/diff/320001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:144: base::LockGuard<base::Mutex>
lock_guard(unused_segments_mutex_);
On 2016/09/21 at 11:14:31, Toon Verwaest wrote:
> why is this locked differently?

Done.

[heimbuef, 2016-09-21 11:39:23]

https://codereview.chromium.org/2335343007/diff/340001/src/zone/accounting-al...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2335343007/diff/340001/src/zone/accounting-al...
src/zone/accounting-allocator.h:59: Segment** unused_segments_heads_ =
On 2016/09/21 at 11:18:07, Toon Verwaest wrote:
> Segment* unused_segments_heads_[1+kMax-kMin], same for sizes.

Format checker does not like no spaces in between operands and operators. Also,
this does not work because it would mean that the head-segments would be stored
actually in the accounting-allocator. They can't, because they *are* just the
headers of the chunks of memory we dynamically allocate and free here.

[heimbuef, 2016-09-22 08:01:01]

PTAL

[Toon Verwaest, 2016-09-22 08:41:37]

https://codereview.chromium.org/2335343007/diff/380001/src/zone/accounting-al...
File src/zone/accounting-allocator.cc (right):

https://codereview.chromium.org/2335343007/diff/380001/src/zone/accounting-al...
src/zone/accounting-allocator.cc:134: DCHECK_GE(power, 0);
power is a uint8_t, so it can't be LT 0 ...

https://codereview.chromium.org/2335343007/diff/380001/src/zone/accounting-al...
File src/zone/accounting-allocator.h (right):

https://codereview.chromium.org/2335343007/diff/380001/src/zone/accounting-al...
src/zone/accounting-allocator.h:64: base::Mutex* unused_segments_mutex_ = new
base::Mutex();
base::Mutex unused_segments_mutex; ?

[heimbuef, 2016-09-22 12:06:59]

Patchset #9 (id:400001) has been deleted

[heimbuef, 2016-09-22 12:07:13]

PTAL

[heimbuef, 2016-09-22 12:07:22]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 12:07:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 12:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 12:36:51]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-09-22 12:53:00]

lgtm

[heimbuef, 2016-09-22 14:29:50]

The CQ bit was checked by heimbuef@google.com

[commit-bot: I haz the power, 2016-09-22 14:30:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 14:33:41]

Committed patchset #9 (id:420001)

[commit-bot: I haz the power, 2016-09-22 14:33:57]

Description was changed from

==========
Pool implementation for zone segments


BUG=v8:5409
==========

to

==========
Pool implementation for zone segments

BUG=v8:5409

Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Cr-Commit-Position: refs/heads/master@{#39631}
==========

[commit-bot: I haz the power, 2016-09-22 14:34:00]

Patchset 9 (id:??) landed as
https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Cr-Commit-Position: refs/heads/master@{#39631}

[Michael Hablich, 2016-09-23 06:00:30]

A revert of this CL (patchset #9 id:420001) has been created in
https://codereview.chromium.org/2365843002/ by hablich@chromium.org.

The reason for reverting is: Blocks Roll
https://codereview.chromium.org/2366733002/.

[heimbuef, 2016-09-23 08:55:46]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 08:55:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[heimbuef, 2016-09-23 09:10:58]

Patchset #10 (id:440001) has been deleted

[heimbuef, 2016-09-23 09:12:10]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 09:12:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 11:13:03]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build
URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

[heimbuef, 2016-10-06 09:18:47]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 09:18:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 09:47:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 09:47:35]

Dry run: This issue passed the CQ dry run.

[heimbuef, 2016-10-06 11:47:32]

Please take another look. Just fixed the blink build.

[jochen (gone - plz use gerrit), 2016-10-06 12:24:52]

jochen@chromium.org changed reviewers:
+ yangguo@chromium.org

[jochen (gone - plz use gerrit), 2016-10-06 12:24:53]

+yangguo for regexp stuff

https://codereview.chromium.org/2335343007/diff/480001/src/runtime/runtime-re...
File src/runtime/runtime-regexp.cc (right):

https://codereview.chromium.org/2335343007/diff/480001/src/runtime/runtime-re...
src/runtime/runtime-regexp.cc:384: static List<int>*
GetRewindedRegexpIndicesList(Isolate* isolate) {
Rewound

[heimbuef, 2016-10-06 12:51:22]

On 2016/10/06 at 12:24:53, jochen wrote:
> +yangguo for regexp stuff
> 
>
https://codereview.chromium.org/2335343007/diff/480001/src/runtime/runtime-re...
> File src/runtime/runtime-regexp.cc (right):
> 
>
https://codereview.chromium.org/2335343007/diff/480001/src/runtime/runtime-re...
> src/runtime/runtime-regexp.cc:384: static List<int>*
GetRewindedRegexpIndicesList(Isolate* isolate) {
> Rewound

Done.

[Jakob Kummerow, 2016-10-06 13:53:39]

LGTM with a nit.

https://codereview.chromium.org/2335343007/diff/500001/src/zone/zone.h
File src/zone/zone.h (right):

https://codereview.chromium.org/2335343007/diff/500001/src/zone/zone.h#newcode96
src/zone/zone.h:96: inline Segment* NewSegment(size_t size);
nit: please apply the "requested_size" renaming here too

[heimbuef, 2016-10-06 14:00:28]

On 2016/10/06 at 13:53:39, jkummerow wrote:
> LGTM with a nit.
> 
> https://codereview.chromium.org/2335343007/diff/500001/src/zone/zone.h
> File src/zone/zone.h (right):
> 
>
https://codereview.chromium.org/2335343007/diff/500001/src/zone/zone.h#newcode96
> src/zone/zone.h:96: inline Segment* NewSegment(size_t size);
> nit: please apply the "requested_size" renaming here too

Done.

[heimbuef, 2016-10-06 14:00:38]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-10-06 14:00:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2335343007/#ps520001
(title: "Reaction to comment")

[commit-bot: I haz the power, 2016-10-06 14:00:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:35:38]

Committed patchset #13 (id:520001)

[commit-bot: I haz the power, 2016-10-06 14:36:01]

Description was changed from

==========
Pool implementation for zone segments

BUG=v8:5409

Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Cr-Commit-Position: refs/heads/master@{#39631}
==========

to

==========
Pool implementation for zone segments

BUG=v8:5409

Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6
Cr-Original-Commit-Position: refs/heads/master@{#39631}
Cr-Commit-Position: refs/heads/master@{#40044}
==========

[commit-bot: I haz the power, 2016-10-06 14:36:03]

Patchset 13 (id:??) landed as
https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6
Cr-Commit-Position: refs/heads/master@{#40044}

[Michael Hablich, 2016-10-07 21:07:24]

A revert of this CL (patchset #13 id:520001) has been created in
https://codereview.chromium.org/2400343002/ by hablich@chromium.org.

The reason for reverting is: blocks roll:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64....

[heimbuef, 2016-10-10 17:07:59]

Patchset #14 (id:540001) has been deleted

[heimbuef, 2016-10-10 17:09:28]

The CQ bit was checked by heimbuef@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 17:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 17:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 17:42:31]

Dry run: This issue passed the CQ dry run.

[heimbuef, 2016-10-10 18:00:48]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-10-10 18:00:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2335343007/#ps560001
(title: "Fixed windows build")

[commit-bot: I haz the power, 2016-10-10 18:00:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 18:03:39]

Committed patchset #14 (id:560001)

[commit-bot: I haz the power, 2016-10-10 18:04:01]

Description was changed from

==========
Pool implementation for zone segments

BUG=v8:5409

Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6
Cr-Original-Commit-Position: refs/heads/master@{#39631}
Cr-Commit-Position: refs/heads/master@{#40044}
==========

to

==========
Pool implementation for zone segments

BUG=v8:5409

Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e
Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6
Committed: https://crrev.com/f29f3e320831f7eec8703b083dbbb91d88c65dca
Cr-Original-Original-Commit-Position: refs/heads/master@{#39631}
Cr-Original-Commit-Position: refs/heads/master@{#40044}
Cr-Commit-Position: refs/heads/master@{#40137}
==========

[commit-bot: I haz the power, 2016-10-10 18:04:03]

Patchset 14 (id:??) landed as
https://crrev.com/f29f3e320831f7eec8703b083dbbb91d88c65dca
Cr-Commit-Position: refs/heads/master@{#40137}