[inspector] enabled presubmit for inspector sub folder

[inspector] enabled presubmit for inspector sub folder

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/5925793d831a1202c3216b22709586b81fd4ab04
Cr-Commit-Position: refs/heads/master@{#39727}

[kozy, 2016-09-14 21:43:13]

Please take a look!

[kozy, 2016-09-14 23:38:38]

please take another look!

[dgozman, 2016-09-14 23:56:47]

lgtm

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16.h
File src/inspector/String16.h (right):

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16....
src/inspector/String16.h:26: explicit String16(const UChar* characters) :
m_impl(characters) {}
Let's do the same nolint here.

[alph, 2016-09-15 17:31:47]

lgtm

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16.cc
File src/inspector/String16.cc (right):

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16....
src/inspector/String16.cc:42: int64_t result = std::strtol(buffer.data(),
&endptr, 10);
strtol returns long. Does it compile?

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16....
src/inspector/String16.cc:88: uint8_t bytesToWrite = 0;
I don't see a point of using byte type here. Use the fastest one, which is
unsigned.

[kozy, 2016-09-24 01:35:56]

All done!

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16.cc
File src/inspector/String16.cc (right):

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16....
src/inspector/String16.cc:42: int64_t result = std::strtol(buffer.data(),
&endptr, 10);
On 2016/09/15 17:31:47, alph wrote:
> strtol returns long. Does it compile?

it compiles, I added static_cast to be sure.

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16....
src/inspector/String16.cc:88: uint8_t bytesToWrite = 0;
On 2016/09/15 17:31:47, alph wrote:
> I don't see a point of using byte type here. Use the fastest one, which is
> unsigned.

uint32_t

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16.h
File src/inspector/String16.h (right):

https://codereview.chromium.org/2343733002/diff/20001/src/inspector/String16....
src/inspector/String16.h:26: explicit String16(const UChar* characters) :
m_impl(characters) {}
On 2016/09/14 23:56:47, dgozman wrote:
> Let's do the same nolint here.

Done.

[kozy, 2016-09-24 01:36:14]

kozyatinskiy@chromium.org changed reviewers:
+ machenbach@chromium.org

[kozy, 2016-09-24 01:36:14]

Michael, please take a look!

[Michael Achenbach, 2016-09-26 11:59:33]

lgtm

[kozy, 2016-09-26 13:31:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-26 13:31:48]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2343733002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-26 13:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 13:59:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-26 13:59:42]

Description was changed from

==========
[inspector] enabled presubmit for inspector sub folder

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] enabled presubmit for inspector sub folder

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/5925793d831a1202c3216b22709586b81fd4ab04
Cr-Commit-Position: refs/heads/master@{#39727}
==========

[commit-bot: I haz the power, 2016-09-26 13:59:43]

Patchset 3 (id:??) landed as
https://crrev.com/5925793d831a1202c3216b22709586b81fd4ab04
Cr-Commit-Position: refs/heads/master@{#39727}