Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/inspector/v8-console.cc

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-console.h ('k') | src/inspector/v8-console-agent-impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-console.cc
diff --git a/src/inspector/v8-console.cc b/src/inspector/v8-console.cc
index dd3852efd373fc2e454b5938cfb1d82a62745130..96537951a46ed3e19bfdf7ee344f7bd3fa3056fd 100644
--- a/src/inspector/v8-console.cc
+++ b/src/inspector/v8-console.cc
@@ -29,10 +29,8 @@ v8::Local<v8::Private> inspectedContextPrivateKey(v8::Isolate* isolate) {
}
class ConsoleHelper {
- DISALLOW_COPY_AND_ASSIGN(ConsoleHelper);
-
public:
- ConsoleHelper(const v8::FunctionCallbackInfo<v8::Value>& info)
+ explicit ConsoleHelper(const v8::FunctionCallbackInfo<v8::Value>& info)
: m_info(info),
m_isolate(info.GetIsolate()),
m_context(info.GetIsolate()->GetCurrentContext()),
@@ -241,6 +239,8 @@ class ConsoleHelper {
return defaultValue;
return false;
}
+
+ DISALLOW_COPY_AND_ASSIGN(ConsoleHelper);
};
void returnDataCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
« no previous file with comments | « src/inspector/v8-console.h ('k') | src/inspector/v8-console-agent-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698