Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: src/inspector/injected-script.h

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/injected-script-native.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/injected-script.h
diff --git a/src/inspector/injected-script.h b/src/inspector/injected-script.h
index 41fc5d125a056ea822a3cbd84265475decd85ba4..9b324c948d4f59679501f86a1f4e01419590518d 100644
--- a/src/inspector/injected-script.h
+++ b/src/inspector/injected-script.h
@@ -52,8 +52,6 @@ using protocol::ErrorString;
using protocol::Maybe;
class InjectedScript final {
- DISALLOW_COPY_AND_ASSIGN(InjectedScript);
-
public:
static std::unique_ptr<InjectedScript> create(InspectedContext*);
~InjectedScript();
@@ -141,8 +139,6 @@ class InjectedScript final {
};
class ContextScope : public Scope {
- DISALLOW_COPY_AND_ASSIGN(ContextScope);
-
public:
ContextScope(ErrorString*, V8InspectorImpl*, int contextGroupId,
int executionContextId);
@@ -151,11 +147,11 @@ class InjectedScript final {
private:
void findInjectedScript(V8InspectorSessionImpl*) override;
int m_executionContextId;
+
+ DISALLOW_COPY_AND_ASSIGN(ContextScope);
};
class ObjectScope : public Scope {
- DISALLOW_COPY_AND_ASSIGN(ObjectScope);
-
public:
ObjectScope(ErrorString*, V8InspectorImpl*, int contextGroupId,
const String16& remoteObjectId);
@@ -168,11 +164,11 @@ class InjectedScript final {
String16 m_remoteObjectId;
String16 m_objectGroupName;
v8::Local<v8::Value> m_object;
+
+ DISALLOW_COPY_AND_ASSIGN(ObjectScope);
};
class CallFrameScope : public Scope {
- DISALLOW_COPY_AND_ASSIGN(CallFrameScope);
-
public:
CallFrameScope(ErrorString*, V8InspectorImpl*, int contextGroupId,
const String16& remoteCallFrameId);
@@ -183,6 +179,8 @@ class InjectedScript final {
void findInjectedScript(V8InspectorSessionImpl*) override;
String16 m_remoteCallFrameId;
size_t m_frameOrdinal;
+
+ DISALLOW_COPY_AND_ASSIGN(CallFrameScope);
};
private:
@@ -200,6 +198,8 @@ class InjectedScript final {
v8::Global<v8::Value> m_lastEvaluationResult;
std::unique_ptr<InjectedScriptNative> m_native;
v8::Global<v8::Object> m_commandLineAPI;
+
+ DISALLOW_COPY_AND_ASSIGN(InjectedScript);
};
} // namespace v8_inspector
« no previous file with comments | « no previous file | src/inspector/injected-script-native.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698