Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: src/inspector/string-16.h

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/java-script-call-frame.h ('k') | src/inspector/string-16.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/string-16.h
diff --git a/src/inspector/string-16.h b/src/inspector/string-16.h
index 7fd367bb4d24b63f9d15835faee14188cace11b7..94069479579fafaa6cffd3b1b80064914b9a3d3d 100644
--- a/src/inspector/string-16.h
+++ b/src/inspector/string-16.h
@@ -23,8 +23,9 @@ class String16 {
String16() {}
String16(const String16& other) : m_impl(other.m_impl) {}
String16(const UChar* characters, size_t size) : m_impl(characters, size) {}
- String16(const UChar* characters) : m_impl(characters) {}
- String16(const char* characters)
+ String16(const UChar* characters) // NOLINT(runtime/explicit)
+ : m_impl(characters) {}
+ String16(const char* characters) // NOLINT(runtime/explicit)
: String16(characters, std::strlen(characters)) {}
String16(const char* characters, size_t size) {
m_impl.resize(size);
« no previous file with comments | « src/inspector/java-script-call-frame.h ('k') | src/inspector/string-16.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698