Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/inspector/java-script-call-frame.h

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/inspected-context.h ('k') | src/inspector/string-16.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_ 31 #ifndef V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_
32 #define V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_ 32 #define V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_
33 33
34 #include <vector>
35
34 #include "src/base/macros.h" 36 #include "src/base/macros.h"
35 #include "src/inspector/protocol-platform.h" 37 #include "src/inspector/protocol-platform.h"
36 38
37 #include "include/v8.h" 39 #include "include/v8.h"
38 40
39 #include <vector>
40
41 namespace v8_inspector { 41 namespace v8_inspector {
42 42
43 class JavaScriptCallFrame { 43 class JavaScriptCallFrame {
44 DISALLOW_COPY_AND_ASSIGN(JavaScriptCallFrame);
45
46 public: 44 public:
47 static std::unique_ptr<JavaScriptCallFrame> create( 45 static std::unique_ptr<JavaScriptCallFrame> create(
48 v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame) { 46 v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame) {
49 return wrapUnique(new JavaScriptCallFrame(debuggerContext, callFrame)); 47 return wrapUnique(new JavaScriptCallFrame(debuggerContext, callFrame));
50 } 48 }
51 ~JavaScriptCallFrame(); 49 ~JavaScriptCallFrame();
52 50
53 int sourceID() const; 51 int sourceID() const;
54 int line() const; 52 int line() const;
55 int column() const; 53 int column() const;
(...skipping 10 matching lines...) Expand all
66 64
67 private: 65 private:
68 JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext, 66 JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext,
69 v8::Local<v8::Object> callFrame); 67 v8::Local<v8::Object> callFrame);
70 68
71 int callV8FunctionReturnInt(const char* name) const; 69 int callV8FunctionReturnInt(const char* name) const;
72 70
73 v8::Isolate* m_isolate; 71 v8::Isolate* m_isolate;
74 v8::Global<v8::Context> m_debuggerContext; 72 v8::Global<v8::Context> m_debuggerContext;
75 v8::Global<v8::Object> m_callFrame; 73 v8::Global<v8::Object> m_callFrame;
74
75 DISALLOW_COPY_AND_ASSIGN(JavaScriptCallFrame);
76 }; 76 };
77 77
78 using JavaScriptCallFrames = std::vector<std::unique_ptr<JavaScriptCallFrame>>; 78 using JavaScriptCallFrames = std::vector<std::unique_ptr<JavaScriptCallFrame>>;
79 79
80 } // namespace v8_inspector 80 } // namespace v8_inspector
81 81
82 #endif // V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_ 82 #endif // V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_
OLDNEW
« no previous file with comments | « src/inspector/inspected-context.h ('k') | src/inspector/string-16.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698