Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: src/inspector/v8-stack-trace-impl.h

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-schema-agent-impl.h ('k') | tools/presubmit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-stack-trace-impl.h
diff --git a/src/inspector/v8-stack-trace-impl.h b/src/inspector/v8-stack-trace-impl.h
index f23dbbf6f7282d431c89ceb86c601f0446bb27a9..f0a452e9390dd8dccbbdadac41103dfeae4b32ad 100644
--- a/src/inspector/v8-stack-trace-impl.h
+++ b/src/inspector/v8-stack-trace-impl.h
@@ -5,14 +5,14 @@
#ifndef V8_INSPECTOR_V8STACKTRACEIMPL_H_
#define V8_INSPECTOR_V8STACKTRACEIMPL_H_
+#include <vector>
+
#include "src/base/macros.h"
#include "src/inspector/protocol/Forward.h"
#include "src/inspector/protocol/Runtime.h"
#include "include/v8-inspector.h"
-#include <vector>
-
namespace v8_inspector {
class TracedValue;
@@ -23,8 +23,6 @@ class V8Debugger;
// that current native-only state had some async story.
// On the other hand, any non-top async stack is guaranteed to be non-empty.
class V8StackTraceImpl final : public V8StackTrace {
- DISALLOW_COPY_AND_ASSIGN(V8StackTraceImpl);
-
public:
static const size_t maxCallStackSizeToCapture = 200;
@@ -92,6 +90,8 @@ class V8StackTraceImpl final : public V8StackTrace {
String16 m_description;
std::vector<Frame> m_frames;
std::unique_ptr<V8StackTraceImpl> m_parent;
+
+ DISALLOW_COPY_AND_ASSIGN(V8StackTraceImpl);
};
} // namespace v8_inspector
« no previous file with comments | « src/inspector/v8-schema-agent-impl.h ('k') | tools/presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698