tools/presubmit.py - Issue 2343733002: [inspector] enabled presubmit for inspector sub folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/presubmit.py

Issue 2343733002: [inspector] enabled presubmit for inspector sub folder (Closed)

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index a4db69a6f5414a9d66ade28c584725147001be3d..bd541a2d8ad21eebfb4a8055528139e7ad4bd642 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -192,9 +192,8 @@ class CppLintProcessor(SourceFileProcessor):

return name.endswith('.cc') or name.endswith('.h')

def IgnoreDir(self, name):

- # TODO(dgozman): remove inspector after fixing the issues.

return (super(CppLintProcessor, self).IgnoreDir(name)

- or (name == 'third_party') or (name == 'inspector'))

+ or (name == 'third_party'))

IGNORE_LINT = ['flag-definitions.h']

« no previous file with comments | « src/inspector/v8-stack-trace-impl.h ('k') | no next file » | no next file with comments »